[ https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066309#comment-16066309 ]
ASF GitHub Bot commented on FLINK-7014: --------------------------------------- Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4200#discussion_r124506864 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala --- @@ -458,4 +459,52 @@ class ExpressionReductionTest extends TableTestBase { util.verifySql(sqlQuery, expected) } + // todo this NPE is caused by Calcite, it shall pass when [CALCITE-1860] is fixed + @Ignore + @Test(expected = classOf[NullPointerException]) --- End diff -- Yes, the expected test result should not throw exception. > Expose isDeterministic interface to ScalarFunction and TableFunction > -------------------------------------------------------------------- > > Key: FLINK-7014 > URL: https://issues.apache.org/jira/browse/FLINK-7014 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Ruidong Li > Assignee: Ruidong Li > > Currently, the `isDeterministic` method of implementations of `SqlFuntion` > are always returning true, which cause inappropriate optimization in Calcite, > such as taking user's stateful UDF as a pure functional procedure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)