Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4195#discussion_r124492599
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -237,8 +254,15 @@ public boolean isEmpty() {
                                                computationState.getCounter());
     
                                newComputationStates = Collections.emptyList();
    +                           nfaChanged = true;
    --- End diff --
    
    Just a question/side comment. This case always happens in pair with pruning 
sharedBuffer right? (NFA:330)
    
    I would still leave it here, cause it's better be safe than sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to