[GitHub] [flink] flinkbot commented on pull request #23032: [FLINK-32418][formats-protobuf] Fix ClassNotFoundException when using protobuf in SQL-Client

flinkbot commented on PR #23032: URL: https://github.com/apache/flink/pull/23032#issuecomment-1643380791 ## CI report: * 34b25eff15099bafd3c98e81c59b6e1822012513 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23031: [FLINK-32508][metrics][prometheus] Add support for native counters an…

flinkbot commented on PR #23031: URL: https://github.com/apache/flink/pull/23031#issuecomment-1643375852 ## CI report: * 5ff074ca6c2aead80c9ba5113313463bd3e406b1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen merged pull request #22924: [FLINK-32404][table] Add catalog modification listener interface and create listener for catalog manager

PatrickRen merged PR #22924: URL: https://github.com/apache/flink/pull/22924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Updated] (FLINK-32418) ClassNotFoundException when using flink-protobuf with sql-client

[ https://issues.apache.org/jira/browse/FLINK-32418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32418: --- Labels: pull-request-available (was: ) > ClassNotFoundException when using flink-protobuf w

[GitHub] [flink] m-kay opened a new pull request, #23032: [FLINK-32418][formats-protobuf] Fix ClassNotFoundException when using protobuf in SQL-Client

m-kay opened a new pull request, #23032: URL: https://github.com/apache/flink/pull/23032 ## Purpose of the change *This pull request changes protobuf format to always use the classloader which is passed on creation for the `DynamicTableFactory.Context` instead of using the thread loc

[GitHub] [flink] hlteoh37 opened a new pull request, #23031: [FLINK-32508][metrics][prometheus] Add support for native counters an…

hlteoh37 opened a new pull request, #23031: URL: https://github.com/apache/flink/pull/23031 …d histograms in prometheus ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That

[GitHub] [flink] PatrickRen merged pull request #22869: [FLINK-32403][table] Add database related operations in CatalogManager

PatrickRen merged PR #22869: URL: https://github.com/apache/flink/pull/22869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Updated] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32508: --- Labels: pull-request-available (was: ) > Flink-Metrics Prometheus - Native Histograms / Nat

[jira] [Assigned] (FLINK-32634) Deprecate StreamRecordTimestamp and ExistingField

[ https://issues.apache.org/jira/browse/FLINK-32634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32634: Assignee: Jane Chan > Deprecate StreamRecordTimestamp and ExistingField > ---

[jira] [Updated] (FLINK-32634) Deprecate StreamRecordTimestamp and ExistingField

[ https://issues.apache.org/jira/browse/FLINK-32634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-32634: -- Description: `StreamRecordTimestamp` and `ExistingField` extends the deprecated `TimestampExtractor`,

[jira] [Created] (FLINK-32634) Deprecate StreamRecordTimestamp and ExistingField

Jane Chan created FLINK-32634: - Summary: Deprecate StreamRecordTimestamp and ExistingField Key: FLINK-32634 URL: https://issues.apache.org/jira/browse/FLINK-32634 Project: Flink Issue Type: Sub-t

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1643174801 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Updated] (FLINK-30559) May get wrong result for `if` expression if it's string data type

[ https://issues.apache.org/jira/browse/FLINK-30559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-30559: Fix Version/s: 1.18.0 1.16.3 1.17.2 > May get wrong result for `if`

[jira] [Resolved] (FLINK-30559) May get wrong result for `if` expression if it's string data type

[ https://issues.apache.org/jira/browse/FLINK-30559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-30559. - Resolution: Duplicate > May get wrong result for `if` expression if it's string data type >

[jira] [Reopened] (FLINK-30559) May get wrong result for `if` expression if it's string data type

[ https://issues.apache.org/jira/browse/FLINK-30559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reopened FLINK-30559: - > May get wrong result for `if` expression if it's string data type > --

[jira] [Assigned] (FLINK-32559) Deprecate Queryable State

[ https://issues.apache.org/jira/browse/FLINK-32559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-32559: Assignee: Xintong Song > Deprecate Queryable State > - > >

[jira] [Comment Edited] (FLINK-5336) Make Path immutable

[ https://issues.apache.org/jira/browse/FLINK-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744452#comment-17744452 ] Wencong Liu edited comment on FLINK-5336 at 7/20/23 4:13 AM: -

[GitHub] [flink] masteryhx commented on a diff in pull request #22744: [FLINK-29802][state] Changelog supports native savepoint

masteryhx commented on code in PR #22744: URL: https://github.com/apache/flink/pull/22744#discussion_r1268880413 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -375,6 +378,51 @@ public Ru

[GitHub] [flink] LadyForest commented on a diff in pull request #22593: [FLINK-32053][table-planner] Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

LadyForest commented on code in PR #22593: URL: https://github.com/apache/flink/pull/22593#discussion_r1268866818 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java: ## @@ -71,20 +75,36 @@

[jira] [Comment Edited] (FLINK-5336) Make Path immutable

[ https://issues.apache.org/jira/browse/FLINK-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744452#comment-17744452 ] Wencong Liu edited comment on FLINK-5336 at 7/20/23 2:32 AM: -

[jira] [Closed] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

[ https://issues.apache.org/jira/browse/FLINK-32578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32578. --- > Cascaded group by window time columns on a proctime window aggregate may > result hang for ever > ---

[jira] [Commented] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

[ https://issues.apache.org/jira/browse/FLINK-32578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744847#comment-17744847 ] lincoln lee commented on FLINK-32578: - Fixed in 1.17: dc8b70c2fcbb429a27a9cc1e263d9a

[GitHub] [flink] flinkbot commented on pull request #23030: fix(sec): upgrade com.google.guava:guava to 32.0.0-jre

flinkbot commented on PR #23030: URL: https://github.com/apache/flink/pull/23030#issuecomment-1643008141 ## CI report: * 4c9b2396007652e405eb3fcd537afac0fd0ab1e5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lincoln-lil merged pull request #23022: [FLINK-32578][table-planner] Fix wrong plan which group by window time columns on a proctime window operator may result hang for ever

lincoln-lil merged PR #23022: URL: https://github.com/apache/flink/pull/23022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink-connector-pulsar] syhily commented on pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

syhily commented on PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#issuecomment-1642986077 Cool, I'm so happy to see that we finally have the JDK 11 test support. The extensive off heap memory usage in Pulsar client could be the main cause of the OOM in JDK 11. Shoul

[GitHub] [flink] hackergin commented on pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

hackergin commented on PR #22937: URL: https://github.com/apache/flink/pull/22937#issuecomment-1642970805 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-32633) Kubernetes e2e test is not stable

Fang Yong created FLINK-32633: - Summary: Kubernetes e2e test is not stable Key: FLINK-32633 URL: https://issues.apache.org/jira/browse/FLINK-32633 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-32632) Run Kubernetes test is unstable on AZP

Sergey Nuyanzin created FLINK-32632: --- Summary: Run Kubernetes test is unstable on AZP Key: FLINK-32632 URL: https://issues.apache.org/jira/browse/FLINK-32632 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-31958) Table to DataStream allow partial fields

[ https://issues.apache.org/jira/browse/FLINK-31958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744768#comment-17744768 ] padavan commented on FLINK-31958: - Perhaps it should be moved to the bugs category? Or i

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

reswqa commented on code in PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268492288 ## flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerUtils.java: ## @@ -35,9 +35,11 @@ public class Flin

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

reswqa commented on code in PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268484338 ## flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerUtils.java: ## @@ -35,9 +35,11 @@ public class Flin

[GitHub] [flink-web] lindong28 commented on pull request #664: Allow content to expire

lindong28 commented on PR #664: URL: https://github.com/apache/flink-web/pull/664#issuecomment-1642427268 @MartijnVisser Thanks for the comments. flink-ml docs is built by this script https://github.com/apache/infrastructure-bb2/blob/master/flink-ml.py. This script is executed every

[jira] [Updated] (FLINK-32631) FlinkSessionJob stuck in Created/Reconciling state because of No Job found error in JobManager

[ https://issues.apache.org/jira/browse/FLINK-32631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhupendra Yadav updated FLINK-32631: Description: {*}Background{*}: We are using FlinkSessionJob for submitting jobs to a sessi

[jira] [Created] (FLINK-32631) FlinkSessionJob stuck in Created/Reconciling state because of No Job found error in JobManager

Bhupendra Yadav created FLINK-32631: --- Summary: FlinkSessionJob stuck in Created/Reconciling state because of No Job found error in JobManager Key: FLINK-32631 URL: https://issues.apache.org/jira/browse/FLINK-326

[GitHub] [flink] flinkbot commented on pull request #23029: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

flinkbot commented on PR #23029: URL: https://github.com/apache/flink/pull/23029#issuecomment-1642417243 ## CI report: * b1967c4704f16360d638e3778509a2b2840c1b2e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #23028: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

flinkbot commented on PR #23028: URL: https://github.com/apache/flink/pull/23028#issuecomment-1642407541 ## CI report: * 939c4fb6b8bb3f8e47d62fda3d8f01f8f69c65b6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

tisonkun commented on code in PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268324359 ## flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerUtils.java: ## @@ -35,9 +35,11 @@ public class Fl

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

tisonkun commented on code in PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268323229 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/common/MiniClusterTestEnvironment.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to

[jira] [Resolved] (FLINK-32469) Improve checkpoint REST APIs for programmatic access

[ https://issues.apache.org/jira/browse/FLINK-32469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-32469. --- Resolution: Done > Improve checkpoint REST APIs for programmatic access > --

[jira] [Commented] (FLINK-32469) Improve checkpoint REST APIs for programmatic access

[ https://issues.apache.org/jira/browse/FLINK-32469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744702#comment-17744702 ] Danny Cranmer commented on FLINK-32469: --- Merged commit [{{7b9b4e5}}|https://githu

[GitHub] [flink] flinkbot commented on pull request #23027: [FLINK-32616][jdbc-driver] Close result for non-query in executeQuery

flinkbot commented on PR #23027: URL: https://github.com/apache/flink/pull/23027#issuecomment-1642372445 ## CI report: * 55e9c628f6d3e2de3c0a00342ab6f86c78eca10b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] lsyldliu commented on pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

lsyldliu commented on PR #23012: URL: https://github.com/apache/flink/pull/23012#issuecomment-1642369509 @wuchong Thanks for review, I've updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-32616) FlinkStatement#executeQuery resource leaks when the input sql is not query

[ https://issues.apache.org/jira/browse/FLINK-32616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32616: --- Labels: pull-request-available (was: ) > FlinkStatement#executeQuery resource leaks when th

[GitHub] [flink] FangYongs opened a new pull request, #23027: [FLINK-32616][jdbc-driver] Close result for non-query in executeQuery

FangYongs opened a new pull request, #23027: URL: https://github.com/apache/flink/pull/23027 ## What is the purpose of the change This pr aims to close statement result in FlinkStatement.executeQuery when the statement is not a query sql. ## Brief change log - Close statem

[GitHub] [flink] lsyldliu commented on a diff in pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

lsyldliu commented on code in PR #23012: URL: https://github.com/apache/flink/pull/23012#discussion_r1268292637 ## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/JsonRowDataSerDeSchemaTest.java: ## @@ -724,7 +786,7 @@ private void testParseErrors(TestSpec s

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #627: [FLINK-32551] Add option to take a savepoint on flinkdeployment/flinksessionjob deletion

gyfora commented on PR #627: URL: https://github.com/apache/flink-kubernetes-operator/pull/627#issuecomment-1642349101 I am closing this based on feedback from @JTaky (Oleksandr Nitavskyi) -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink-kubernetes-operator] JTaky commented on pull request #634: [FLINK-32551] Add option to take a savepoint when deleting a flinkdeployment/flinksessionjob

JTaky commented on PR #634: URL: https://github.com/apache/flink-kubernetes-operator/pull/634#issuecomment-1642264925 > Are you working with @ashangit ? Just curious because he also has an open PR and the JIRA is on him yes, he is OOO currently, I am continuing his development. Would

[GitHub] [flink-web] MartijnVisser commented on pull request #664: Allow content to expire

MartijnVisser commented on PR #664: URL: https://github.com/apache/flink-web/pull/664#issuecomment-1642260699 > Do you have time to review this PR? Sure. I do think that there's a different issue. This `.htaccess` file is only used on https://flink.apache.org project website, but not

[GitHub] [flink] hackergin commented on a diff in pull request #22939: [FLINK-32474][table] Support time travel in table planner

hackergin commented on code in PR #22939: URL: https://github.com/apache/flink/pull/22939#discussion_r1268198538 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkCalciteSqlValidator.java: ## @@ -125,4 +162,118 @@ public void validateCo

[GitHub] [flink] hackergin commented on a diff in pull request #22939: [FLINK-32474][table] Support time travel in table planner

hackergin commented on code in PR #22939: URL: https://github.com/apache/flink/pull/22939#discussion_r1268195677 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2927,7 +2948,37 @@ private void convertTemporalTable(Blackb

[jira] [Closed] (FLINK-32615) Cache AutoscalerInfo for each resource

[ https://issues.apache.org/jira/browse/FLINK-32615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32615. -- Fix Version/s: kubernetes-operator-1.6.0 Resolution: Fixed merged to main 0c341ebe13645f4e9802c

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

gyfora merged PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-32589) Carry over parallelism overrides to prevent users from clearing them on updates

[ https://issues.apache.org/jira/browse/FLINK-32589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32589. -- Fix Version/s: kubernetes-operator-1.6.0 Resolution: Fixed merged to main 9fe68251eb1a37333a6e8

[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1268184648 ## flink-core/src/main/java/org/apache/flink/api/common/functions/Function.java: ## @@ -27,4 +28,16 @@ * method) interfaces that can be implemented via Java 8 lambdas

[jira] [Commented] (FLINK-19249) Detect broken connections in case TCP Timeout takes too long.

[ https://issues.apache.org/jira/browse/FLINK-19249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744645#comment-17744645 ] Piotr Nowojski commented on FLINK-19249: Hi [~Jiangang], no sorry there was no p

[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1268169556 ## flink-core/src/main/java/org/apache/flink/api/common/functions/Function.java: ## @@ -27,4 +28,16 @@ * method) interfaces that can be implemented via Java 8 lambdas

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

mxm commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1268149481 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java: ## @@ -17,15 +17,19 @@ package

[GitHub] [flink] huwh commented on pull request #22861: [FLINK-32387][runtime] InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

huwh commented on PR #22861: URL: https://github.com/apache/flink/pull/22861#issuecomment-1642164847 @wanglijie95 I squash the commits and rebase to master branch. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [flink] twalthr commented on a diff in pull request #22593: [FLINK-32053][table-planner] Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

twalthr commented on code in PR #22593: URL: https://github.com/apache/flink/pull/22593#discussion_r1268129439 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java: ## @@ -71,20 +75,36 @@

[GitHub] [flink] twalthr commented on a diff in pull request #22593: [FLINK-32053][table-planner] Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

twalthr commented on code in PR #22593: URL: https://github.com/apache/flink/pull/22593#discussion_r1268129439 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java: ## @@ -71,20 +75,36 @@

[GitHub] [flink] twalthr commented on a diff in pull request #22593: [FLINK-32053][table-planner] Introduce StateMetadata to ExecNode to support configure operator-level state TTL via CompiledPlan

twalthr commented on code in PR #22593: URL: https://github.com/apache/flink/pull/22593#discussion_r1268129439 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java: ## @@ -71,20 +75,36 @@

[GitHub] [flink-connector-pulsar] reswqa commented on a diff in pull request #55: [FLINK-24302] Extend offheap memory for JDK11 test coverage

reswqa commented on code in PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268105952 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/common/MiniClusterTestEnvironment.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to th

[GitHub] [flink] fredia commented on pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on PR #22772: URL: https://github.com/apache/flink/pull/22772#issuecomment-1642089197 @rkhachatryan Thanks for the review, I have addressed your comments. It could be very nice if you could take another look :) -- This is an automated message from the Apache Git Service.

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268077347 ## docs/content/docs/ops/metrics.md: ## @@ -1343,6 +1343,11 @@ Note that for failed checkpoints, metrics are updated on a best efforts basis an The time in nanos

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268060700 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -128,6 +134,29 @@ public TaskIOMetricGroup(TaskMetricGroup parent) {

[GitHub] [flink] fredia commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

fredia commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1268058951 ## flink-runtime/src/test/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroupTest.java: ## @@ -95,6 +95,15 @@ void testTaskIOMetricGroup() throws InterruptedE

[GitHub] [flink-kubernetes-operator] JTaky opened a new pull request, #634: [FLINK-32551] Add option to take a savepoint when deleting a flinkdeployment/flinksessionjob

JTaky opened a new pull request, #634: URL: https://github.com/apache/flink-kubernetes-operator/pull/634 ## What is the purpose of the change Add an operator option to make savepoint on FlinkDeployment/FlinkSessionJob deletion. Default behaviour is not changed and no savepoint

[jira] [Commented] (FLINK-32619) ConfigOptions to support fallback configuration

[ https://issues.apache.org/jira/browse/FLINK-32619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744606#comment-17744606 ] Hong Liang Teoh commented on FLINK-32619: - That's a great callout [~wangm92] . W

[jira] [Resolved] (FLINK-32619) ConfigOptions to support fallback configuration

[ https://issues.apache.org/jira/browse/FLINK-32619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-32619. - Resolution: Not A Problem > ConfigOptions to support fallback configuration > --

[jira] [Assigned] (FLINK-32630) The log level of job failed info should change from INFO to WARN/ERROR if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-32630: - Assignee: Matt Wang > The log level of job failed info should change from INFO to WARN/ERROR if

[jira] [Commented] (FLINK-32630) The log level of job failed info should change from INFO to WARN/ERROR if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744605#comment-17744605 ] Zili Chen commented on FLINK-32630: --- You can ping me on a patch ready. > The log leve

[jira] [Commented] (FLINK-24302) Direct buffer memory leak on Pulsar connector with Java 11

[ https://issues.apache.org/jira/browse/FLINK-24302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744604#comment-17744604 ] Zili Chen commented on FLINK-24302: --- Pending to close. This should be an issue on the

[jira] [Commented] (FLINK-24302) Direct buffer memory leak on Pulsar connector with Java 11

[ https://issues.apache.org/jira/browse/FLINK-24302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744603#comment-17744603 ] Zili Chen commented on FLINK-24302: --- Workaround to turn on tests for JDK11 in https:/

[jira] [Updated] (FLINK-32630) The log level of job failed info should change from INFO to WARN/ERROR if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Wang updated FLINK-32630: -- Summary: The log level of job failed info should change from INFO to WARN/ERROR if job failed (was: T

[jira] [Updated] (FLINK-32630) The log level of job failed info should change from info to warn/error if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Wang updated FLINK-32630: -- Summary: The log level of job failed info should change from info to warn/error if job failed (was: T

[jira] [Commented] (FLINK-32630) The log level should change from info to warn/error if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744584#comment-17744584 ] Matt Wang commented on FLINK-32630: --- hi, [~tison] [~Weijie Guo] I think this is a poin

[jira] [Closed] (FLINK-32586) Enable input locality in SimpleExecutionSlotAllocator

[ https://issues.apache.org/jira/browse/FLINK-32586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-32586. --- Resolution: Done Done via e732edb41a423f19d5eefc397ddbfacadaf0179e > Enable input locality in SimpleExecuti

[jira] [Updated] (FLINK-32630) The log level should change from info to warn/error if job failed

[ https://issues.apache.org/jira/browse/FLINK-32630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Wang updated FLINK-32630: -- Description: When a job fails to submit or run, the following log level should be changed to WARN or

[GitHub] [flink] zhuzhurk closed pull request #23009: [FLINK-32586][coordination] Enable input locality in SimpleExecutionSlotAllocator.

zhuzhurk closed pull request #23009: [FLINK-32586][coordination] Enable input locality in SimpleExecutionSlotAllocator. URL: https://github.com/apache/flink/pull/23009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Created] (FLINK-32630) The log level should change from info to warn/error if job failed

Matt Wang created FLINK-32630: - Summary: The log level should change from info to warn/error if job failed Key: FLINK-32630 URL: https://issues.apache.org/jira/browse/FLINK-32630 Project: Flink

[jira] [Resolved] (FLINK-32552) Mixed up Flink session job deployments

[ https://issues.apache.org/jira/browse/FLINK-32552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabio Wanner resolved FLINK-32552. -- Release Note: Not a bug of the flink k8s operator. Resolution: Not A Bug > Mixed up Flin

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1267947674 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveServer2DelegationTokenProvider.java: ## @@ -0,0 +1,232 @@ +/* + * License

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

gyfora commented on PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#issuecomment-1641872870 @mxm let me know if you have further comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-32623) Rest api doesn't return minimum resource requirements correctly

[ https://issues.apache.org/jira/browse/FLINK-32623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-32623. Resolution: Fixed master: 6b3d291f6a573fb34a528313e5683d3a48a66771 > Rest api doesn't ret

[GitHub] [flink] zentol merged pull request #23014: [FLINK-32623] Return correct vertex resource lower bound

zentol merged PR #23014: URL: https://github.com/apache/flink/pull/23014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1267888031 ## flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java: ## @@ -637,4 +637,16 @@ public int hashCode() { result = 31 * result + (int) (bufferT

[jira] [Commented] (FLINK-32592) (Stream)ExEnv#initializeContextEnvironment isn't thread-safe

[ https://issues.apache.org/jira/browse/FLINK-32592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744529#comment-17744529 ] Chesnay Schepler commented on FLINK-32592: -- master: 13d35365f677813d5f0090f121e

[GitHub] [flink] zentol merged pull request #22997: [FLINK-32592] Fix (Stream)ExEnv#initializeContextEnvironment thread-safety

zentol merged PR #22997: URL: https://github.com/apache/flink/pull/22997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #22931: [FLINK-32514] Support configuring checkpointing interval during process backlog

yunfengzhou-hub commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1267876016 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -2079,11 +2149,19 @@ private final class ScheduledTrigger i

[GitHub] [flink] zentol commented on pull request #22997: [FLINK-32592] Fix (Stream)ExEnv#initializeContextEnvironment thread-safety

zentol commented on PR #22997: URL: https://github.com/apache/flink/pull/22997#issuecomment-1641827665 > I'm curious about the fallback behavior in case you don't have thread local context. An atomic reference or volatile field would be better than what exists right now. I don't kno

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #22931: [FLINK-32514] Support configuring checkpointing interval during process backlog

yunfengzhou-hub commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1267876016 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -2079,11 +2149,19 @@ private final class ScheduledTrigger i

[GitHub] [flink] zentol commented on a diff in pull request #22997: [FLINK-32592] Fix (Stream)ExEnv#initializeContextEnvironment thread-safety

zentol commented on code in PR #22997: URL: https://github.com/apache/flink/pull/22997#discussion_r1267872976 ## flink-java/src/test/java/org/apache/flink/api/java/ExecutionEnvironmentTest.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1267868354 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java: ## @@ -184,6 +184,9 @@ public static JobGraph createJobGraph

[GitHub] [flink] dmvk commented on pull request #22997: [FLINK-32592] Fix (Stream)ExEnv#initializeContextEnvironment thread-safety

dmvk commented on PR #22997: URL: https://github.com/apache/flink/pull/22997#issuecomment-1641815189 I'm curious about the fallback behavior in case you don't have thread local context. 🤔 Especially since the `contextEnvironmentFactory` is not marked as volatile. I guess the correct behavio

[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

RanJinh commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1267862410 ## flink-core/src/main/java/org/apache/flink/api/common/functions/Function.java: ## @@ -27,4 +28,16 @@ * method) interfaces that can be implemented via Java 8 lambdas

[GitHub] [flink] dmvk commented on a diff in pull request #22997: [FLINK-32592] Fix (Stream)ExEnv#initializeContextEnvironment thread-safety

dmvk commented on code in PR #22997: URL: https://github.com/apache/flink/pull/22997#discussion_r1267858802 ## flink-java/src/test/java/org/apache/flink/api/java/ExecutionEnvironmentTest.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [flink] yunfengzhou-hub commented on a diff in pull request #22931: [FLINK-32514] Support configuring checkpointing interval during process backlog

yunfengzhou-hub commented on code in PR #22931: URL: https://github.com/apache/flink/pull/22931#discussion_r1267857378 ## flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java: ## @@ -164,6 +167,15 @@ public void lazyInitializ

[GitHub] [flink-connector-pulsar] tisonkun commented on pull request #55: [FLINK-24302] Test coverage for JDK 11

tisonkun commented on PR #55: URL: https://github.com/apache/flink-connector-pulsar/pull/55#issuecomment-1641787804 Pending to merge... @syhily do we have a ticket for supporting table connector already? Or I should open a new one? It should be my next step to track. -- This is an

[GitHub] [flink] flinkbot commented on pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API

flinkbot commented on PR #23026: URL: https://github.com/apache/flink/pull/23026#issuecomment-1641769442 ## CI report: * fcbf13064bc547149c674d4b1c0ceaa265176221 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu closed pull request #23005: Test for path

WencongLiu closed pull request #23005: Test for path URL: https://github.com/apache/flink/pull/23005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

  1   2   >