mxm commented on code in PR #633:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1268149481
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java:
##########
@@ -17,15 +17,19 @@
package org.apache.flink.kubernetes.operator.reconciler.deployment;
-import org.apache.flink.kubernetes.operator.api.AbstractFlinkResource;
import org.apache.flink.kubernetes.operator.controller.FlinkResourceContext;
+import java.util.Map;
+
/** Per-job Autoscaler instance. */
public interface JobAutoScaler {
/** Called as part of the reconciliation loop. Returns true if this call
led to scaling. */
- boolean scale(FlinkResourceContext<? extends AbstractFlinkResource<?, ?>>
ctx);
+ boolean scale(FlinkResourceContext<?> ctx);
/** Called when the custom resource is deleted. */
- void cleanup(AbstractFlinkResource<?, ?> cr);
+ void cleanup(FlinkResourceContext<?> ctx);
+
+ /** Get the current parallelism overrides for the job. */
Review Comment:
I think I prefer this being part of the autoscaling code but we can refactor
at a later point in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
