reswqa commented on code in PR #55:
URL: 
https://github.com/apache/flink-connector-pulsar/pull/55#discussion_r1268492288


##########
flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerUtils.java:
##########
@@ -35,9 +35,11 @@ public class FlinkContainerUtils {
     public static Configuration flinkConfiguration() {
         Configuration configuration = new Configuration();
 
-        // Increase the jvm metaspace memory to avoid 
java.lang.OutOfMemoryError: Metaspace
-        configuration.set(TaskManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2048));
+        configuration.set(TaskManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2560));
+        configuration.set(TaskManagerOptions.TASK_OFF_HEAP_MEMORY, 
MemorySize.ofMebiBytes(512));
         configuration.set(TaskManagerOptions.JVM_METASPACE, 
MemorySize.ofMebiBytes(512));
+
+        // Increase the jvm metaspace memory to avoid 
java.lang.OutOfMemoryError: Metaspace
         configuration.set(JobManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2560));
         configuration.set(JobManagerOptions.JVM_METASPACE, 
MemorySize.ofMebiBytes(1024));

Review Comment:
   Is this more appropriate(perhaps)? But it doesn't matter if we don't make 
any change. 😆 



##########
flink-connector-pulsar-e2e-tests/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerUtils.java:
##########
@@ -35,9 +35,11 @@ public class FlinkContainerUtils {
     public static Configuration flinkConfiguration() {
         Configuration configuration = new Configuration();
 
-        // Increase the jvm metaspace memory to avoid 
java.lang.OutOfMemoryError: Metaspace
-        configuration.set(TaskManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2048));
+        configuration.set(TaskManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2560));
+        configuration.set(TaskManagerOptions.TASK_OFF_HEAP_MEMORY, 
MemorySize.ofMebiBytes(512));
         configuration.set(TaskManagerOptions.JVM_METASPACE, 
MemorySize.ofMebiBytes(512));
+
+        // Increase the jvm metaspace memory to avoid 
java.lang.OutOfMemoryError: Metaspace
         configuration.set(JobManagerOptions.TOTAL_PROCESS_MEMORY, 
MemorySize.ofMebiBytes(2560));
         configuration.set(JobManagerOptions.JVM_METASPACE, 
MemorySize.ofMebiBytes(1024));

Review Comment:
   Is this more appropriate(perhaps)? But it doesn't matter if we don't make 
any change. 😆 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to