m-kay opened a new pull request, #23032: URL: https://github.com/apache/flink/pull/23032
## Purpose of the change *This pull request changes protobuf format to always use the classloader which is passed on creation for the `DynamicTableFactory.Context` instead of using the thread local classloader* as proposed in [FLINK-32418](https://issues.apache.org/jira/browse/FLINK-32418) ## Change log - The classloader passed in `DynamicTableFactory.Context` is stored in a `PbFormatContext`which is then passed further down the components - `PbFormatUtils.getDescriptor` has an additional parameter where the classloader from the PbFormatContaxt has to be passed to resolve generated Protobuf classes correctly. ## Verifying this change This change is already covered by existing tests, such as `SimpleProtoToRowTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: yes - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
