[GitHub] [flink] RanJinh commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

[via GitHub]

RanJinh commented on code in PR #23000:
URL: https://github.com/apache/flink/pull/23000#discussion_r1267868354


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -184,6 +184,9 @@ public static JobGraph createJobGraph(
 
     private final Map<Integer, InputOutputFormatContainer> 
chainedInputOutputFormats;
 
+    // The node id would be in this Set if it is an upstream node of an 
outputEOF node.

Review Comment:
   Thanks for your detailed comments! I will check all of the code comments 
according to your suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org