[jira] [Commented] (FLINK-5931) Make Flink highly available even if defaultFS is unavailable

2019-03-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791378#comment-16791378 ] vinoyang commented on FLINK-5931: - [~wheat9] Are you still working on this issue? What's

[jira] [Commented] (FLINK-11895) Allow FileSystem Configs to be altered at Runtime

2019-03-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791377#comment-16791377 ] vinoyang commented on FLINK-11895: -- [~lukaj] I think it is duplicated by FLINK-5931. >

[GitHub] [flink] JingsongLi commented on a change in pull request #7961: [FLINK-11882][table-runtime-blink] Introduce BytesHashMap to batch hash agg

2019-03-12 Thread GitBox
JingsongLi commented on a change in pull request #7961: [FLINK-11882][table-runtime-blink] Introduce BytesHashMap to batch hash agg URL: https://github.com/apache/flink/pull/7961#discussion_r264992207 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flin

[jira] [Updated] (FLINK-11896) Introduce stream physical nodes

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11896: --- Labels: pull-request-available (was: ) > Introduce stream physical nodes >

[GitHub] [flink] flinkbot commented on issue #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes

2019-03-12 Thread GitBox
flinkbot commented on issue #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes URL: https://github.com/apache/flink/pull/7969#issuecomment-472291067 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] godfreyhe opened a new pull request #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes

2019-03-12 Thread GitBox
godfreyhe opened a new pull request #7969: [FLINK-11896] [table-planner-blink] Introduce stream physical nodes URL: https://github.com/apache/flink/pull/7969 ## What is the purpose of the change *Introduce stream physical RelNode* ## Brief change log - *adds all strea

[jira] [Created] (FLINK-11896) Introduce stream physical nodes

2019-03-12 Thread godfrey he (JIRA)
godfrey he created FLINK-11896: -- Summary: Introduce stream physical nodes Key: FLINK-11896 URL: https://issues.apache.org/jira/browse/FLINK-11896 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-11896) Introduce stream physical nodes

2019-03-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11896: --- Description: This issues aims to introduce flink stream physical RelNode, such as ``StreamExecCalc``

[GitHub] [flink] KurtYoung commented on a change in pull request #7961: [FLINK-11882][table-runtime-blink] Introduce BytesHashMap to batch hash agg

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7961: [FLINK-11882][table-runtime-blink] Introduce BytesHashMap to batch hash agg URL: https://github.com/apache/flink/pull/7961#discussion_r264982223 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink

[jira] [Updated] (FLINK-11896) Introduce stream physical nodes

2019-03-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11896: --- Description: This issues aims to introduce flink stream physical RelNode, such as {{StreamExecCalc}}

[jira] [Updated] (FLINK-11896) Introduce stream physical nodes

2019-03-12 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-11896: --- Description: This issues aims to introduce flink stream physical RelNode, such as {{StreamExecCalc}}

[jira] [Commented] (FLINK-11888) Refine document of how to run end-to-end tests

2019-03-12 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791288#comment-16791288 ] Yu Li commented on FLINK-11888: --- [~sunjincheng121] has located the root cause of the port

[GitHub] [flink] KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264971905 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264971696 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264971399 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264971007 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table

2019-03-12 Thread GitBox
KurtYoung commented on a change in pull request #7958: [FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink table URL: https://github.com/apache/flink/pull/7958#discussion_r264970786 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/a

[GitHub] [flink] link3280 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-12 Thread GitBox
link3280 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#discussion_r264971776 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java ###

[jira] [Commented] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791286#comment-16791286 ] sunjincheng commented on FLINK-11892: - Hi Thanks for your nice check [~carp84] ! Of

[jira] [Assigned] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-11892: --- Assignee: Yu Li > Port conflict problem when do the end-to-end nightly-tests. > ---

[jira] [Commented] (FLINK-11894) AbstractRowSerializer.serializeToPages return type should be void

2019-03-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791273#comment-16791273 ] Kurt Young commented on FLINK-11894: maybe we should move this issue under  [FLINK-1

[jira] [Created] (FLINK-11895) Allow FileSystem Configs to be altered at Runtime

2019-03-12 Thread Luka Jurukovski (JIRA)
Luka Jurukovski created FLINK-11895: --- Summary: Allow FileSystem Configs to be altered at Runtime Key: FLINK-11895 URL: https://issues.apache.org/jira/browse/FLINK-11895 Project: Flink Issue

[jira] [Created] (FLINK-11894) AbstractRowSerializer.serializeToPages return type should be void

2019-03-12 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-11894: Summary: AbstractRowSerializer.serializeToPages return type should be void Key: FLINK-11894 URL: https://issues.apache.org/jira/browse/FLINK-11894 Project: Flink

[jira] [Commented] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791268#comment-16791268 ] Yu Li commented on FLINK-11892: --- +1, nice analysis on the root cause! I encountered the s

[jira] [Assigned] (FLINK-11893) Update ecosystem page and add it to the navigation bar

2019-03-12 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned FLINK-11893: Assignee: Jiangjie Qin > Update ecosystem page and add it to the navigation bar > ---

[jira] [Updated] (FLINK-11893) Update ecosystem page and add it to the navigation bar

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11893: --- Labels: pull-request-available (was: ) > Update ecosystem page and add it to the navigation

[jira] [Created] (FLINK-11893) Update ecosystem page and add it to the navigation bar

2019-03-12 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created FLINK-11893: Summary: Update ecosystem page and add it to the navigation bar Key: FLINK-11893 URL: https://issues.apache.org/jira/browse/FLINK-11893 Project: Flink Issue

[jira] [Updated] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-11892: Description: When I do the end-to-end check according to `[https://github.com/apache/flink/tree/m

[jira] [Commented] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791183#comment-16791183 ] sunjincheng commented on FLINK-11892: - Just now I try to use `flink-end-to-end-tests

[jira] [Commented] (FLINK-6131) Add side inputs for DataStream API

2019-03-12 Thread Ashish Pokharel (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791175#comment-16791175 ] Ashish Pokharel commented on FLINK-6131: All, looping back again on this. This fe

[GitHub] [flink] klion26 commented on issue #7965: make JDBCOutputFormat ClassCastException more helpful

2019-03-12 Thread GitBox
klion26 commented on issue #7965: make JDBCOutputFormat ClassCastException more helpful URL: https://github.com/apache/flink/pull/7965#issuecomment-472238898 @FaxianZhao could you please edit the title of this PR to match our guidelines (included in the PR template) --

[jira] [Created] (FLINK-11892) Port conflict problem when do the end-to-end nightly-tests.

2019-03-12 Thread sunjincheng (JIRA)
sunjincheng created FLINK-11892: --- Summary: Port conflict problem when do the end-to-end nightly-tests. Key: FLINK-11892 URL: https://issues.apache.org/jira/browse/FLINK-11892 Project: Flink Is

[jira] [Created] (FLINK-11891) Fix some script or test case bug in 1.8 RC

2019-03-12 Thread sunjincheng (JIRA)
sunjincheng created FLINK-11891: --- Summary: Fix some script or test case bug in 1.8 RC Key: FLINK-11891 URL: https://issues.apache.org/jira/browse/FLINK-11891 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-11449) Uncouple the Expression class from RexNodes

2019-03-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-11449. Resolution: Fixed Fix Version/s: 1.9.0 Fixed in 1.9.0: Introduce a new expression stack an

[GitHub] [flink] asfgit closed pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-12 Thread GitBox
asfgit closed pull request #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink] asfgit merged pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
asfgit merged pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [flink] twalthr commented on issue #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
twalthr commented on issue #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#issuecomment-472180884 Thank you @dawidwys for the review and @sunjincheng121 for the preparatory work. Merging this now. -

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264828377 ## File path: flink-connectors/flink-connector-gcp-pubsub/src/mai

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264827593 ## File path: flink-connectors/flink-connector-gcp-pubsub/src/mai

[GitHub] [flink] Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
Xeli commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264810803 ## File path: flink-connectors/flink-connector-gcp-pubsub/src/mai

[jira] [Updated] (FLINK-11692) Add Proxy for DataDog Metric Reporter

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11692: --- Labels: pull-request-available (was: ) > Add Proxy for DataDog Metric Reporter > --

[GitHub] [flink] flinkbot commented on issue #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter

2019-03-12 Thread GitBox
flinkbot commented on issue #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter URL: https://github.com/apache/flink/pull/7968#issuecomment-472096718 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[GitHub] [flink] scott-mitchell opened a new pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter

2019-03-12 Thread GitBox
scott-mitchell opened a new pull request #7968: [FLINK-11692] [Datadog Reporter] added proxy to datadog reporter URL: https://github.com/apache/flink/pull/7968 ## What is the purpose of the change This pull request adds a configurable proxy to the Datadog metric reporter.

[jira] [Commented] (FLINK-11865) Code generation in TraversableSerializer is prohibitively slow

2019-03-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790700#comment-16790700 ] Aljoscha Krettek commented on FLINK-11865: -- Fixed on release-1.8 in ce7aea06785

[GitHub] [flink] aljoscha commented on issue #7957: [FLINK-11865] Improve code generation speed in TraversableSerializer

2019-03-12 Thread GitBox
aljoscha commented on issue #7957: [FLINK-11865] Improve code generation speed in TraversableSerializer URL: https://github.com/apache/flink/pull/7957#issuecomment-472069699 Merged This is an automated message from the Apache

[jira] [Closed] (FLINK-11865) Code generation in TraversableSerializer is prohibitively slow

2019-03-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-11865. Resolution: Fixed > Code generation in TraversableSerializer is prohibitively slow > -

[GitHub] [flink] aljoscha closed pull request #7957: [FLINK-11865] Improve code generation speed in TraversableSerializer

2019-03-12 Thread GitBox
aljoscha closed pull request #7957: [FLINK-11865] Improve code generation speed in TraversableSerializer URL: https://github.com/apache/flink/pull/7957 This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-11539) Add TypeSerializerSnapshot for TraversableSerializer

2019-03-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790701#comment-16790701 ] Aljoscha Krettek commented on FLINK-11539: -- [~jkreileder] The fix for this (FLI

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264723067 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264711540 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264742116 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/validate/F

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264742946 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expression

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264703419 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264751565 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expression

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264703739 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[GitHub] [flink] dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
dawidwys commented on a change in pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#discussion_r264710350 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/scala/

[jira] [Created] (FLINK-11890) Replace Table API string-based expressions by a Java DSL

2019-03-12 Thread Timo Walther (JIRA)
Timo Walther created FLINK-11890: Summary: Replace Table API string-based expressions by a Java DSL Key: FLINK-11890 URL: https://issues.apache.org/jira/browse/FLINK-11890 Project: Flink Issu

[GitHub] [flink] zhijiangW commented on issue #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance

2019-03-12 Thread GitBox
zhijiangW commented on issue #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance URL: https://github.com/apache/flink/pull/7963#issuecomment-472059561 @pnowojski , I have updated the codes for only fixing `StreamTask` class compared with first ver

[jira] [Closed] (FLINK-2316) Optimize the SCA for bytecode generated by Scala

2019-03-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-2316. --- Resolution: Won't Fix The static code analysis was never really used. This issue is not relevant any

[jira] [Commented] (FLINK-11068) Convert the API classes *Table, *Window to interfaces

2019-03-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790614#comment-16790614 ] Timo Walther commented on FLINK-11068: -- Hi [~hequn8128], sorry for not answering ea

[jira] [Commented] (FLINK-11865) Code generation in TraversableSerializer is prohibitively slow

2019-03-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790604#comment-16790604 ] Aljoscha Krettek commented on FLINK-11865: -- Fixed on master in f0cdd9d2ae09061c

[GitHub] [flink] zhijiangW commented on issue #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance

2019-03-12 Thread GitBox
zhijiangW commented on issue #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance URL: https://github.com/apache/flink/pull/7963#issuecomment-472020549 Thanks for the review @pnowojski . I forgot fixing one point resulting in travis failure.

[GitHub] [flink] flinkbot commented on issue #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
flinkbot commented on issue #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967#issuecomment-472017793 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review you

[GitHub] [flink] twalthr opened a new pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes

2019-03-12 Thread GitBox
twalthr opened a new pull request #7967: [FLINK-11449][table] Uncouple the Expression class from RexNodes URL: https://github.com/apache/flink/pull/7967 ## What is the purpose of the change This PR aims to improves the contribution of #7664. It further minimizes the amount of change

[jira] [Updated] (FLINK-11887) Operator's Latency Metrics continues to increase

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11887: --- Labels: pull-request-available (was: ) > Operator's Latency Metrics continues to increase >

[GitHub] [flink] zhijiangW commented on issue #7730: [FLINK-11646][test] Remove legacy MockRecordWriter

2019-03-12 Thread GitBox
zhijiangW commented on issue #7730: [FLINK-11646][test] Remove legacy MockRecordWriter URL: https://github.com/apache/flink/pull/7730#issuecomment-472012093 Thanks for review and merging @pnowojski . I would add that in the commit next time. :) --

[jira] [Commented] (FLINK-11888) Refine document of how to run end-to-end tests

2019-03-12 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790567#comment-16790567 ] Yu Li commented on FLINK-11888: --- [~Zentol] Please let me know if you have any comments her

[GitHub] [flink] flinkbot commented on issue #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart

2019-03-12 Thread GitBox
flinkbot commented on issue #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart URL: https://github.com/apache/flink/pull/7966#issuecomment-472009888 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull r

[GitHub] [flink] SuXingLee opened a new pull request #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart

2019-03-12 Thread GitBox
SuXingLee opened a new pull request #7966: [FLINK-11887][metrics] Fixed latency metrics drift apart URL: https://github.com/apache/flink/pull/7966 ## What is the purpose of the change Use ```System.currentTimeMillis``` to replace ```System.nanoTime``` in ```LatencyMarker```, in o

[jira] [Updated] (FLINK-11889) Remove "stop" signal along with Stoppable interfaces

2019-03-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11889: - Description: During the [ML discussion|https://lists.apache.org/thread.html/b8d2f3209e7

[jira] [Created] (FLINK-11889) Remove "stop" signal along with Stoppable interfaces

2019-03-12 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-11889: Summary: Remove "stop" signal along with Stoppable interfaces Key: FLINK-11889 URL: https://issues.apache.org/jira/browse/FLINK-11889 Project: Flink

[jira] [Created] (FLINK-11888) Refine document of how to run end-to-end tests

2019-03-12 Thread Yu Li (JIRA)
Yu Li created FLINK-11888: - Summary: Refine document of how to run end-to-end tests Key: FLINK-11888 URL: https://issues.apache.org/jira/browse/FLINK-11888 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-11887) Operator's Latency Metrics continues to increase

2019-03-12 Thread Suxing Lee (JIRA)
Suxing Lee created FLINK-11887: -- Summary: Operator's Latency Metrics continues to increase Key: FLINK-11887 URL: https://issues.apache.org/jira/browse/FLINK-11887 Project: Flink Issue Type: Bug

[GitHub] [flink] tweise commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test

2019-03-12 Thread GitBox
tweise commented on issue #7896: [FLINK-9007] [kinesis] [e2e] Add Kinesis end-to-end test URL: https://github.com/apache/flink/pull/7896#issuecomment-471992102 @StefanRRichter could you approve the PR or let me know if anything else should be done here? ---

[GitHub] [flink] leesf commented on issue #7940: [hotfix][docs] fix error in functions example

2019-03-12 Thread GitBox
leesf commented on issue #7940: [hotfix][docs] fix error in functions example URL: https://github.com/apache/flink/pull/7940#issuecomment-471980702 cc @twalthr @zentol This is an automated message from the Apache Git Service

[GitHub] [flink] GJL commented on issue #7922: [FLINK-10756][runtime][tests] Wait for TM processes to shutdown

2019-03-12 Thread GitBox
GJL commented on issue #7922: [FLINK-10756][runtime][tests] Wait for TM processes to shutdown URL: https://github.com/apache/flink/pull/7922#issuecomment-471974410 @flinkbot approve all This is an automated message from the A

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264635101 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] GJL commented on issue #7922: [FLINK-10756][runtime][tests] Wait for TM processes to shutdown

2019-03-12 Thread GitBox
GJL commented on issue #7922: [FLINK-10756][runtime][tests] Wait for TM processes to shutdown URL: https://github.com/apache/flink/pull/7922#issuecomment-471968212 @flinkbot approve description This is an automated message fr

[GitHub] [flink] flinkbot commented on issue #7965: make JDBCOutputFormat ClassCastException more helpful

2019-03-12 Thread GitBox
flinkbot commented on issue #7965: make JDBCOutputFormat ClassCastException more helpful URL: https://github.com/apache/flink/pull/7965#issuecomment-471968284 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull requ

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264638629 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] FaxianZhao opened a new pull request #7965: make JDBCOutputFormat ClassCastException more helpful

2019-03-12 Thread GitBox
FaxianZhao opened a new pull request #7965: make JDBCOutputFormat ClassCastException more helpful URL: https://github.com/apache/flink/pull/7965 ## What is the purpose of the change This PR makes JDBCOutputFormat's ClassCastException more readable. Current exception make me confused whi

[GitHub] [flink] pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-12 Thread GitBox
pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#discussion_r264636431 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partiti

[GitHub] [flink] pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition

2019-03-12 Thread GitBox
pnowojski commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition URL: https://github.com/apache/flink/pull/7911#discussion_r264637060 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partiti

[GitHub] [flink] pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-12 Thread GitBox
pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#discussion_r264634735 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime

[jira] [Closed] (FLINK-11646) Remove legacy MockRecordWriter

2019-03-12 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-11646. -- Resolution: Fixed Fix Version/s: 1.9.0 merged commit 6f66e23 into apache:master > Remo

[GitHub] [flink] pnowojski merged pull request #7730: [FLINK-11646][test] Remove legacy MockRecordWriter

2019-03-12 Thread GitBox
pnowojski merged pull request #7730: [FLINK-11646][test] Remove legacy MockRecordWriter URL: https://github.com/apache/flink/pull/7730 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [flink] pnowojski commented on a change in pull request #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance

2019-03-12 Thread GitBox
pnowojski commented on a change in pull request #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance URL: https://github.com/apache/flink/pull/7963#discussion_r264631813 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264624917 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264622246 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#issuecomment-471952495 > Hello @rmetzger > > Let me address them point by point: > > > I rea

[GitHub] [flink] becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-03-12 Thread GitBox
becketqin commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r264614405 ## File path: flink-connectors/flink-connector-gcp-pubsub/sr

[GitHub] [flink] flinkbot commented on issue #7964: [FLINK-11886] [doc] update the output of start/stop_cluster.sh in job…

2019-03-12 Thread GitBox
flinkbot commented on issue #7964: [FLINK-11886] [doc] update the output of start/stop_cluster.sh in job… URL: https://github.com/apache/flink/pull/7964#issuecomment-471946845 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-11886) update the output of cluster management script in jobmanager_high_availability doc

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11886: --- Labels: pull-request-available (was: ) > update the output of cluster management script in

[GitHub] [flink] chummyhe89 opened a new pull request #7964: [FLINK-11886] [doc] update the output of start/stop_cluster.sh in job…

2019-03-12 Thread GitBox
chummyhe89 opened a new pull request #7964: [FLINK-11886] [doc] update the output of start/stop_cluster.sh in job… URL: https://github.com/apache/flink/pull/7964 ## What is the purpose of the change Update the output of the cluster management script in jobmanager_hig

[jira] [Closed] (FLINK-11856) Introduce BinaryHashTable to batch table runtime

2019-03-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-11856. -- Resolution: Implemented Fix Version/s: 1.9.0 fixed in 5968206f843a58e10e3db58cde3407bb3608d085

[jira] [Updated] (FLINK-11885) Introduce RecordWriterBuilder for creating RecordWriter instance

2019-03-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11885: --- Labels: pull-request-available (was: ) > Introduce RecordWriterBuilder for creating RecordW

[GitHub] [flink] KurtYoung merged pull request #7949: [FLINK-11856][table-runtime-blink] Introduce BinaryHashTable to batch table runtime

2019-03-12 Thread GitBox
KurtYoung merged pull request #7949: [FLINK-11856][table-runtime-blink] Introduce BinaryHashTable to batch table runtime URL: https://github.com/apache/flink/pull/7949 This is an automated message from the Apache Git Service

[jira] [Updated] (FLINK-11886) update the output of cluster management script in jobmanager_high_availability doc

2019-03-12 Thread chunpinghe (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chunpinghe updated FLINK-11886: --- Attachment: ha_doc_updated.png > update the output of cluster management script in > jobmanager_hig

[jira] [Updated] (FLINK-11886) update the output of cluster management script in jobmanager_high_availability doc

2019-03-12 Thread chunpinghe (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chunpinghe updated FLINK-11886: --- Attachment: ha_doc.png > update the output of cluster management script in > jobmanager_high_availa

[jira] [Updated] (FLINK-11886) update the output of cluster management script in jobmanager_high_availability doc

2019-03-12 Thread chunpinghe (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chunpinghe updated FLINK-11886: --- Attachment: (was: jira_cluster.sh.png) > update the output of cluster management script in > jo

  1   2   >