KurtYoung commented on a change in pull request #7958:
[FLINK-11881][table-planner-blink] Introduce code generated typed sort to blink
table
URL: https://github.com/apache/flink/pull/7958#discussion_r264971399
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/TypeGetterSetters.java
##########
@@ -36,6 +38,10 @@
*/
public interface TypeGetterSetters {
+ int MAX_FIX_PART_DATA_SIZE = 7;
+ long HIGHEST_FIRST_BIT = Long.MIN_VALUE;
+ long HIGHEST_SECOND_TO_EIGHTH_BIT = 0x7FL << 56;
Review comment:
I don't quite get the meaning of these variables, can you add some comments
for it? What does it for, and what does it looks like (like in a form of
10000000 00000000 .....)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
