pnowojski commented on a change in pull request #7963: [FLINK-11885][network] Introduce RecordWriterBuilder for creating RecordWriter instance URL: https://github.com/apache/flink/pull/7963#discussion_r264631813
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterBuilder.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.api.writer; + +/** + * Utility class to encapsulate the logic of building a {@link RecordWriter} instance. + */ +public class RecordWriterBuilder { Review comment: With "builder" I meant builder pattern. There is a little value of extracting static methods to separate class on it's own. The point is to avoid having multiple overloaded constructors/methods that allow more flexibility when creating class instances with default parameter values. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
