[ https://issues.apache.org/jira/browse/FLINK-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aljoscha Krettek updated FLINK-11889: ------------------------------------- Description: During the [ML discussion|https://lists.apache.org/thread.html/b8d2f3209e7ca7467af6037383ade6c14c35276f7acb2bbbc9a50c0f@%3Cdev.flink.apache.org%3E] of [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212] we realised that it would be beneficial for this new feature to replace the existing "stop" functionality. The current "stop" functionality cannot be used because no real-world sources support the functionality. Therefore, I think it is save to remove because it should not break existing workflows. The issue proposes completely removing the old stop feature, introduced via FLINK-2111, as preparation for [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212]. We have to be careful when doing this because it touches quite a few things. Basically, we have to do a manual revert of this commit: https://github.com/apache/flink/commit/bdd4024e20fdfb0accb6121a68780ce3a0c218c0 was: During the discussion of [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212] we realised that it would be beneficial for this new feature to replace the existing "stop" functionality. The current "stop" functionality cannot be used because no real-world sources support the functionality. Therefore, I think it is save to remove because it should not break existing workflows. The issue proposes completely removing the old stop feature, introduced via FLINK-2111, as preparation for [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212]. We have to be careful when doing this because it touches quite a few things. Basically, we have to do a manual revert of this commit: https://github.com/apache/flink/commit/bdd4024e20fdfb0accb6121a68780ce3a0c218c0 > Remove "stop" signal along with Stoppable interfaces > ---------------------------------------------------- > > Key: FLINK-11889 > URL: https://issues.apache.org/jira/browse/FLINK-11889 > Project: Flink > Issue Type: Improvement > Components: API / DataStream > Reporter: Aljoscha Krettek > Priority: Major > Fix For: 1.9.0 > > > During the [ML > discussion|https://lists.apache.org/thread.html/b8d2f3209e7ca7467af6037383ade6c14c35276f7acb2bbbc9a50c0f@%3Cdev.flink.apache.org%3E] > of > [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212] > we realised that it would be beneficial for this new feature to replace the > existing "stop" functionality. The current "stop" functionality cannot be > used because no real-world sources support the functionality. Therefore, I > think it is save to remove because it should not break existing workflows. > The issue proposes completely removing the old stop feature, introduced via > FLINK-2111, as preparation for > [FLIP-34|https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103090212]. > We have to be careful when doing this because it touches quite a few things. > Basically, we have to do a manual revert of this commit: > https://github.com/apache/flink/commit/bdd4024e20fdfb0accb6121a68780ce3a0c218c0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)