dawidwys commented on a change in pull request #7967: [FLINK-11449][table]
Uncouple the Expression class from RexNodes
URL: https://github.com/apache/flink/pull/7967#discussion_r264742946
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/PlannerExpressionConverter.scala
##########
@@ -723,6 +721,16 @@ class PlannerExpressionConverter private extends
ExpressionVisitor[PlannerExpres
throw new TableException("Unrecognized expression: " + other)
}
}
+
+ private def getValue[T](literal: PlannerExpression): T = {
+ literal.asInstanceOf[Literal].value.asInstanceOf[T]
+ }
+
+ private def assert(condition: Boolean): Unit = {
+ if (!condition) {
+ throw new TableException("Assertion is violated.")
Review comment:
```suggestion
throw new ValidationException("Assertion is violated.")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
