[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218130#comment-16218130 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...

2017-10-24 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 @pnowojski , the updates are already finished. ---

[jira] [Commented] (FLINK-7637) FlinkKinesisProducer violates at-least-once guarantees

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218098#comment-16218098 ] ASF GitHub Bot commented on FLINK-7637: --- Github user tzulitai commented on the issue

[GitHub] flink issue #4871: [FLINK-7637] [kinesis] Fix at-least-once guarantee in Fli...

2017-10-24 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4871 Thanks. I made one last change: allow direct import of non-shaded guava in `FlinkKinesisProducerTest`. The reason for this is that the Kinesis API directly exposes Guava, so we can't us

[jira] [Commented] (FLINK-5967) Add RuntimeContext#getAggregatingState() and document AggregatingState

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218089#comment-16218089 ] ASF GitHub Bot commented on FLINK-5967: --- GitHub user bowenli86 opened a pull request

[GitHub] flink pull request #4899: [FLINK-5967][DataStream API][Doc] Add RuntimeConte...

2017-10-24 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4899 [FLINK-5967][DataStream API][Doc] Add RuntimeContext#getAggregatingState() and document AggregatingState ## What is the purpose of the change Add `RuntimeContext#getAggregatingState()` an

[jira] [Updated] (FLINK-5967) Add RuntimeContext#getAggregatingState() and document AggregatingState

2017-10-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-5967: Issue Type: New Feature (was: Improvement) > Add RuntimeContext#getAggregatingState() and document Aggregat

[jira] [Updated] (FLINK-5967) Add RuntimeContext#getAggregatingState() and document AggregatingState

2017-10-24 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-5967: Summary: Add RuntimeContext#getAggregatingState() and document AggregatingState (was: Document AggregatingS

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218001#comment-16218001 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-24 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r146741962 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -64,23 +75,36 @@ @Te

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217997#comment-16217997 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-24 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r146741125 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -322,22 +322,25 @@ private void writ

[jira] [Commented] (FLINK-7870) SlotPool should cancel the slot request to RM if not need any more.

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217986#comment-16217986 ] ASF GitHub Bot commented on FLINK-7870: --- Github user shuai-xu commented on the issue

[GitHub] flink issue #4887: [FLINK-7870] [runtime] Cancel slot allocation to RM when ...

2017-10-24 Thread shuai-xu
Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/4887 @tillrohrmann could you help to review this pr? Thank you. ---

[jira] [Updated] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2017-10-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6105: -- Description: When catching InterruptedException, we should throw InterruptedIOException instead of IOException.

[jira] [Commented] (FLINK-4808) Allow skipping failed checkpoints

2017-10-24 Thread Jing Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217699#comment-16217699 ] Jing Fan commented on FLINK-4808: - [~ram_krish][~StephanEwen][~till.rohrmann] Do we have a

[jira] [Updated] (FLINK-7679) Upgrade maven enforcer plugin to 3.0.0-M1

2017-10-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7679: -- Description: I got the following build error against Java 9: {code} [ERROR] Failed to execute goal org.apache.

[jira] [Updated] (FLINK-6359) Utilize Hierarchical Timing Wheels for performant timer

2017-10-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6359: -- Priority: Minor (was: Major) > Utilize Hierarchical Timing Wheels for performant timer > --

[jira] [Commented] (FLINK-6690) Rescaling broken

2017-10-24 Thread Thalita Vergilio (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217513#comment-16217513 ] Thalita Vergilio commented on FLINK-6690: - Do you know if any of the Docker images

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217426#comment-16217426 ] ASF GitHub Bot commented on FLINK-6584: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4199: [FLINK-6584] [table] Support multiple consecutive windows...

2017-10-24 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4199 I'll make a few last changes and will merge this PR. ---

[jira] [Closed] (FLINK-7755) Null values are not correctly handled by batch inner and outer joins

2017-10-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7755. Resolution: Fixed Fix Version/s: (was: 1.3.3) Fixed in 1.4.0 with 2a6381553e48e0145655c0a

[jira] [Closed] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5498. Resolution: Fixed Fix Version/s: 1.4.0 Fixed in 1.4.0 with 2a6381553e48e0145655c0aadd173813de

[jira] [Reopened] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reopened FLINK-5498: -- > Add support for left/right outer joins with non-equality predicates (and 1+ > equality predicates

[jira] [Closed] (FLINK-7821) Replace Table.limit() by Table.fetch() and Table.offset()

2017-10-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7821. Resolution: Implemented Fix Version/s: 1.4.0 Implemented for 1.4.0 with e1c7e490395c44913e816

[GitHub] flink pull request #3379: [FLINK-5498] [table] Add support for left/right ou...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3379 ---

[jira] [Commented] (FLINK-7821) Replace Table.limit() by Table.fetch() and Table.offset()

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217410#comment-16217410 ] ASF GitHub Bot commented on FLINK-7821: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4813: [FLINK-7821] [table] Deprecate Table.limit() and r...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4813 ---

[jira] [Commented] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217409#comment-16217409 ] ASF GitHub Bot commented on FLINK-5498: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-7755) Null values are not correctly handled by batch inner and outer joins

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217408#comment-16217408 ] ASF GitHub Bot commented on FLINK-7755: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4874: [hotfix] [docs] Update the description of time-win...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4874 ---

[GitHub] flink pull request #4858: [FLINK-7755] [table] Fix NULL handling in batch jo...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4858 ---

[jira] [Commented] (FLINK-7849) Remove guava shading from hcatalog connector

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217314#comment-16217314 ] ASF GitHub Bot commented on FLINK-7849: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4836: [FLINK-7849][hcatalog] Remove unnecessary gauva sh...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4836 ---

[GitHub] flink pull request #4854: [docs] Fix typo in monitoring REST API documentati...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4854 ---

[GitHub] flink pull request #4885: [hotfix][docs] Fix typos in documentation

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4885 ---

[jira] [Commented] (FLINK-7909) Unify cluster creation for test bases

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217291#comment-16217291 ] ASF GitHub Bot commented on FLINK-7909: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4896: [FLINK-7909] Unify Flink test bases

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4896 The diffs looks good, but what I cannot judge in a final manner is whether some tests now get not executed any more (accidentally). What would be good is to take the Travis output from th

[jira] [Commented] (FLINK-7706) Port JobAccumulatorsHandler to new REST endpoint

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217272#comment-16217272 ] ASF GitHub Bot commented on FLINK-7706: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #4898: [FLINK-7706] [flip6] Add JobAccumulatorsHandler fo...

2017-10-24 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4898 [FLINK-7706] [flip6] Add JobAccumulatorsHandler for new REST endpoint ## What is the purpose of the change *Port JobAccumulatorsHandler to REST endpoint* ## Brief change log

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217265#comment-16217265 ] ASF GitHub Bot commented on FLINK-7368: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-7669) Always load Flink classes through parent ClassLoader

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217268#comment-16217268 ] ASF GitHub Bot commented on FLINK-7669: --- Github user StephanEwen commented on the is

[GitHub] flink issue #4891: [FLINK-7669] Always load Flink classes via parent ClassLo...

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4891 Looks good to me, +1 When we start introducing even more config options for class loading, it makes sense to introduce a class to bundle those up (like resolve order, parent first patter

[GitHub] flink pull request #4840: [FLINK-7368][metrics] Make MetricStore ThreadSafe ...

2017-10-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4840#discussion_r146627036 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java --- @@ -260,50 +293,66 @@ public String getMetric

[jira] [Commented] (FLINK-7910) Generalize TestEnvironment/TestStreamEnvironment to be used with Flip-6 MiniCluster

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217261#comment-16217261 ] ASF GitHub Bot commented on FLINK-7910: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #4897: [FLINK-7910] [tests] Generalize Test(Stream)Enviro...

2017-10-24 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4897 [FLINK-7910] [tests] Generalize Test(Stream)Environment to use JobExecutor ## What is the purpose of the change This commit introduces the JobExecutor interface which abstracts the actu

[jira] [Created] (FLINK-7910) Generalize TestEnvironment/TestStreamEnvironment to be used with Flip-6 MiniCluster

2017-10-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7910: Summary: Generalize TestEnvironment/TestStreamEnvironment to be used with Flip-6 MiniCluster Key: FLINK-7910 URL: https://issues.apache.org/jira/browse/FLINK-7910 Pro

[jira] [Commented] (FLINK-7637) FlinkKinesisProducer violates at-least-once guarantees

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217199#comment-16217199 ] ASF GitHub Bot commented on FLINK-7637: --- Github user bowenli86 commented on the issu

[GitHub] flink issue #4871: [FLINK-7637] [kinesis] Fix at-least-once guarantee in Fli...

2017-10-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4871 LGTM :+1: ---

[jira] [Commented] (FLINK-7864) Support side-outputs in CoProcessFunction

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217185#comment-16217185 ] ASF GitHub Bot commented on FLINK-7864: --- Github user bowenli86 commented on the issu

[jira] [Commented] (FLINK-7864) Support side-outputs in CoProcessFunction

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217186#comment-16217186 ] ASF GitHub Bot commented on FLINK-7864: --- Github user bowenli86 closed the pull reque

[GitHub] flink issue #4881: [FLINK-7864] [DataStream API] Support side-outputs in CoP...

2017-10-24 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4881 Those are actually intentional to reorder the methods so they conform to the order in the interface. Well, it's fine to not merge those ---

[GitHub] flink pull request #4881: [FLINK-7864] [DataStream API] Support side-outputs...

2017-10-24 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4881 ---

[jira] [Commented] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217181#comment-16217181 ] ASF GitHub Bot commented on FLINK-7388: --- Github user bowenli86 closed the pull reque

[GitHub] flink pull request #4786: [FLINK-7388][DataStream API] ProcessFunction.onTim...

2017-10-24 Thread bowenli86
Github user bowenli86 closed the pull request at: https://github.com/apache/flink/pull/4786 ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217171#comment-16217171 ] ASF GitHub Bot commented on FLINK-7416: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217172#comment-16217172 ] ASF GitHub Bot commented on FLINK-7416: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r146614543 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -64,23 +75,36 @@ @Te

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-10-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r146614062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -322,22 +322,25 @@ private void writ

[jira] [Commented] (FLINK-6046) Add support for oversized messages during deployment

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217164#comment-16217164 ] ASF GitHub Bot commented on FLINK-6046: --- Github user asfgit closed the pull request

[GitHub] flink pull request #4412: [FLINK-6046][jobmanager] add support for oversized...

2017-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4412 ---

[jira] [Resolved] (FLINK-6046) Add support for oversized messages during deployment

2017-10-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-6046. -- Resolution: Done Fix Version/s: 1.4.0 Added via 7a9df74eaff94601abf1caf974eb88d347d34cfe

[jira] [Commented] (FLINK-7821) Replace Table.limit() by Table.fetch() and Table.offset()

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217124#comment-16217124 ] ASF GitHub Bot commented on FLINK-7821: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #4813: [FLINK-7821] [table] Deprecate Table.limit() and r...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4813#discussion_r146605323 --- Diff: docs/dev/table/tableApi.md --- @@ -985,19 +985,22 @@ Table result = in.orderBy("a.asc"); -Limit +

[GitHub] flink issue #4794: [build][minor] Add missing licenses

2017-10-24 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4794 @StephanEwen ping ---

[jira] [Commented] (FLINK-7758) Fix bug Kafka09Fetcher add offset metrics

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217089#comment-16217089 ] ASF GitHub Bot commented on FLINK-7758: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4769: [FLINK-7758][kafka][hotfix] Fix bug Kafka09Fetcher add ka...

2017-10-24 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4769 @zentol ping. I have updated this PR. ---

[jira] [Commented] (FLINK-7909) Unify cluster creation for test bases

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217087#comment-16217087 ] ASF GitHub Bot commented on FLINK-7909: --- GitHub user tillrohrmann opened a pull requ

[jira] [Commented] (FLINK-7368) MetricStore makes cpu spin at 100%

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217086#comment-16217086 ] ASF GitHub Bot commented on FLINK-7368: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #4896: [FLINK-7909] Unify Flink test bases

2017-10-24 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4896 [FLINK-7909] Unify Flink test bases ## What is the purpose of the change Introduce a MiniClusterResource which is used by the AbstractTestBase to start and shut down a FlinkMiniClu

[GitHub] flink pull request #4840: [FLINK-7368][metrics] Make MetricStore ThreadSafe ...

2017-10-24 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4840#discussion_r146594528 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java --- @@ -260,50 +293,66 @@ public String getMet

[jira] [Commented] (FLINK-4831) Implement a slf4j metric reporter

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217084#comment-16217084 ] ASF GitHub Bot commented on FLINK-4831: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4661: [FLINK-4831][metrics] Implement a slf4j metric reporter

2017-10-24 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4661 @zentol thanks a lot for your review. I have updated the PR according to your comments. ---

[jira] [Commented] (FLINK-7755) Null values are not correctly handled by batch inner and outer joins

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217073#comment-16217073 ] ASF GitHub Bot commented on FLINK-7755: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217074#comment-16217074 ] ASF GitHub Bot commented on FLINK-7882: --- Github user pnowojski commented on the issu

[jira] [Created] (FLINK-7909) Unify cluster creation for test bases

2017-10-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7909: Summary: Unify cluster creation for test bases Key: FLINK-7909 URL: https://issues.apache.org/jira/browse/FLINK-7909 Project: Flink Issue Type: Improvement

[GitHub] flink issue #4895: [FLINK-7882][build] Fixup FLINK-7810 by excluding remaini...

2017-10-24 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4895 Yes, lets wait for the tests to complete :) ---

[GitHub] flink pull request #4858: [FLINK-7755] [table] Fix NULL handling in batch jo...

2017-10-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4858#discussion_r146591835 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -486,11 +486,6 @@ case class Join(

[jira] [Comment Edited] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217059#comment-16217059 ] Piotr Nowojski edited comment on FLINK-7882 at 10/24/17 3:06 PM: ---

[jira] [Commented] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217071#comment-16217071 ] ASF GitHub Bot commented on FLINK-7882: --- Github user aljoscha commented on the issue

[GitHub] flink issue #4895: [FLINK-7882][build] Fixup FLINK-7810 by excluding remaini...

2017-10-24 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4895 The fix looks good (it's quite simple ... 😉). I'll merge once Travis is green. ---

[jira] [Commented] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217070#comment-16217070 ] Aljoscha Krettek commented on FLINK-7882: - Thanks a lot for figuring this out, [~p

[jira] [Closed] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-7388. --- Resolution: Fixed Release Note: The timestamp of elements emitted from ProcessFunction.o

[jira] [Commented] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217065#comment-16217065 ] ASF GitHub Bot commented on FLINK-7882: --- GitHub user pnowojski opened a pull request

[jira] [Commented] (FLINK-7388) ProcessFunction.onTimer() sets processing time as timestamp

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217064#comment-16217064 ] ASF GitHub Bot commented on FLINK-7388: --- Github user aljoscha commented on the issue

[GitHub] flink pull request #4895: [FLINK-7882][build] Fixup FLINK-7810 by excluding ...

2017-10-24 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4895 [FLINK-7882][build] Fixup FLINK-7810 by excluding remaining unused jaxb dependencies This excludes remaining jaxb dependency, that was conflicting version used by S3 hadoop client. ## Wh

[GitHub] flink issue #4786: [FLINK-7388][DataStream API] ProcessFunction.onTimer() se...

2017-10-24 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4786 Thanks a lot, @bowenli86. I just merged this. 👍 Could you please close the PR? ---

[jira] [Commented] (FLINK-7882) Writing to S3 from EMR fails with exception

2017-10-24 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217059#comment-16217059 ] Piotr Nowojski commented on FLINK-7882: --- https://stackoverflow.com/questions/2704683

[jira] [Commented] (FLINK-7849) Remove guava shading from hcatalog connector

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217051#comment-16217051 ] ASF GitHub Bot commented on FLINK-7849: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-7849) Remove guava shading from hcatalog connector

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217053#comment-16217053 ] ASF GitHub Bot commented on FLINK-7849: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-7574) flink-clients

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217046#comment-16217046 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4836: [FLINK-7849][hcatalog] Remove unnecessary gauva shading

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4836 +1 to merge this ---

[GitHub] flink issue #4836: [FLINK-7849][hcatalog] Remove unnecessary gauva shading

2017-10-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4836 Merging... ---

[jira] [Commented] (FLINK-5704) Deprecate FlinkKafkaConsumer constructors in favor of improvements to decoupling from Kafka offset committing

2017-10-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217045#comment-16217045 ] Aljoscha Krettek commented on FLINK-5704: - I downgraded to "critical", please obje

[jira] [Updated] (FLINK-5704) Deprecate FlinkKafkaConsumer constructors in favor of improvements to decoupling from Kafka offset committing

2017-10-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5704: Priority: Critical (was: Blocker) > Deprecate FlinkKafkaConsumer constructors in favor of i

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217042#comment-16217042 ] ASF GitHub Bot commented on FLINK-6584: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217041#comment-16217041 ] ASF GitHub Bot commented on FLINK-6584: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217043#comment-16217043 ] ASF GitHub Bot commented on FLINK-6584: --- Github user fhueske commented on a diff in

[GitHub] flink issue #4712: [FLINK-7574][build][WIP] POM Cleanup flink-clients

2017-10-24 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4712 @tillrohrmann , Please let me know if this is good :) ---

[jira] [Commented] (FLINK-6584) Support multiple consecutive windows in SQL

2017-10-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217039#comment-16217039 ] ASF GitHub Bot commented on FLINK-6584: --- Github user fhueske commented on a diff in

  1   2   3   >