[
https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217291#comment-16217291
]
ASF GitHub Bot commented on FLINK-7909:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4896
The diffs looks good, but what I cannot judge in a final manner is whether
some tests now get not executed any more (accidentally).
What would be good is to take the Travis output from the profiles that run
tests in `flink-runtime` and `flink-tests` and compare the number of executed
tests (maven prints that in the "test" and "verify" summary). If they are still
the same (or differ by a number explained through the refactoring), then +1 to
merge
> Unify cluster creation for test bases
> -------------------------------------
>
> Key: FLINK-7909
> URL: https://issues.apache.org/jira/browse/FLINK-7909
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> Flink contains different test bases, e.g. {{AbstractTestBase}},
> {{MultipleProgramsTestBase}}, {{JavaProgramTestBase}} and the
> {{StreamingMultipleProgramsTestBase}}. Some of them start resources
> ({{FlinkMiniCluster}}) automatically, while others expose a start method.
> Some test bases set the {{ExecutionEnvironment}} while others use the
> {{FlinkMiniCluster}} directly. In order to make things more maintainable I
> propose to unify these test bases a bit and introduce an {{ExternalResource}}
> which encapsulates the resource start up and shut down.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
