GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4896

    [FLINK-7909] Unify Flink test bases

    ## What is the purpose of the change
    
    Introduce a MiniClusterResource which is used by the AbstractTestBase to 
start
    and shut down a FlinkMiniCluster. Additionally, this resource registers the 
proper
    Stream- and ExecutionEnvironment which is now the only way for tests to 
start
    jobs. This change will thus allow to centrally control which FlinkCluster 
will
    be started for all test bases.
    
    The AbstractTestBase fully subsumes the functionality of the
    StreamingMultipleProgramsTestBase since it now is the most general test base
    for streaming and batch jobs. As a consequence, we can safely remove the
    StreamingMultipleProgramsTestBase and let all corresponding tests extend 
from
    AbstractTestBase.
    
    ## Brief change log
    
    - Introduce `MiniClusterResource` which starts a `FlinkMiniCluster` and 
registers a `TestEnvironment` and a `TestStreamEnvironment`
    - Add `MiniClusterResource` as a `ClassRule` to `AbstractTestBase`
    - Remove `StreamingMultipleProgramsTestBase`
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixAbstractTestBase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4896.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4896
    
----
commit f52a06a133d47ff99b65c68b858f54ad18415d65
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2017-10-23T15:15:07Z

    [hotfix] [tests] Remove AbstractTestBase from CsvOutputFormatITCase and 
TextOutputFormatITCase

commit ef9cb2be617535082b37fcd69140176b567e54ed
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2017-10-24T09:32:05Z

    [FLINK-7909] Unify Flink test bases
    
    Introduce a MiniClusterResource which is used by the AbstractTestBase to 
start
    and shut down a FlinkMiniCluster. Additionally, this resource registers the 
proper
    Stream- and ExecutionEnvironment which is now the only way for tests to 
start
    jobs. This change will thus allow to centrally control which FlinkCluster 
will
    be started for all test bases.

commit 105ef865b135bdc75f39ab483f979e6bf730e7fe
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2017-10-24T14:20:15Z

    [FLINK-7909] Replace StreamingMultipleProgramsTestBase by AbstractTestBase
    
    The AbstractTestBase fully subsumes the functionality of the
    StreamingMultipleProgramsTestBase since it now is the most general test base
    for streaming and batch jobs. As a consequence, we can safely remove the
    StreamingMultipleProgramsTestBase and let all corresponding tests extend 
from
    AbstractTestBase.

----


---

Reply via email to