[GitHub] flink pull request #4858: [FLINK-7755] [table] Fix NULL handling in batch jo...

[fhueske]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4858#discussion_r146591835
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
 ---
    @@ -486,11 +486,6 @@ case class Join(
             s"Invalid join condition: $expression. At least one equi-join 
predicate is " +
               s"required.")
         }
    -    if (joinType != JoinType.INNER && (nonEquiJoinPredicateFound || 
localPredicateFound)) {
    --- End diff --
    
    Good point. Will remove that. Thanks @lincoln-lil!


---