[
https://issues.apache.org/jira/browse/FLINK-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217261#comment-16217261
]
ASF GitHub Bot commented on FLINK-7910:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4897
[FLINK-7910] [tests] Generalize Test(Stream)Environment to use JobExecutor
## What is the purpose of the change
This commit introduces the JobExecutor interface which abstracts the actual
mini cluster
from the Test(Stream)Environment. By letting the Flip-6 MiniCluster as well
as the
FlinkMiniCluster implement this interface, we can run all test base jobs
either on the
Flip-6 mini cluster or on the current mini cluster.
## Brief change log
- Introduce `JobExecutor` interface
- Let `MiniCluster` and `FlinkMiniCluster` implement the `JobExecutor`
interface
- Let `TestEnvironment` and `TestStreamEnvironment` use the `JobExecutor`
to execute jobs
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink generalizeTestEnvironments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4897.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4897
----
commit e54b6fc04f841e005c0ac6210e4a52aa331e0db1
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-10-24T16:53:40Z
[FLINK-7910] [tests] Generalize Test(Stream)Environment to use JobExecutor
This commit introduces the JobExecutor interface which abstracts the actual
mini cluster
from the Test(Stream)Environment. By letting the Flip-6 MiniCluster as well
as the
FlinkMiniCluster implement this interface, we can run all test base jobs
either on the
Flip-6 mini cluster or on the current mini cluster.
----
> Generalize TestEnvironment/TestStreamEnvironment to be used with Flip-6
> MiniCluster
> -----------------------------------------------------------------------------------
>
> Key: FLINK-7910
> URL: https://issues.apache.org/jira/browse/FLINK-7910
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> In order to execute tests extending {{AbstractTestBase}} with the Flip-6
> {{MiniCluster}} we have to generalize {{TestEnvironment}} and the
> {{TestStreamEnvironment}} such that they can execute jobs on the Flip-6
> {{MiniCluster}}. In order to do that I propose to introduce a {{JobExecutor}}
> interface which can be implemented by the {{MiniCluster}} and the
> {{FlinkMiniCluster}} class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
