[jira] [Commented] (FLINK-3667) Generalize client<->cluster communication

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305118#comment-15305118 ] ASF GitHub Bot commented on FLINK-3667: --- Github user EronWright commented on the pul

[GitHub] flink pull request: [FLINK-3667] refactor client communication

2016-05-27 Thread EronWright
Github user EronWright commented on the pull request: https://github.com/apache/flink/pull/1978#issuecomment-85524 This PR dovetails nicely with the Mesos work and I'll be sure to build on it. Here's a few suggestions to align it even further. The problem of _managing_

[jira] [Created] (FLINK-3984) Event time of stream transformations is undocumented

2016-05-27 Thread Elias Levy (JIRA)
Elias Levy created FLINK-3984: - Summary: Event time of stream transformations is undocumented Key: FLINK-3984 URL: https://issues.apache.org/jira/browse/FLINK-3984 Project: Flink Issue Type: Impr

[jira] [Commented] (FLINK-3715) Move Accumulating/Discarding from Trigger to WindowOperator

2016-05-27 Thread Elias Levy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305082#comment-15305082 ] Elias Levy commented on FLINK-3715: --- As mentioned on the Google doc, this may not be fle

[jira] [Commented] (FLINK-3667) Generalize client<->cluster communication

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304946#comment-15304946 ] ASF GitHub Bot commented on FLINK-3667: --- Github user EronWright commented on a diff

[GitHub] flink pull request: [FLINK-3667] refactor client communication

2016-05-27 Thread EronWright
Github user EronWright commented on a diff in the pull request: https://github.com/apache/flink/pull/1978#discussion_r64975479 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -393,7 +373,7 @@ protected AbstractFlinkYarnCluster dep

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304799#comment-15304799 ] ASF GitHub Bot commented on FLINK-3923: --- Github user aozturk commented on the pull r

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread aozturk
Github user aozturk commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-55574 That was my concern actually, Let's wait for it then :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-55208 Okay, I've filed https://issues.apache.org/jira/browse/FLINK-3983. However, before you jump onto it: While I wrote the JIRA, I was actually wondering whether it makes s

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304798#comment-15304798 ] ASF GitHub Bot commented on FLINK-3923: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread aozturk
Github user aozturk commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-55079 Repeated lines were terrible, it looks neater now. But it seems the if checks for max count configurations in FlinkKinesisProducer.java are redundant now. Adding al

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304796#comment-15304796 ] ASF GitHub Bot commented on FLINK-3923: --- Github user aozturk commented on the pull r

[jira] [Created] (FLINK-3983) Allow users to set any (relevant) configuration parameter of the KinesisProducerConfiguration

2016-05-27 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3983: - Summary: Allow users to set any (relevant) configuration parameter of the KinesisProducerConfiguration Key: FLINK-3983 URL: https://issues.apache.org/jira/browse/FLINK-3983

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304765#comment-15304765 ] ASF GitHub Bot commented on FLINK-3923: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-52000 I have to admit that these changes were not necessary: https://github.com/apache/flink/commit/23d1cba72859339bd3ee8f877b031353380c87fb#diff-d34eb8418ccff3e2d59a3e660fed6

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread aozturk
Github user aozturk commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-50998 Thanks for the merge! Your latest enhancements look great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304755#comment-15304755 ] ASF GitHub Bot commented on FLINK-3923: --- Github user aozturk commented on the pull r

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304743#comment-15304743 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-48940 Okay, let me explain: I decided to remove the field, even though its public, and strictly speaking a breaking API change. However, it was a mistake to mark the

[jira] [Commented] (FLINK-3982) Multiple ResourceManagers register at JobManager in standalone HA mode

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304740#comment-15304740 ] ASF GitHub Bot commented on FLINK-3982: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request: [FLINK-3982] let only ResourceManager of leadi...

2016-05-27 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2046 [FLINK-3982] let only ResourceManager of leading JobManager register In HA mode, multiple ResourceManagers may register at the leading JobManager. They register one after another at the JobManager. T

[jira] [Commented] (FLINK-3981) Don't log duplicate TaskManager registrations as exceptions

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304733#comment-15304733 ] ASF GitHub Bot commented on FLINK-3981: --- GitHub user mxm opened a pull request:

[jira] [Comment Edited] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304731#comment-15304731 ] Robert Metzger edited comment on FLINK-3923 at 5/27/16 8:38 PM:

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304732#comment-15304732 ] ASF GitHub Bot commented on FLINK-3923: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3923. --- Resolution: Fixed Fix Version/s: 1.1.0 This has been resolved in http://git-wip-us.apa

[GitHub] flink pull request: [FLINK-3981] don't log duplicate TaskManager r...

2016-05-27 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2045 [FLINK-3981] don't log duplicate TaskManager registrations Duplicate TaskManager registrations shouldn't be logged with Exceptions in the ResourceManager. Duplicate registrations can happen if the

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2016 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Created] (FLINK-3982) Multiple ResourceManagers register at JobManager in standalone HA mode

2016-05-27 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3982: - Summary: Multiple ResourceManagers register at JobManager in standalone HA mode Key: FLINK-3982 URL: https://issues.apache.org/jira/browse/FLINK-3982 Projec

[jira] [Created] (FLINK-3981) Don't log duplicate TaskManager registrations as exceptions

2016-05-27 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-3981: - Summary: Don't log duplicate TaskManager registrations as exceptions Key: FLINK-3981 URL: https://issues.apache.org/jira/browse/FLINK-3981 Project: Flink

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304422#comment-15304422 ] ASF GitHub Bot commented on FLINK-3129: --- Github user zentol commented on the pull re

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-08597 no my concern wasn't even remotely addressed. The public static String CONFIG_KEY was removed in commit 5a7f4e3395bfb06da496584be88501c328f6ac1d, violating the interfa

[jira] [Commented] (FLINK-2915) JobManagerProcessFailureBatchRecoveryITCase

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304332#comment-15304332 ] ASF GitHub Bot commented on FLINK-2915: --- Github user rekhajoshm commented on the pul

[GitHub] flink pull request: [FLINK-2915] Fix for JobManagerProcessFailureB...

2016-05-27 Thread rekhajoshm
Github user rekhajoshm closed the pull request at: https://github.com/apache/flink/pull/2027 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-2915) JobManagerProcessFailureBatchRecoveryITCase

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304333#comment-15304333 ] ASF GitHub Bot commented on FLINK-2915: --- Github user rekhajoshm closed the pull requ

[GitHub] flink pull request: [FLINK-2915] Fix for JobManagerProcessFailureB...

2016-05-27 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/flink/pull/2027#issuecomment-222198043 Thanks @StephanEwen for review. Closing PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request: [FLINK-2771] Fix for IterateTest.testSimpleIte...

2016-05-27 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/flink/pull/2028#issuecomment-222197851 Yes, glad to @StephanEwen . Looking forward to your design for timeout-based termination to a proper "end-of-stream-event" based termination. thanks! --- If your pr

[jira] [Closed] (FLINK-3972) Subclasses of ResourceID may not to be serializable

2016-05-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-3972. - Resolution: Fixed Fixed via 4d41bd8fa787315d203bb34973f8608d84c5b6ac > Subclasses of Reso

[jira] [Commented] (FLINK-3972) Subclasses of ResourceID may not to be serializable

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304291#comment-15304291 ] ASF GitHub Bot commented on FLINK-3972: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-3972] subclasses of ResourceID may not ...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2037 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304243#comment-15304243 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-222185242 @zentol I think your concern was addressed here: https://github.com/apache/flink/pull/2042/commits/c20efc6cda6ff705c72924213c90f618f7f40e51 Thanks all for the r

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-3129. --- Resolution: Fixed Fix Version/s: 1.1.0 Resolved in current master in http://git-wip-us

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304238#comment-15304238 ] ASF GitHub Bot commented on FLINK-3129: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-05-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304234#comment-15304234 ] Greg Hogan commented on FLINK-3291: --- The {{inputStream}} field causing the {{IllegalArgu

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2016-05-27 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-222177257 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Closed] (FLINK-2971) Add outer joins to the Table API

2016-05-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-2971. Resolution: Implemented Fix Version/s: 1.1.0 Implemented with cbc5f8303ec0e0ebd5cf5c9927d108f

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1981 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3887) Improve dependency management for building docs

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304163#comment-15304163 ] ASF GitHub Bot commented on FLINK-3887: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-3887] improve dependency management for...

2016-05-27 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/2033#issuecomment-222171685 `-p` didn't work, talked to Max offline. After the fix +1 to merge. Very nice change! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-3836] Add LongHistogram accumulator

2016-05-27 Thread greghogan
Github user greghogan commented on the pull request: https://github.com/apache/flink/pull/1966#issuecomment-222161038 I was interested to see what happened here and a simple rebase and force push corrects the problem. Make sure local master is up-to-date $ git checkout mas

[jira] [Commented] (FLINK-3836) Change Histogram to enable Long counters

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304121#comment-15304121 ] ASF GitHub Bot commented on FLINK-3836: --- Github user greghogan commented on the pull

[jira] [Commented] (FLINK-3836) Change Histogram to enable Long counters

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304093#comment-15304093 ] ASF GitHub Bot commented on FLINK-3836: --- Github user mbode commented on the pull req

[jira] [Commented] (FLINK-3836) Change Histogram to enable Long counters

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304094#comment-15304094 ] ASF GitHub Bot commented on FLINK-3836: --- Github user mbode closed the pull request a

[GitHub] flink pull request: [FLINK-3836] Add LongHistogram accumulator

2016-05-27 Thread mbode
Github user mbode commented on the pull request: https://github.com/apache/flink/pull/1966#issuecomment-222155560 Sorry guys, botched the PR :/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink pull request: [FLINK-3836] Add LongHistogram accumulator

2016-05-27 Thread mbode
Github user mbode closed the pull request at: https://github.com/apache/flink/pull/1966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-3974) enableObjectReuse fails when an operator chains to multiple downstream operators

2016-05-27 Thread B Wyatt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304062#comment-15304062 ] B Wyatt commented on FLINK-3974: In the topologies I've been building object reuse has bee

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304052#comment-15304052 ] ASF GitHub Bot commented on FLINK-3129: --- Github user zentol commented on a diff in t

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2042#discussion_r64902741 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -82,6 +82,10 @@ private static final long DEFAULT_REST

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304029#comment-15304029 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-222139308 Thank you for the review. Its very low overhead since the 1.0.0 jar's are cached in the local .m2 directory and the tool is doing the check really fast. --- I

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304025#comment-15304025 ] ASF GitHub Bot commented on FLINK-3129: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-222138890 +1 Looks good to me. Only wondering, how much will it affect our build time? We might want to run this in a dedicated profile. --- If your project is set up for i

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread dawidwys
Github user dawidwys commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-222138623 Really sorry for those mistakes :( Thanks for fixing them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Commented] (FLINK-3923) Unify configuration conventions of the Kinesis producer to the same as the consumer

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304015#comment-15304015 ] ASF GitHub Bot commented on FLINK-3923: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2016#issuecomment-222136775 Thanks a lot for addressing the comments. I'll push the changes to travis, once its green I'll merge them. --- If your project is set up for it, you can reply to th

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303998#comment-15303998 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-222134657 The plugin runs with every mvn verify call. For each maven module, it will download the last stable release (in this case 1.0.0) and check it against the build

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-05-27 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303994#comment-15303994 ] Gabor Gevay commented on FLINK-3291: This bug occurred when object reuse is enabled. T

[jira] [Commented] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303992#comment-15303992 ] ASF GitHub Bot commented on FLINK-3944: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request: [FLINK-3944] [tableAPI] Add rewrite rules to r...

2016-05-27 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/2044 [FLINK-3944] [tableAPI] Add rewrite rules to reorder Cartesian products and joins. The Table API / SQL interface do not reorder joins due to missing stats and estimates. This can lead to s

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303991#comment-15303991 ] ASF GitHub Bot commented on FLINK-3129: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2042#issuecomment-222132940 Thanks for the pull request! Could you elaborate on how and where this will be integrated with our CI or release process? --- If your project is set up for it, you can repl

[jira] [Updated] (FLINK-3960) Disable, fix and re-enable EventTimeWindowCheckpointingITCase

2016-05-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-3960: -- Summary: Disable, fix and re-enable EventTimeWindowCheckpointingITCase (was: EventTimeW

[jira] [Reopened] (FLINK-3960) EventTimeWindowCheckpointingITCase fails with a segmentation fault

2016-05-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels reopened FLINK-3960: --- Keeping this for the record to revert 98a939552e12fc699ff39111bbe877e112460ceb. > EventTi

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1981#issuecomment-222131071 Thanks for the update @dawidwys. I found a few minor issues in the docs. Will fix them and merge this PR. --- If your project is set up for it, you can reply to this em

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895580 --- Diff: docs/apis/table.md --- @@ -542,6 +578,42 @@ val result = left.join(right).where('a === 'd).select('a, 'b, 'e); {% endhighlight %}

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895561 --- Diff: docs/apis/table.md --- @@ -542,6 +578,42 @@ val result = left.join(right).where('a === 'd).select('a, 'b, 'e); {% endhighlight %}

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895590 --- Diff: docs/apis/table.md --- @@ -542,6 +578,42 @@ val result = left.join(right).where('a === 'd).select('a, 'b, 'e); {% endhighlight %}

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895548 --- Diff: docs/apis/table.md --- @@ -542,6 +578,42 @@ val result = left.join(right).where('a === 'd).select('a, 'b, 'e); {% endhighlight %}

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895471 --- Diff: docs/apis/table.md --- @@ -423,14 +423,50 @@ Table result = in.groupBy("a").select("a, b.sum as d"); Join -

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895489 --- Diff: docs/apis/table.md --- @@ -423,14 +423,50 @@ Table result = in.groupBy("a").select("a, b.sum as d"); Join -

[GitHub] flink pull request: [Flink-2971][table] Add outer joins to the Tab...

2016-05-27 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1981#discussion_r64895504 --- Diff: docs/apis/table.md --- @@ -542,6 +578,42 @@ val result = left.join(right).where('a === 'd).select('a, 'b, 'e); {% endhighlight %}

[jira] [Commented] (FLINK-3886) Give a better error when the application Main class is not public.

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303970#comment-15303970 ] ASF GitHub Bot commented on FLINK-3886: --- GitHub user nielsbasjes opened a pull reque

[GitHub] flink pull request: [FLINK-3886] Give a better error when the appl...

2016-05-27 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/flink/pull/2043 [FLINK-3886] Give a better error when the application Main class is not public. A simple fix that reduces the time needed to find the cause of this simple developer error. You can merge this p

[jira] [Closed] (FLINK-3960) EventTimeWindowCheckpointingITCase fails with a segmentation fault

2016-05-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-3960. --- Resolution: Duplicate This is a duplicate of FLINK-3948. > EventTimeWindowCheckpointingITCase

[GitHub] flink pull request:

2016-05-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17644775 In flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java: In flink-runtime/src/main/java/org

[jira] [Assigned] (FLINK-3944) Add optimization rules to reorder Cartesian products and joins

2016-05-27 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-3944: Assignee: Fabian Hueske > Add optimization rules to reorder Cartesian products and joins >

[jira] [Updated] (FLINK-3948) EventTimeWindowCheckpointingITCase Fails with Core Dump

2016-05-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-3948: Affects Version/s: 1.1.0 > EventTimeWindowCheckpointingITCase Fails with Core Dump > ---

[GitHub] flink pull request:

2016-05-27 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17644300 In flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java: In flink-runtime/src/main/

[GitHub] flink pull request: [FLINK-3129] Add tooling to ensure interface s...

2016-05-27 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/2042 [FLINK-3129] Add tooling to ensure interface stability This pull request adds a maven module for ensuring interface stability (japicmp). I needed to revert some of the changes since 1.0:

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303904#comment-15303904 ] ASF GitHub Bot commented on FLINK-3129: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

2016-05-27 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1791#issuecomment-222113705 Closing this PR in favor of a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303895#comment-15303895 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger closed the pull reques

[jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303894#comment-15303894 ] ASF GitHub Bot commented on FLINK-3129: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-3129] Add japicmp-maven-plugin to ensur...

2016-05-27 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/1791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Commented] (FLINK-3972) Subclasses of ResourceID may not to be serializable

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303888#comment-15303888 ] ASF GitHub Bot commented on FLINK-3972: --- Github user mxm commented on the pull reque

[GitHub] flink pull request: [FLINK-3972] subclasses of ResourceID may not ...

2016-05-27 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2037#issuecomment-222113016 Rebased to the latest master. Will merge once the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-3291) Object reuse bug in MergeIterator.HeadStream.nextHead

2016-05-27 Thread Pawel Szczur (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303884#comment-15303884 ] Pawel Szczur commented on FLINK-3291: - I've browsed through a Flink issues to find any

[jira] [Commented] (FLINK-3317) Add timeout handler to CEP operator

2016-05-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303879#comment-15303879 ] ASF GitHub Bot commented on FLINK-3317: --- GitHub user tillrohrmann opened a pull requ

  1   2   >