[
https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304765#comment-15304765
]
ASF GitHub Bot commented on FLINK-3923:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-222252000
I have to admit that these changes were not necessary:
https://github.com/apache/flink/commit/23d1cba72859339bd3ee8f877b031353380c87fb#diff-d34eb8418ccff3e2d59a3e660fed6cec
I wanted to change it so that the code won't throw any exceptions if the
provided value is not correctly parseable. I didn't see that the verify method
in the constructor is already doing that.
I'll add a follow up JIRA for adding configuration keys for all relevant
fields in `KinesisProducerConfiguration`
> Unify configuration conventions of the Kinesis producer to the same as the
> consumer
> -----------------------------------------------------------------------------------
>
> Key: FLINK-3923
> URL: https://issues.apache.org/jira/browse/FLINK-3923
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Abdullah Ozturk
> Fix For: 1.1.0
>
>
> Currently, the Kinesis consumer and producer are configured differently.
> The producer expects a list of arguments for the access key, secret, region,
> stream. The consumer is accepting properties (similar to the Kafka connector).
> The objective of this issue is to change the producer so that it is also
> using a properties-based configuration (including an input validation step)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
