Github user aozturk commented on the pull request:

    https://github.com/apache/flink/pull/2016#issuecomment-222255079
  
    Repeated lines were terrible, it looks neater now. But it seems the if 
checks for max count configurations in FlinkKinesisProducer.java are redundant 
now. 
    Adding all configurations sounds good. I thought about it but was not sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to