[ 
https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304743#comment-15304743
 ] 

ASF GitHub Bot commented on FLINK-3129:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/2042#issuecomment-222248940
  
    Okay, let me explain:
    
    I decided to remove the field, even though its public, and strictly 
speaking a breaking API change. However, it was a mistake to mark the field as 
public (back then, when it was added). It was only used internally as a 
configuration key for storing the serialized execution config (so it was 
something only used by flink).
    It doesn't have any use for our users at all, so I think its absolutely 
safe to remove it. Its also not mentioned in the documentation.
    
    I've added this exclude to the API check to ignore the breaking change:
    
https://github.com/apache/flink/commit/b0acd97935cd21843bac3b9b5afa3662b52bb95d#diff-40616c4678c3fbfe07c0701505ce0567


> Add tooling to ensure interface stability
> -----------------------------------------
>
>                 Key: FLINK-3129
>                 URL: https://issues.apache.org/jira/browse/FLINK-3129
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>             Fix For: 1.1.0
>
>
> I would like to use this maven plugin: https://github.com/siom79/japicmp to 
> automatically ensure interface stability across minor releases.
> Ideally we have the plugin in place after Flink 1.0 is out, so that maven 
> builds break if a breaking change has been made.
> The plugin already supports downloading a reference release, checking the 
> build and breaking it.
> Not yet supported are class/method inclusions based on annotations, but I've 
> opened a pull request for adding it.
> There are also issues with the resolution of the dependency with the 
> annotations, but I'm working on resolving those issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to