[
https://issues.apache.org/jira/browse/FLINK-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304796#comment-15304796
]
ASF GitHub Bot commented on FLINK-3923:
---------------------------------------
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-222255079
Repeated lines were terrible, it looks neater now. But it seems the if
checks for max count configurations in FlinkKinesisProducer.java are redundant
now.
Adding all configurations sounds good. I thought about it but was not sure.
> Unify configuration conventions of the Kinesis producer to the same as the
> consumer
> -----------------------------------------------------------------------------------
>
> Key: FLINK-3923
> URL: https://issues.apache.org/jira/browse/FLINK-3923
> Project: Flink
> Issue Type: Sub-task
> Components: Kinesis Connector, Streaming Connectors
> Affects Versions: 1.1.0
> Reporter: Robert Metzger
> Assignee: Abdullah Ozturk
> Fix For: 1.1.0
>
>
> Currently, the Kinesis consumer and producer are configured differently.
> The producer expects a list of arguments for the access key, secret, region,
> stream. The consumer is accepting properties (similar to the Kafka connector).
> The objective of this issue is to change the producer so that it is also
> using a properties-based configuration (including an input validation step)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
