Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

On Wed, Sep 24, 2014 at 2:48 AM, Stas Malyshev wrote: > Hi! > >> I'll implement optional (and not default) support of IDN in filter_var(). >> >> Does anyone known if it's better to use libIDN (LGPL) or ICU (custom >> license deviated from the X license) from a license point of view? > > ICU is def

Re: [PHP-DEV] Invokation on __toString() for object used as array key

Hi! > Well, then let's remove this restriction from resources, too. Not sure what use would it be for resources - resource IDs are not controlled by user code and for all intents and purposes are opaque numbers, which also do not have to be unique over the life of the script. What use would it be

Re: [PHP-DEV] Improve PHP 7 serialization

On Sep 23, 2014 8:07 PM, "Leigh" wrote: > > On 23 September 2014 17:36, Park Framework wrote: > > > > If you do not update in PHP 7 serialization method, it will never be > > updated, the default serialization in PHP 7 will be slow. > > > > To maintain backward compatibility, can implement suppor

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 24/09/14 02:08, Stas Malyshev wrote: > Hi! > >> I do believe that the UString class would benefit from such a change. >> >> Why would it be confusing to implement this? > > For some objects, it may lead to rather strange results - i.e., > Exception has __toString() but probably not very useful

Re: [PHP-DEV] Improve PHP 7 serialization

Hi! > There is an even better way to do this; add an additional parameter to > serialize and unserialize to serialize as and unserialize as: > > $bin = serialize($data_struct, 'igbinary'); > $data_struct = unserialize($bin, 'igbinary'); This is cleaner, but if you can do this (code change), why

Re: [PHP-DEV] Improve PHP 7 serialization

Hi 2014-09-23 23:56 GMT+02:00 Park Framework : > In php.ini add the directive > serialization.method = msgpack / Igbinary / There is an even better way to do this; add an additional parameter to serialize and unserialize to serialize as and unserialize as: $bin = serialize($data_struct, 'ig

Re: [PHP-DEV] Internationalized Domain Name support in FILTER_VALIDATE_URL

Hi! > I'll implement optional (and not default) support of IDN in filter_var(). > > Does anyone known if it's better to use libIDN (LGPL) or ICU (custom > license deviated from the X license) from a license point of view? ICU is definitely better since we already have a lot of code using ICU and

Re: [PHP-DEV] Improve PHP 7 serialization

I agree, you're right. My desire to override the existing algorithm serialize(), due to the need to change the method serialization, but does not change the source code (legacy code, ext PHP) 2014-09-24 3:03 GMT+03:00 Stas Malyshev : > Hi! > >> Perhaps a compromise would be to choose the quickest

Re: [PHP-DEV] [VOTE][RFC] Scalar Type Hinting with Cast

Hi! > Most? > > Python has it, java too, ruby and perl not. We can continue to list > those having them or not, not sure that brings much to this discussion. Only Python 3 has it, and I'm not sure bringing up Python 3, given its known adoption issues, is the best example how we could plan PHP 7.

Re: [PHP-DEV] [RFC] ZPP Failure On Overflow

Hi! > Good evening again, > > Here’s a new RFC: https://wiki.php.net/rfc/zpp_fail_on_overflow > > Thoughts appreciated, as is help with the patch, though I can probably manage > on my own. It would be nice to describe why this change is good. So far the motivation is "it is unintuitive" which

Re: [PHP-DEV] Invokation on __toString() for object used as array key

Hi! > I do believe that the UString class would benefit from such a change. > > Why would it be confusing to implement this? For some objects, it may lead to rather strange results - i.e., Exception has __toString() but probably not very useful one for use as an array key. So may some other __to

Re: [PHP-DEV] Improve PHP 7 serialization

Hi! > Perhaps a compromise would be to choose the quickest method of > serialization, add it to PHP core. > > In php.ini add the directive > serialization.method = msgpack / Igbinary / We could, but what if you need to read/write data specifically from current PHP serializer? You'd have to

Re: [PHP-DEV] Improve PHP 7 serialization

> Why break anything? If you need faster serializer, it's quite easy to > get one, including msgpack. If it is really an issue that is important > for people, we could include the package into core. But I don't see > breaking BC in serialize/unserialize as a big win here. If it's really a > bottlen

Re: [PHP-DEV] Improve PHP 7 serialization

On 23 September 2014 12:17:35 GMT+01:00, Park Framework wrote: >Performance testing, Msgpack VS Igbinary > >igbinary: -20% slower, data size ~5% > As with any benchmark, the details of the test are rather important. Firstly, some data structures may be better handled than others, or be targeted

Re: [PHP-DEV] Improve PHP 7 serialization

Hi! > I clearly didn't google, it would be interesting to see comparisons of high > speed PHP serialization libraries. I for one would be happy, in PHP 7, to > break BC serialization syntax in favour of putting in a much faster > serializer by default. Similar scenario to putting in Zend OpCache b

RE: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Sep 23, 2014 8:17 PM, "Zeev Suraski" wrote: > > I'd welcome better suggestions if anybody has any. I think the complete > lack of metrics and exceptionally low barrier to voting is a much bigger > problem. > Please point me at a vote where the author is not part of what you defined (and the

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

Hi Mike, > So it could still be seen as "works as expected", because it just checks if > any answer is received. If that functionality is useful could be debatable. That's not expected. Chasing (dereferencing) CNAMEs is one of the understood burdens of any DNS app; you can't treat the CNAME its

RE: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

> -Original Message- > From: Robert Stoll [mailto:p...@tutteli.ch] > Sent: Tuesday, September 23, 2014 5:48 PM > To: 'Ferenc Kovacs'; 'Andrey Andreev' > Cc: 'Florian Anderiasch'; 'Zeev Suraski'; 'Derick Rethans'; 'Andrea > Faulds'; 'PHP > internals' > Subject: AW: [PHP-DEV] Is it fair that

Re: [PHP-DEV] Improve PHP 7 serialization

On 23 September 2014 17:36, Park Framework wrote: > > If you do not update in PHP 7 serialization method, it will never be > updated, the default serialization in PHP 7 will be slow. > > To maintain backward compatibility, can implement support method calls > on primitive types, new algorithms for

[PHP-DEV] Re: Remove alternative PHP tags

On Wed, Sep 10, 2014 at 12:08 AM, Nikita Popov wrote: > > Hi internals! > > I've created a small RFC proposing the removal of the alternative PHP > opening/closing tags: > > https://wiki.php.net/rfc/remove_alternative_php_tags > > It removes <% and

Re: [PHP-DEV] Improve PHP 7 serialization

On Tue, Sep 23, 2014 at 7:36 PM, Park Framework wrote: >> Not really, not because it is not good but because there is always be a >> better one. We can't break format in every release. > > If you do not update in PHP 7 serialization method, it will never be > updated, the default serialization in

Re: [PHP-DEV] Improve PHP 7 serialization

> Not really, not because it is not good but because there is always be a > better one. We can't break format in every release. If you do not update in PHP 7 serialization method, it will never be updated, the default serialization in PHP 7 will be slow. To maintain backward compatibility, can im

Re: [PHP-DEV] [VOTE][RFC] Integer Semantics

On 23 Sep 2014, at 16:57, Ferenc Kovacs wrote: > yeah, and when there is like 12 minutes between the last required vote casted > and the vote being casted(almost a day earlier), it is easy to jump to > conclusions. The vote closing soon after the last vote was not a coincidence, but it’s the

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 5:46 PM, Ferenc Kovacs wrote: > > > On Tue, Sep 23, 2014 at 5:35 PM, Robert Stoll wrote: > >> > > >> > > I do not think it makes sense to take the number of commits as metric. >> > > People's commit behaviour is different. Some commit only once after >> > > everything is

[PHP-DEV] Re: VCS Account Request: leigh

VCS Account Approved: leigh approved by tyrael \o/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: VCS Account Request: fmargaine

VCS Account Approved: fmargaine approved by tyrael \o/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE][RFC] Integer Semantics

On Mon, Sep 22, 2014 at 10:19 PM, Stas Malyshev wrote: > Hi! > > > I didn’t close it because the time suited me most. I made an honest > > mistake and closed it 22 or so hours early because I forgot I’d > > opened the vote at ~23:00 and not ~02:00. Unfortunately, I realised > > my mistake after m

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 5:35 PM, Robert Stoll wrote: > > > > > > I do not think it makes sense to take the number of commits as metric. > > > People's commit behaviour is different. Some commit only once after > > > everything is done and others commit regularly after each achieved > > > small st

AW: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

> > > > I do not think it makes sense to take the number of commits as metric. > > People's commit behaviour is different. Some commit only once after > > everything is done and others commit regularly after each achieved > > small step towards the goal. > > I belong rather to the second group. Why

Re: [PHP-DEV] Improve PHP 7 serialization

On Sep 23, 2014 3:31 PM, "Paul Dragoonis" wrote: > > I clearly didn't google, it would be interesting to see comparisons of high speed PHP serialization libraries. I for one would be happy, in PHP 7, to break BC serialization syntax in favour of putting in a much faster serializer by default. Simi

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 4:47 PM, Robert Stoll wrote: > > > one of your pr's did not keep the author info, it seems as it was > squashed into a single commit: > > > http://git.php.net/?p=php-src.git;a=commit;h=ec2fff80e768dfb04aa393c06a2b1a42a9e871ff > > so it isn't a problem with the list, but ho

AW: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

> one of your pr's did not keep the author info, it seems as it was squashed > into a single commit: > http://git.php.net/?p=php-src.git;a=commit;h=ec2fff80e768dfb04aa393c06a2b1a42a9e871ff > so it isn't a problem with the list, but how your PR was merged. > ofc. probably there are other similar c

Re: [PHP-DEV] Re: Re: OpenSSL bug in 5.4.33 and 5.5.17

On Tue, Sep 23, 2014 at 3:24 PM, Ferenc Kovacs wrote: > > > On Tue, Sep 23, 2014 at 7:39 AM, Daniel Lowrey wrote: >> >> >> Hi, >> >> >> >> That's a bad thing we need to fix ASAP. >> >> >> >> I think for 5.6.1 we'll revert it , if not, we'll need an RC2, which >> >> is something we usually don't d

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 3:27 PM, Andrey Andreev wrote: > On Tue, Sep 23, 2014 at 4:13 PM, Ferenc Kovacs wrote: > > On Tue, Sep 23, 2014 at 10:27 AM, Florian Anderiasch > > wrote: > > > >> On 09/22/2014 08:56 PM, Zeev Suraski wrote: > >> > The first bullet is the one this thread deals with so fa

Re: [PHP-DEV] Improve PHP 7 serialization

Park Framework wrote (on 23/09/2014): PHP serialization is slowest in PHP Session, clients NoSQL, ... I would like to have in PHP 7, a new serialization algorithm or custom handler to serialize. My opinion is that the best choice is to use msgpack, it is +110% faster -30% data size HHVM discuss

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

> > > That's a horrible idea. From a very quick unscientific glance at > https://github.com/php/php-src/graphs/contributors there's only ~50 > people *ever* to have more than 20 commits in php-src. I believe this may be partially due to the fact that github will only show contributors to the defa

Re: [PHP-DEV] Improve PHP 7 serialization

I clearly didn't google, it would be interesting to see comparisons of high speed PHP serialization libraries. I for one would be happy, in PHP 7, to break BC serialization syntax in favour of putting in a much faster serializer by default. Similar scenario to putting in Zend OpCache by default ins

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 4:13 PM, Ferenc Kovacs wrote: > On Tue, Sep 23, 2014 at 10:27 AM, Florian Anderiasch > wrote: > >> On 09/22/2014 08:56 PM, Zeev Suraski wrote: >> > The first bullet is the one this thread deals with so far. It clearly >> > states that having an SVN account isn't enough -

Re: [PHP-DEV] Re: Re: OpenSSL bug in 5.4.33 and 5.5.17

On Tue, Sep 23, 2014 at 7:39 AM, Daniel Lowrey wrote: > >> Hi, > >> > >> That's a bad thing we need to fix ASAP. > >> > >> I think for 5.6.1 we'll revert it , if not, we'll need an RC2, which > >> is something we usually don't do (but as this could involve security, > >> we may do it). > >> The f

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 10:27 AM, Florian Anderiasch wrote: > On 09/22/2014 08:56 PM, Zeev Suraski wrote: > > The first bullet is the one this thread deals with so far. It clearly > > states that having an SVN account isn't enough - but that code > contributions > > to PHP are mandatory. We sho

Re: [PHP-DEV] Improve PHP 7 serialization

http://pecl.php.net/package/msgpack On Tue, Sep 23, 2014 at 1:34 PM, Leigh wrote: > On 23 September 2014 12:22, Paul Dragoonis wrote: >> Write an extension for it then, also share your benchmarks :) >> > > Why go to all that trouble, 10 seconds on Google and we have: > > https://github.com/msgpa

Re: [PHP-DEV] Improve PHP 7 serialization

On 23 September 2014 12:22, Paul Dragoonis wrote: > Write an extension for it then, also share your benchmarks :) > Why go to all that trouble, 10 seconds on Google and we have: https://github.com/msgpack/msgpack-php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit

Re: [PHP-DEV] Improve PHP 7 serialization

Write an extension for it then, also share your benchmarks :) On Tue, Sep 23, 2014 at 12:17 PM, Park Framework wrote: > Performance testing, Msgpack VS Igbinary > > igbinary: -20% slower, data size ~5% > > Advantage Msgpack, he works fast, and this format understood by many > technologies - Java

Re: [PHP-DEV] Improve PHP 7 serialization

Performance testing, Msgpack VS Igbinary igbinary: -20% slower, data size ~5% Advantage Msgpack, he works fast, and this format understood by many technologies - Java, Python, Lua in Redis. 2014-09-23 12:20 GMT+03:00 Paul Dragoonis : > Hi , > > Backwards compatibility is one hurdle, but if you

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On Tue, Sep 23, 2014 at 10:27 AM, Florian Anderiasch wrote: > On 09/22/2014 08:56 PM, Zeev Suraski wrote: >> The first bullet is the one this thread deals with so far. It clearly >> states that having an SVN account isn't enough - but that code contributions >> to PHP are mandatory. We should pr

Re: [PHP-DEV] Invokation on __toString() for object used as array key

Hi, I do believe that the UString class would benefit from such a change. Why would it be confusing to implement this? Regards, *Florian Margaine* Le 23 sept. 2014 12:42, "Michael Wallner" a écrit : > On 2014-09-23 11:45, Leigh wrote: > > On 23 September 2014 10:35, Michael Wallner wrote: >

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 2014-09-23 11:45, Leigh wrote: > On 23 September 2014 10:35, Michael Wallner wrote: >> On 2014-09-23 11:15, Leigh wrote: >>> He doesn't want to add the object as a key, he wants to invoke __toString(). >> >> Did I write that? > > No, you didn't, sorry. > > I just didn't see how an object with

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 23 September 2014 10:35, Michael Wallner wrote: > On 2014-09-23 11:15, Leigh wrote: >> He doesn't want to add the object as a key, he wants to invoke __toString(). > > Did I write that? No, you didn't, sorry. I just didn't see how an object with an explicit method to convert it to a string co

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 2014-09-23 11:15, Leigh wrote: > On 23 September 2014 09:51, Michael Wallner wrote: >> >> Yes, it was removed intentionally (quite a long time ago), like using >> resources as array keys, to avoid hard-to-trace bugs for the user. At >> least that's the reasoning I can remember. > > He doesn't

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On Tue, Sep 23, 2014 at 12:29 PM, Andrea Faulds wrote: > >> On 23 Sep 2014, at 10:15, Leigh wrote: >> >>> On 23 September 2014 09:51, Michael Wallner wrote: >>> >>> Yes, it was removed intentionally (quite a long time ago), like using >>> resources as array keys, to avoid hard-to-trace bugs for

Re: [PHP-DEV] Invokation on __toString() for object used as array key

> On 23 Sep 2014, at 10:15, Leigh wrote: > >> On 23 September 2014 09:51, Michael Wallner wrote: >> >> Yes, it was removed intentionally (quite a long time ago), like using >> resources as array keys, to avoid hard-to-trace bugs for the user. At >> least that's the reasoning I can remember. >

Re: [PHP-DEV] Improve PHP 7 serialization

Hi , Backwards compatibility is one hurdle, but if you wipe all your serialised data then begin to re-serialise using the new approach then you're fine. As for what to use msgpack or igbinary, well there's already good support for igbinary in PHP thanks to Pierre and others. You should benchmark

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 23 September 2014 09:51, Michael Wallner wrote: > > Yes, it was removed intentionally (quite a long time ago), like using > resources as array keys, to avoid hard-to-trace bugs for the user. At > least that's the reasoning I can remember. He doesn't want to add the object as a key, he wants to

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On 2014-09-23 10:47, Michael Wallner wrote: > On 2014-09-23 10:11, Sanford Whiteman wrote: >>> if somehost.example.com has the MX, it should return true with >>> checkdnsrr('somehost.example.com'). If example has the MX set to >>> somehost.example.com or similar, it should return true as well. Or a

Re: [PHP-DEV] Invokation on __toString() for object used as array key

On 2014-09-23 10:04, Nicolai Scheer wrote: > Hi all, > > until 5 minutes ago I thought it would be perfectly legal to use an object > as an array key, given that its __toString() method is in place. > > Seems as if I was wrong. > I know that array keys are not what is considered "string context"

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On 2014-09-23 10:11, Sanford Whiteman wrote: >> if somehost.example.com has the MX, it should return true with >> checkdnsrr('somehost.example.com'). If example has the MX set to >> somehost.example.com or similar, it should return true as well. Or am >> I missing your point? > > You are missing i

Re: [PHP-DEV] Is it fair that people with no karma can vote on RFCs?

On 09/22/2014 08:56 PM, Zeev Suraski wrote: > The first bullet is the one this thread deals with so far. It clearly > states that having an SVN account isn't enough - but that code contributions > to PHP are mandatory. We should probably consider revising that to also > account for people contrib

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

> if somehost.example.com has the MX, it should return true with > checkdnsrr('somehost.example.com'). If example has the MX set to > somehost.example.com or similar, it should return true as well. Or am > I missing your point? You are missing it, as there are no MX records involved. I'm demonstr

[PHP-DEV] Invokation on __toString() for object used as array key

Hi all, until 5 minutes ago I thought it would be perfectly legal to use an object as an array key, given that its __toString() method is in place. Seems as if I was wrong. I know that array keys are not what is considered "string context" internally, at least not directly. Would it harm in any

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On Tue, Sep 23, 2014 at 9:41 AM, Sanford Whiteman wrote: > I don't think you tracked the behavior in the bug report. > > If checkdnsrr() is doing an MX query -- not including implicit MX, > only explicit MX -- it must fail when there is no MX record. It can't > return `true` when there is a CNAME

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On Tue, Sep 23, 2014 at 12:38 AM, Michael Wallner wrote: > On 2014-09-23 09:30, Kris Craig wrote: > > > > > > On Tue, Sep 23, 2014 at 12:24 AM, Michael Wallner > > wrote: > > > > On 2014-09-23 06:00, Sanford Whiteman wrote: > > >> What would happen is it'd throw an E

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

I don't think you tracked the behavior in the bug report. If checkdnsrr() is doing an MX query -- not including implicit MX, only explicit MX -- it must fail when there is no MX record. It can't return `true` when there is a CNAME (and no MX record for the canonical hostname, only an A) but `false

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On 2014-09-23 09:30, Kris Craig wrote: > > > On Tue, Sep 23, 2014 at 12:24 AM, Michael Wallner > wrote: > > On 2014-09-23 06:00, Sanford Whiteman wrote: > >> What would happen is it'd throw an E_DEPRECATED for at least the > remainder > >> of 5.x, then throw

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On Tue, Sep 23, 2014 at 12:24 AM, Michael Wallner wrote: > On 2014-09-23 06:00, Sanford Whiteman wrote: > >> What would happen is it'd throw an E_DEPRECATED for at least the > remainder > >> of 5.x, then throw the usual E_WARNING for a missing argument starting > in > >> 7.x with no default. > >

Re: [PHP-DEV] Little switch improvement: get the used variable

Hi Martin, > The `get_the_used_switch_variable()` is just a placeholder, name can be > changed to something natural...maybe a constant. I feel this has diminished utility once you consider that the "switch variable" is actually an expression and could well include multiple $variables. Plus there'

Re: [PHP-DEV] [RFC] Change checkdnsrr() $type argument behavior

On 2014-09-23 06:00, Sanford Whiteman wrote: >> What would happen is it'd throw an E_DEPRECATED for at least the remainder >> of 5.x, then throw the usual E_WARNING for a missing argument starting in >> 7.x with no default. > > Sounds OK to me now that I've noticed this: > > https://bugs.php.

[PHP-DEV] Little switch improvement: get the used variable

Hello together, i often write switches, where i throw an Exception when something unknown come in, rather than using a default value. switch($myVar){ case 1: doSomethingElse(); break; case 2: doSomething(); break; //... default: throw new Exception('Undefined input