[GitHub] [hadoop-ozone] elek commented on issue #96: HDDS-2374. Make Ozone Readme.txt point to the Ozone websites instead …

2019-10-29 Thread GitBox
elek commented on issue #96: HDDS-2374. Make Ozone Readme.txt point to the Ozone websites instead … URL: https://github.com/apache/hadoop-ozone/pull/96#issuecomment-547445551 FTR: A more powerful solution is to review and merge #55 -

[GitHub] [hadoop-ozone] cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm commented on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-547457348 Thanks @bharatviswa504 for the comment. With the trace of SetAclHanlder, we found that the Set operation would clear AclList, so the

[GitHub] [hadoop-ozone] ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands

2019-10-29 Thread GitBox
ChenSammi commented on issue #29: HDDS-2034. Async RATIS pipeline creation and destroy through heartbeat commands URL: https://github.com/apache/hadoop-ozone/pull/29#issuecomment-547479697 New update per the review comments. Remove RATIS ONE factor pipeline from HealthyPipelineSafeModeRule

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340144024 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340148942 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoo

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340150431 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340146383 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340149026 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoo

[GitHub] [hadoop-ozone] swagle commented on issue #98: HDDS-2363. Fail to create Ratis container.

2019-10-29 Thread GitBox
swagle commented on issue #98: HDDS-2363. Fail to create Ratis container. URL: https://github.com/apache/hadoop-ozone/pull/98#issuecomment-547489903 Thanks @ChenSammi for the fix, changes look good to me. There seems to be a related integration test failure. ---

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340168717 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/cl

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r340170991 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java ## @@

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r340170991 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java ## @@

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340223900 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/Co

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340224701 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340234039 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340233806 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/conta

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340234544 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/T

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340234588 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/T

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340236516 ## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/

[GitHub] [hadoop-ozone] akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340240750 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340240750 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340242564 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Cont

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340243591 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340244131 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340245027 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340245027 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340246338 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340247042 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340247903 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Cont

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340250670 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Cont

[GitHub] [hadoop-ozone] anuengineer commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
anuengineer commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-547565490 Hi All, Thank you all for an extensive code review of this patch. If we are all in Sync and there are no issues left outstanding, is it okay

[GitHub] [hadoop-ozone] arp7 commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
arp7 commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-547569318 Thank you all for carefully reviewing multiple iterations of this patch! 🙂 This i

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
bharatviswa504 opened a new pull request #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100 ## What changes were proposed in this pull request? Close the BatchOperation, by using try with the resourc

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r340267222 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java ## @@ -

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r340267222 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java ## @@ -

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown URL: https://github.com/apache/hadoop-ozone/pull/99#discussion_r340271488 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/h

[GitHub] [hadoop-ozone] akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
akki commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340272372 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,176 @@ +Apache Hadoop Ozone Contribution gui

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#discussion_r340283955 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/OzoneAdmin.java ## @@

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340284826 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Cont

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
bharatviswa504 commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-547595710 Thank You for all the reviews and @hanishakoneru for the contribution. --

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
bharatviswa504 merged pull request #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
bharatviswa504 edited a comment on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-547595710 Thank You everyone for the reviews and @hanishakoneru for the contribution. -

[GitHub] [hadoop-ozone] hanishakoneru commented on issue #9: HDDS-2240. Command line tool for OM Admin

2019-10-29 Thread GitBox
hanishakoneru commented on issue #9: HDDS-2240. Command line tool for OM Admin URL: https://github.com/apache/hadoop-ozone/pull/9#issuecomment-547596578 Thank you all for the reviews. This is an automated message from the Apac

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown

2019-10-29 Thread GitBox
smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown URL: https://github.com/apache/hadoop-ozone/pull/99#discussion_r340300182 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/o

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown

2019-10-29 Thread GitBox
smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown URL: https://github.com/apache/hadoop-ozone/pull/99#discussion_r340300182 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/o

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown

2019-10-29 Thread GitBox
smengcl commented on a change in pull request #99: HDDS-2377. Speed up TestOzoneManagerHA#testOMRetryProxy and #testTwoOMNodesDown URL: https://github.com/apache/hadoop-ozone/pull/99#discussion_r340300182 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/o

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
avijayanhwx commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100#issuecomment-547617488 LGTM +1 This is an automated messag

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
arp7 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340312385 ## File path: hadoop-ozone/common/src/main/j

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
arp7 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340312109 ## File path: hadoop-ozone/common/src/main/j

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #101: HDDS-2364. Add a OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
avijayanhwx opened a new pull request #101: HDDS-2364. Add a OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101 ## What changes were proposed in this pull request? Added metrics for tracking the RocksDB keyMayExist miss ra

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo…

2019-10-29 Thread GitBox
avijayanhwx opened a new pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo… URL: https://github.com/apache/hadoop-ozone/pull/102 …r pre-existing files in the directory path. ## What changes were proposed in this pull request? Currently, when

[GitHub] [hadoop-ozone] fapifta commented on issue #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
fapifta commented on issue #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#issuecomment-547638382 @dineshchitlangia thank you for the review, and for committing it if there are no further questions. ---

[GitHub] [hadoop-ozone] fapifta opened a new pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable

2019-10-29 Thread GitBox
fapifta opened a new pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable URL: https://github.com/apache/hadoop-ozone/pull/103 ## What changes were proposed in this pull request? In #95 review it came up that the tests could use t

[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository

2019-10-29 Thread GitBox
anuengineer commented on a change in pull request #58: HDDS-2293. Create a new CONTRIBUTION.md for the new repository URL: https://github.com/apache/hadoop-ozone/pull/58#discussion_r340346960 ## File path: CONTRIBUTION.md ## @@ -0,0 +1,174 @@ +Apache Hadoop Ozone Contribut

[GitHub] [hadoop-ozone] anuengineer commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
anuengineer commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100#issuecomment-547651088 The doubleBuffer Commit is being run from a single thread, right? I am little confused about how th

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo…

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo… URL: https://github.com/apache/hadoop-ozone/pull/102#discussion_r340349494 ## File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
bharatviswa504 commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100#issuecomment-547652281 > The doubleBuffer Commit is being run from a single thread, right? I am little confused about ho

[GitHub] [hadoop-ozone] anuengineer merged pull request #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re…

2019-10-29 Thread GitBox
anuengineer merged pull request #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re… URL: https://github.com/apache/hadoop-ozone/pull/55 This is an automated message from the Apache Git Service. To res

[GitHub] [hadoop-ozone] anuengineer commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re…

2019-10-29 Thread GitBox
anuengineer commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re… URL: https://github.com/apache/hadoop-ozone/pull/55#issuecomment-547653164 Thank you, this is much better. +1, I have merged this to the master. --

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340352841 ## File path: hadoop-ozone/common/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340353363 ## File path: hadoop-ozone/common/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340353363 ## File path: hadoop-ozone/common/

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 commented on issue #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#issuecomment-547655457 > The change looks pretty good. A couple of minor comments, n

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 merged pull request #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89 This is an autom

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy.

2019-10-29 Thread GitBox
bharatviswa504 commented on issue #89: HDDS-2322. DoubleBuffer flush termination and OM shutdown's after that. Make entry returned from cache a new copy. URL: https://github.com/apache/hadoop-ozone/pull/89#issuecomment-547656858 Thank You @arp7 for the review.

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #104: HDDS-2381. In ExcludeList, add if not exist only.

2019-10-29 Thread GitBox
bharatviswa504 opened a new pull request #104: HDDS-2381. In ExcludeList, add if not exist only. URL: https://github.com/apache/hadoop-ozone/pull/104 ## What changes were proposed in this pull request? Add a check if not contains for addDatanode, addPipeline, addContainer. ##

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-29 Thread GitBox
avijayanhwx commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#issuecomment-547671407 > Overall LGTM. One minor comment. > And also can you confirm if UT failure is

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key.

2019-10-29 Thread GitBox
bharatviswa504 commented on issue #102: HDDS-2380. Use the Table.isExist() API instead of get() API while checking for presence of key. URL: https://github.com/apache/hadoop-ozone/pull/102#issuecomment-547677285 Ready to go, if UT failures are not related. -

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia commented on issue #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#issuecomment-547679921 Thanks @fapifta for the contribution and @bharatviswa504 for the review. Committed this to master.

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager

2019-10-29 Thread GitBox
dineshchitlangia merged pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95 This is an automated message from the Apache Git Service

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable URL: https://github.com/apache/hadoop-ozone/pull/103#discussion_r340381665 ## File path: hadoop-hdds/container-service/src/test/java/

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340382308 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340383373 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340383373 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340384007 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
bharatviswa504 commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340384007 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds

[GitHub] [hadoop-ozone] arp7 commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re…

2019-10-29 Thread GitBox
arp7 commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re… URL: https://github.com/apache/hadoop-ozone/pull/55#issuecomment-547727566 I've reverted this, I think it broke the packaging. ---

[GitHub] [hadoop-ozone] arp7 commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re…

2019-10-29 Thread GitBox
arp7 commented on issue #55: HDDS-2292. Create Ozone specific README.md to the new hadoop-ozone re… URL: https://github.com/apache/hadoop-ozone/pull/55#issuecomment-547727639 ``` Current directory /Users/agarwal/src/ozone/hadoop-ozone/dist/target $ rm -rf ozone-0.5.0-SNAPSHOT $

[GitHub] [hadoop-ozone] anuengineer commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
anuengineer commented on issue #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100#issuecomment-547729490 +1. LGTM. This is an automated mess

[GitHub] [hadoop-ozone] anuengineer merged pull request #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys.

2019-10-29 Thread GitBox
anuengineer merged pull request #100: HDDS-2379. OM terminates with RocksDB error while continuously writing keys. URL: https://github.com/apache/hadoop-ozone/pull/100 This is an automated message from the Apache Git Service

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #104: HDDS-2381. In ExcludeList, add if not exist only.

2019-10-29 Thread GitBox
dineshchitlangia commented on issue #104: HDDS-2381. In ExcludeList, add if not exist only. URL: https://github.com/apache/hadoop-ozone/pull/104#issuecomment-547731746 It seems the acceptance failed as it couldn't find the directory ../ozone/compose. I will re-trigger the test. ---

[GitHub] [hadoop-ozone] dineshchitlangia commented on issue #104: HDDS-2381. In ExcludeList, add if not exist only.

2019-10-29 Thread GitBox
dineshchitlangia commented on issue #104: HDDS-2381. In ExcludeList, add if not exist only. URL: https://github.com/apache/hadoop-ozone/pull/104#issuecomment-547731773 /retest This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable

2019-10-29 Thread GitBox
dineshchitlangia commented on a change in pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable URL: https://github.com/apache/hadoop-ozone/pull/103#discussion_r340381665 ## File path: hadoop-hdds/container-service/src/test/java/

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340426043 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ut

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist.

2019-10-29 Thread GitBox
avijayanhwx commented on a change in pull request #101: HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. URL: https://github.com/apache/hadoop-ozone/pull/101#discussion_r340427959 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ut

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r340429508 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/AddAclKeyHandler.java

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r340429508 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/AddAclKeyHandler.java

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm commented on a change in pull request #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#discussion_r340004152 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/AddAclKeyHandler.java

[GitHub] [hadoop-ozone] jojochuang commented on issue #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-29 Thread GitBox
jojochuang commented on issue #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#issuecomment-547739046 Code looks good to me. Can you double check to make sure the failed test are unrelated? --

[GitHub] [hadoop-ozone] cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-547457348 Thanks @bharatviswa504 for the comment. ```RemoveAclHandler``` updated. And I found that ```ozone sh vol setacl --acls=

[GitHub] [hadoop-ozone] anuengineer commented on issue #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-29 Thread GitBox
anuengineer commented on issue #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#issuecomment-547740107 I looked at the test failures; it looks that some of them are timed out; many of the other have assertion failures, but none of th

[GitHub] [hadoop-ozone] cxorm commented on issue #70: HDDS-1643. Send hostName also part of OMRequest.

2019-10-29 Thread GitBox
cxorm commented on issue #70: HDDS-1643. Send hostName also part of OMRequest. URL: https://github.com/apache/hadoop-ozone/pull/70#issuecomment-547740474 /retest This is an automated message from the Apache Git Service. To res

[GitHub] [hadoop-ozone] cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-547457348 Thanks @bharatviswa504 for the comment. ```RemoveAclHandler``` updated. And I found that ```ozone sh vol setacl --acls=

[GitHub] [hadoop-ozone] cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages

2019-10-29 Thread GitBox
cxorm edited a comment on issue #94: HDDS-2255. Improve Acl Handler Messages URL: https://github.com/apache/hadoop-ozone/pull/94#issuecomment-547457348 Thanks @bharatviswa504 for the comment. ```RemoveAclHandler``` updated. And I found that ```ozone sh vol setacl --acls=

[GitHub] [hadoop-ozone] lokeshj1703 merged pull request #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE

2019-10-30 Thread GitBox
lokeshj1703 merged pull request #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [hadoop-ozone] lokeshj1703 commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE

2019-10-30 Thread GitBox
lokeshj1703 commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81#issuecomment-547764518 The changes look good to me. +1. This is an automated mes

[GitHub] [hadoop-ozone] lokeshj1703 commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE

2019-10-30 Thread GitBox
lokeshj1703 commented on issue #81: HDDS-2347. XCeiverClientGrpc's parallel use leads to NPE URL: https://github.com/apache/hadoop-ozone/pull/81#issuecomment-547769051 @fapifta Thanks for the contribution! @bshashikant @hanishakoneru Thanks for the reviews! I have merged the PR to master b

[GitHub] [hadoop-ozone] chimney-lee opened a new pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin

2019-10-30 Thread GitBox
chimney-lee opened a new pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin URL: https://github.com/apache/hadoop-ozone/pull/105 ## What changes were proposed in this pull request? With cuuent version, cannot run hddsdatanodeservice as hdfs datanode pulgi

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin

2019-10-30 Thread GitBox
adoroszlai commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin URL: https://github.com/apache/hadoop-ozone/pull/105#discussion_r340470980 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatan

[GitHub] [hadoop-ozone] chimney-lee commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin

2019-10-30 Thread GitBox
chimney-lee commented on a change in pull request #105: HDDS-2370.Support HddsDatanodeService run as DataNode Plugin URL: https://github.com/apache/hadoop-ozone/pull/105#discussion_r340483109 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsData

<    1   2   3   4   5   6   7   8   9   >