dineshchitlangia commented on a change in pull request #103: HDDS-2378 - Change OZONE as string used in the code where OzoneConsts.OZONE is suitable URL: https://github.com/apache/hadoop-ozone/pull/103#discussion_r340381665
########## File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java ########## @@ -48,6 +49,9 @@ private static final long MAXSIZE = (long) StorageUnit.GB.toBytes(5); private static final Instant SCAN_TIME = Instant.now(); + private static final String VOLUMEOWNER = "hdfs"; + private static final String CONTAINERDBTYPE = "RocksDB"; + Review comment: NIT: I wold have rather preferred the constant names to be more readable like VOLUME_OWNER, CONTAINER_DB_TYPE ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
