dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move
isUseRatis getFactor and getType from XCeiverClientManager
URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340146383
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestContainerPlacement.java
##########
@@ -158,13 +159,13 @@ public void testContainerPlacementCapacity() throws
IOException,
assertEquals(remaining * nodeCount,
(long) nodeManager.getStats().getRemaining().get());
- xceiverClientManager= new XceiverClientManager(new OzoneConfiguration());
+ xceiverClientManager= new XceiverClientManager(conf);
ContainerInfo container = containerManager
.allocateContainer(
- xceiverClientManager.getType(),
- xceiverClientManager.getFactor(), "OZONE");
- assertEquals(xceiverClientManager.getFactor().getNumber(),
+ SCMTestUtils.getReplicationType(conf),
+ SCMTestUtils.getReplicationFactor(conf), "OZONE");
Review comment:
"OZONE" could be replaced by `OzoneConsts.OZONE` if it's not required to be
in capital letters.
Otherwise, we can add a new constant in OzoneConsts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
