dineshchitlangia commented on a change in pull request #95: HDDS-2373 Move
isUseRatis getFactor and getType from XCeiverClientManager
URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340149026
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManager.java
##########
@@ -193,7 +194,7 @@ private void testRpcPermissionWithConf(
try {
ContainerWithPipeline container3 = mockClientServer
- .allocateContainer(xceiverClientManager.getType(),
+ .allocateContainer(SCMTestUtils.getReplicationType(ozoneConf),
HddsProtos.ReplicationFactor.ONE, "OZONE");
Review comment:
"OZONE" could be replaced by OzoneConsts.OZONE if it's not required to be in
capital letters.
Otherwise, we can add a new constant in OzoneConsts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
