fapifta commented on a change in pull request #95: HDDS-2373 Move isUseRatis getFactor and getType from XCeiverClientManager URL: https://github.com/apache/hadoop-ozone/pull/95#discussion_r340223900
########## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/ContainerOperationClient.java ########## @@ -449,11 +504,7 @@ public void closeContainer(long containerId) public long getContainerSize(long containerID) throws IOException { // TODO : Fix this, it currently returns the capacity // but not the current usage. - long size = getContainerSizeB(); - if (size == -1) { - throw new IOException("Container size unknown!"); - } - return size; + return containerSizeB; Review comment: In theory this method should return the actual size of a container as defined in the in the interface we inherit the method from, and also as mentioned in the TODO, for that we will need the container ID once we implement this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org