Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

2008-01-13 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > Unlike the other GRUB2 utils, grub-emu uses the glibc extension > argp_parse(). It is unavailable on Cygwin, which might also be the > case for other platforms where glibc is not the native runtime. > > This patch changes this back to the more traditi

Re: revision control of `configure'

2008-01-13 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > On Tue, 2008-01-08 at 12:57 +0100, Robert Millan wrote: >> http://cvs.savannah.gnu.org/viewvc/grub2/configure?root=grub&view=log >> >> Does it make sense to keep `configure' under revision control? Almost every >> commit for unrelated things tends to ch

Re: [PATCH] jpeg image reader

2008-01-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > change the handling of width/height that's not aligned, now it use the > exact size instead of padding. You forgot the changelog entry. I'll do a quick review. Especially the longjmp stuff should be changed, IMO. Otherwise the code is of good quality and

Re: [PATCH] Bug fix for parser

2008-01-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > I write a patch for parser related bug, it fix the following problems: > > 1, major modification for parse.y, now it should work better. For example, > > if echo aa; echo bb; then echo cc; fi > > it works properly now. Nice :-) > 2, Check for undefined var

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> > /* >> > * GRUB -- GRand Unified Bootloader >> > * Copyright (C) 2008 Free Software Foundation, Inc. >> >> Did you write all th

Re: ata.mod hangs (Re: Some grub2 problems/questions)

2008-01-15 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Robert Millan wrote: >> On Sat, Jan 12, 2008 at 04:14:38PM -0800, walt wrote: >>> Unfortunately, ata.mod still doesn't recognize the disk on the Promise >>> sata controller. But, that's expected at this point? >> >> Yes. Some SATA controllers emula

Re: [PATCH] fix `lvm' and `raid' loading for grub-install/core.img and update-grub/grub.cfg problems

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > New patch, a bit simpler (after giving it a though, I don't think the gained > speed is worth the extra complication) What does this patch fix? Too many problems in one thread... BTW, does it also work for the case both LVM and RAID are used? -- Marc

Re: Fwd: grub2: FTBFS on powerpc (__floatundisf in ls is not defined)

2008-01-15 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Sunday 13 January 2008 13:19, Robert Millan wrote: >> This is becoming a nightmare. I think it's better if we just exclude >> symbols starting with __ from our checks. They aren't really meant for us >> to mess with. > > My original suggestio

Re: [PATCH] Use getopt_long() instead of argp_parse() in grub-emu

2008-01-15 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: [...] > 2008-01-14 Christian Franke <[EMAIL PROTECTED]> > > * util/grub-emu.c: Replace by . > (argp_program_version): Remove variable. > (argp_program_bug_address): Likewise. > (options): Convert from struct argp_option to s

Re: [PATCH] Bug fix for parser

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 14, 2008 2:42 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> > @@ -99,6 +101,9 @@ grub_script_execute_cmdline (struct grub_script_cmd >> > *cmd) >> >grubcmd = grub_command_find

Re: GRUB on OLPC / XO

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: Hi, > I've been working for a few hours in a GRUB port to i386/OFW. There's > quite a bit of things that need cleanup/fix before it can be considered > complete, but it's in a stage that boots and lets you do basic things (like > listing storage devices)

Re: [PATCH] fix `lvm' and `raid' loading for grub-install/core.img and update-grub/grub.cfg problems

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 12:23:19PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > New patch, a bit simpler (after giving it a though, I don't think the >> >

Re: LVM on debian

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 08, 2008 at 09:18:47PM +0800, Bean wrote: >> On Jan 8, 2008 9:14 PM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > >> > On Tue, Jan 08, 2008 at 09:06:41PM +0800, Bean wrote: >> > > On Jan 8, 2008 9:00 PM, Martin Braure de Calignon <[EMAIL PRO

Re: GRUB on OLPC / XO

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: [...] >> Great! I'll just review the patch! :-) > > Please don't. It's not meant for review, was just a proof of concept. The > patches I actually intend to get merged are being sent separately (see my > later > mails on this). > > Oh well, too late..

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 12:01:47PM +0100, Marco Gerards wrote: >> Bean <[EMAIL PROTECTED]> writes: >> >> > On Jan 14, 2008 2:31 AM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> >> > /* >> &g

Re: [PATCH] fix flickering timeout message for slow terminals (gfxterm)

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote: >> On Monday 14 January 2008 15:10, Robert Millan wrote: >> > As subject says. Based on suggestions from Vesa. >> >> Why do you want to use a nested function? > > No special reason; j

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote: >> >> >> >> I do not think these algorithms can be copyrighted and are in the >> >> public domain? Can you check this? >> > >>

Re: [PATCH] fix endianess in IEEE-1275 integer properties

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > Integer properties are always in big endian. This (incomplete) patch is my > suggested approach to deal with this. I'd like to receive input about it > before I complete it (checking all calls to grub_ieee1275_get_property > through GRUB and replacing

Re: [PATCH] Bug fix for parser

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: >> > if grub_error is set, it will effect the parser, caused menu not to be >> > showed, etc. >> >> Right, but do you want to see a menu if not everything is correctly executed? > > the problem is that it's not always an error when grub_errno is set, > for example,

Re: GRUB on OLPC / XO

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 01:23:30PM +0100, Marco Gerards wrote: >> > OFW expects %eax to be the first parameter in callbacks. Other than this, >> > I assumed -mregparm is a useful size optimization. Is that not it? Why &g

Re: [PATCH] fix flickering timeout message for slow terminals (gfxterm)

2008-01-15 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 01:25:25PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote: >> >> On M

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 15, 2008 8:46 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Tue, Jan 15, 2008 at 01:21:04PM +0100, Marco Gerards wrote: >> >> >> >> &

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] >> > for (i = 0; i < cc; i++) >> > { >> > int id, ss; >> > >> > id = grub_jpeg_get_byte (data) - 1; >> > if ((id < 0) || (id >= 3)) >> > return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid index"); >> > >> > ss = gr

Re: [PATCH] Bug fix for parser

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 15, 2008 8:41 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Right. I am completely unhappy with the lexer as it is now... :-/ >> The main reason for writing it manually is that flex depends on all >> kinds of stuff I d

Re: [PATCH] jpeg image reader

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] >> Same for the other two lines. With this change, only the legal >> question remains. > > oh, i see. > > The IJG's source code: > > http://www.ijg.org/files/jpegsrc.v6b.tar.gz > > there is a legal issue section in the README file. The license state that t

Re: [PATCH] Bug fix for parser

2008-01-15 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] >> > thanks, if there is no problem, i would commit this now. >> >> If you mean your patch, that's fine for me. Please do not forget to >> rename script_1. Are there any other issues I brought up? > > ok, commited. Thanks! :-) -- Marco ___

Re: embedding filesystems in core image (Re: moving ata initialisation to a command)

2008-01-16 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Sat, Dec 22, 2007 at 01:24:53PM +0100, Yoshinori K. Okuji wrote: >> On Saturday 22 December 2007 13:18, Robert Millan wrote: >> > Here's a new patch, with some cleanup. The main difference is that >> > memdisk.c doesn't include any arch-specific code

Re: [PATCH] jpeg image reader

2008-01-21 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > i finish converting the idct and color code, now it should be ok. If you are 100% sure all code is yours and there are no legal issues, feel free to commit it. Your code looks good to me :-) -- Marco ___ Grub

Re: GRUB on OLPC / XO

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 01:06:43PM +0100, Robert Millan wrote: >> > >/* Load pre-loaded modules and free the space. */ >> > >grub_register_exported_symbols (); >> > > - grub_load_modules (); >> > > +// grub_load_modules (); >> > >> > Why? >>

Re: [PATCH] fix flickering timeout message for slow terminals (gfxterm)

2008-01-21 Thread Marco Gerards
Jordi Mallach <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote: >> Is this better? >> + char *msg = " The highlighted entry will be booted automatically in >> %ds."; >> + char *msg_end = grub_strchr (msg, '%'); >> + >> + grub_printf

Re: hfs breakage

2008-01-21 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi Bean, Thanks for picking this one up! [...] >> Moreover, if I mount the image as loop in Linux and remove files "grub" >> and "grub.cfg", "ls" in grub-emu will go into infinite loop and print >> "ofboot.b pc.mod raid.mod reboot.mod reiserfs.mod search.mod sfs

Re: How to return control to GRUB

2008-01-21 Thread Marco Gerards
Fabian Greffrath <[EMAIL PROTECTED]> writes: Hi, > I take care of the Debian package 'grub-invaders'. This is a multiboot > compliant kernel-game that resembles Space Invaders, but I guess you > knew that already. > > One thing that annoys me about the game is, that you cannot return to > the GRU

Re: [PATCH] abort when core.img is too big

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > With the addition of memdisk, it is too easy for user to create an image > big enough that would corrupt upper memory (starting with vga region). This > happens at roughly ~600 kiB memdisk size. > > This patch adds a check in grub-mkimage to prevent thi

Re: How to return control to GRUB

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 12:06:25PM +0100, Marco Gerards wrote: >> >> An alternative solution is, if the license for the game is GPLv3, >> making it a GRUB 2 module ;-) > > I thought about that, but note that t

Re: [PATCH] fix flickering timeout message for slow terminals (gfxterm)

2008-01-21 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > On Mon, 2008-01-21 at 11:33 +0100, Marco Gerards wrote: >> Jordi Mallach <[EMAIL PROTECTED]> writes: >> >> > On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote: >> >> Is this better? >> &

Re: [PATCH] fix flickering timeout message for slow terminals (gfxterm)

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 04:10:37PM +0100, Marco Gerards wrote: >> >> If done efficiently, code shouldn't get too big. Perhaps it is better >> to integrate this into normal.mod? I wouldn't mind a few extra KB >

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: >> >> On Tue, 2008-01-15 at 18:17 +0100, Robert Millan wrote: >> > - grub_dprintf ("mem", "Using memory for heap: addr=%p, size=%u\n", >> > addr, (unsigned int) size); >> > + grub_dprintf (

Re: [PATCH] improve grub_mm_init_region() debug message

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 06:02:20PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > On Tue, Jan 15, 2008 at 12:42:39PM -0500, Pavel Roskin wrote: >> >> >> >

Re: Wrong prefix

2008-01-21 Thread Marco Gerards
"Mathias Hällman" <[EMAIL PROTECTED]> writes: Hi, > I got the latest version of grub2 from the cvs repository, built it, > and installed it. Then I edited grub.cfg and ran grub-install > succesfully. > Now when I boot, the prefix is wrong. It is always set to > (hd0,6)/grub, while I want it to be

Re: [PATCH] safety check in claim_heap()

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: Hi, > What do you think of adding this kind of checks? I know it's not a > perfect safegard, but it can save your day in some situations (it helped > me during i386/ieee1275 port, when link address was 0x10). If this fixes the i386-ieee1275 port, th

Re: [PATCH] safety check in claim_heap()

2008-01-21 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 07:07:37PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> Hi, >> >> > What do you think of adding this kind of checks? I know it's not a &g

Re: [PATCH] memdisk plus lnxboot extension

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] > 2. Easy to modify > users may not know how to create core.img, but modifying files in a, > say, tar or cpio archive is very easy. They can do simple tasks like > replacing splash image without too much knowledge of grub2. It seems easier, but isn't. Firs

Re: [PATCH] memdisk plus lnxboot extension

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: >> 2. Easy to modify >> users may not know how to create core.img, but modifying files in a, >> say, tar or cpio archive is very easy. They can do simple tasks like >> replacing splash image without too much knowledge of grub2. >> >> 3. Multiple configurat

Re: [PATCH] allow user-configurable menucolor

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: >> >> About error handling: >> >> Why not call grub_error() with error message and just return from >> callback, and let prompt handle error processing (grub_print_error()). >> This wou

Re: hfs breakage

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 21, 2008 6:38 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Bean <[EMAIL PROTECTED]> writes: >> >> Hi Bean, >> >> Thanks for picking this one up! >> >> [...] >> >> >>

Re: UFS (FFS) support seems broken in grub2

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 02:58:02AM +0800, Bean wrote: >> This patch should fix the problem. > > Nice! > >> -grub_ufs_label (grub_device_t device __attribute ((unused)), >> -char **label __attribute ((unused))) >> +grub_ufs_label (grub_device_

Re: [PATCH] enable multiboot2 loader on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > This makes multiboot2 work on i386-ieee1275. Tested both with elf32 and > elf64 images. It looks ok to me. > In case of elf32 OFW images, they won't work because EAX is used for multiboot > information and can't hold the needed pointer to OFW callback

Re: [PATCH] enable multiboot2 loader on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: >> Can't you use a tag for the pointer? > > We can, but that's not useful. If we can't make them compatible, I find it > more feasible to write a separate loader for OFW images. Why not? > Though I don't see why not do it. The boot abi is already compa

Re: [PATCH] PNG image reader

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: Hi, > remove longjmp, also add grub_png prefix to function names. Thanks! A changelog entry is missing, this is a single file. See the review below for some comments. -- Marco > /* > * GRUB -- GRand Unified Bootloader > * Copyright (C) 2008 Free Soft

Re: [PATCH] enable multiboot2 loader on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 11:13:15AM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> >> Can't you use a tag for the pointer? >> > >> > We can, but that's

Re: [PATCH] memdisk + grub-mkrescue

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > These two were predestined to get together.. attached patch for their > wedding. > > Comments? > > -- > Robert Millan > > I know my rights; I want my phone call! > What use is a phone call… if you are unable to speak? > (as seen on /.) > > > *

Re: [PATCH] use at_keyboard.c on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > Taking into account that ofconsole on i386: > > - Has bugs with similar usability effect than at_keyboard.c (e.g. arrow keys > not working). > - In practice doesn't provide support for any keyboard other than AT > (since OFW shuts down USB be

Re: [PATCH] enable multiboot2 loader on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 11:38:48AM +0100, Marco Gerards wrote: >> >> > Though I don't see why not do it. The boot abi is already compatible on >> >> > PowerPC: >> >> > &

Re: [PATCH] memdisk + grub-mkrescue

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: [...] >> Overlay means that I can add a grub.cfg easily? > > It means you can do: > > mkdir -p boot/grub > zile boot/grub/grub.cfg > grub-mkrescue --overlay=boot > > Of course, it'd be easier if you could just add it directly, but I really > think having

Re: [PATCH] use at_keyboard.c on i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 11:58:58AM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > Taking into account that ofconsole on i386: >> > >> > - Has bugs with s

Re: [PATCH] Running GRUB under qemu on PowerPC

2008-01-23 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: Hi, [...] > ChangeLog: > > * include/grub/ieee1275/ieee1275.h: Introduce a flag for > broken color support, needed for Open Hack'Ware. > * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_find_options): > Recognize Open Hack'Wa

Re: netboot/UNDI status

2008-01-23 Thread Marco Gerards
Douglas Ward <[EMAIL PROTECTED]> writes: > I was wondering if any work has been completed on netboot for gurb2. I'm > most interested in a UNDI driver as my current setup using gpxe and > pxelinux. pxelinux does a fine job but I have always preferred grub. There is an outstanding patch for ethern

Re: [PATCH] grub-probe && FreeBSD

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 02, 2008 at 08:59:04PM -0500, Francis Gendreau wrote: >> >> Also, if someone can email-me how to uses diff so I can create patch in >> a single file, it would be greatly appreciated. :) > > diff -urp grub.old grub.new > > -r for recursive.

Re: grub2 efi patches

2008-01-23 Thread Marco Gerards
Alexandre Boeglin <[EMAIL PROTECTED]> writes: > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]> > wrote: >> I also still have to clean the chainloader options patch, but here is the >> changelog for the others: > > Hi, > > As Marco finally received my copyright applicatio

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Marco Gerards
Christian Franke <[EMAIL PROTECTED]> writes: > New version of the patch is attached. [...] Robert, did you review it again? -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: grub2 efi patches

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote: >> Alexandre Boeglin <[EMAIL PROTECTED]> writes: >> >> > On Sun, 18 Nov 2007 19:14:03 +0100, Alexandre Boeglin <[EMAIL PROTECTED]> >&g

Re: [PATCH] mkdevicemap for Cygwin

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 12:40:27PM +0100, Marco Gerards wrote: >> Christian Franke <[EMAIL PROTECTED]> writes: >> >> > New version of the patch is attached. >> >> [...] >> >> Robert, did y

Re: gfxterm / grub_virtual_screen_setcolorstate()

2008-01-23 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: > Robert Millan wrote: >> On Mon, Dec 24, 2007 at 02:28:18AM +0100, Robert Millan wrote: >>> New patch. Corrects a minor mistake when filling the last colum in the >>> menu. Also, it doesn't change the colors on gfxterm since some >>> reasjustments

Re: adding some more members

2008-01-23 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: Hi, > I think it would be more convenient to allow Bean and Alexandre to check in > changes themselves. Is there any objection? Not at all. Christian can be added to as far as I am concerned. Would you mind? Christian, do you have a savannah ac

Re: BTS for GRUB 2 (Re: BTS overhaul)

2008-01-23 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Sunday 16 December 2007 11:27, Vesa Jääskeläinen wrote: >> grub-help@ or grub-users@ would be more fit for user discussions. Are >> there any GNU "standards" for these? And perhaps require to switch to >> subscribe only lists. > > This might be

Patches

2008-01-23 Thread Marco Gerards
Hi, Are there any important patches I missed? I have a few mails I didn't process yet. If someone wants me to look at something, please poke me :-) -- Marco ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-d

Re: [PATCH] use of grub_dprintf in grub_mm_init_region() is misleading

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > Using grub_dprintf() in grub_mm_init_region() easily leads to think that one > can activate this debug message by issuing `grub_env_set ("debug", "mem")' in > grub_machine_init(), before memory initialisation. > > However, that's completely false. grub_

Re: [PATCH] loader cleanup for i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > Some cleanup for i386-ieee1275. Can you please give a bit more information? > * include/grub/i386/ieee1275/loader.h: Include `', > `' and `'. > (grub_multiboot2_real_boot): New function prototype. > > * include/grub/i386/pc/memo

Re: [PATCH] loader cleanup for i386-ieee1275

2008-01-23 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 03:05:31PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > Some cleanup for i386-ieee1275. >> >> Can you please give a bit more information? >

Re: netboot/UNDI status

2008-01-23 Thread Marco Gerards
Douglas Ward <[EMAIL PROTECTED]> writes: > Robert Millan wrote: >> On Wed, Jan 23, 2008 at 12:38:31PM +0100, Marco Gerards wrote: >> >>> But to be honest, there are more important issues than networking in >>> the short term... >>> >>

Re: netboot/UNDI status

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 23, 2008 11:46 PM, Douglas Ward <[EMAIL PROTECTED]> wrote: >> Robert Millan wrote: >> > On Wed, Jan 23, 2008 at 12:38:31PM +0100, Marco Gerards wrote: >> > >> >> But to be honest, there are more impor

Re: [PATCH] memdisk + grub-mkrescue

2008-01-23 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > Quoting Robert Millan <[EMAIL PROTECTED]>: > >> On Wed, Jan 23, 2008 at 02:51:00AM -0500, Pavel Roskin wrote: >>> >>> I think I'll submit a patch that introduces the gap between the core >>> end and the modules. It's better that nothing. There was a gap

Re: UFS (FFS) support seems broken in grub2

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 24, 2008 12:15 AM, walt <[EMAIL PROTECTED]> wrote: >> Bean wrote: >> > This patch should fix the problem... >> >> Yes, thanks! I had to use the -l flag before patch would use it, >> and even then the last hunk needed increased fuzz. >> >> Are you going to

Re: hfs breakage

2008-01-23 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: [...] >> Yes, it seems so to me at least. I was talking about my code :-) > > ok then, i just revert to the original code. however, there is still a > small bug in grub_hfs_find_node. please see the new patch below. No need to revert it, you improved it! >> >>

Re: [PATCH] PNG image reader

2008-01-24 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> > static grub_uint32_t >> > grub_png_get_dword (struct grub_png_data *data) >> > { >> > grub_uint32_t r; >> > >> > r = 0

Re: UFS (FFS) support seems broken in grub2

2008-01-24 Thread Marco Gerards
walt <[EMAIL PROTECTED]> writes: > Bean wrote: >> On Jan 24, 2008 12:15 AM, walt<[EMAIL PROTECTED]> wrote: >>> Bean wrote: This patch should fix the problem... >>> Yes, thanks! I had to use the -l flag before patch would use it, >>> and even then the last hunk needed increased fuzz. >>> >>>

Re: menu's "default=saved" is need for hibernation on multi-os systems.

2008-01-24 Thread Marco Gerards
Franklin PIAT <[EMAIL PROTECTED]> writes: Hi, > Grub2 doesn't seems to have a feature similar to grub1 "default=saved" > in menu.lst, does it ? Not yet, but we want it. Do you want to work on this? -- Marco ___ Grub-devel mailing list Grub-devel@g

Re: [PATCH] use at_keyboard.c on i386-ieee1275

2008-01-24 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Wednesday 23 January 2008 12:32, Marco Gerards wrote: >> > Which reminds me, is 1.96 coming soon? When lvm/raid, reiserfs and >> > powerpc issues are fixed, it might be a good time. What do you think

Re: grub2 efi patches

2008-01-24 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Wednesday 23 January 2008 12:44, Robert Millan wrote: >> On Wed, Jan 23, 2008 at 12:39:35PM +0100, Marco Gerards wrote: >> > Alexandre Boeglin <[EMAIL PROTECTED]> writes: >> > > O

Re: adding some more members

2008-01-24 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: [...] >> Not at all. Christian can be added to as far as I am concerned. >> Would you mind? > > You know, I like to give write access to everybody, whenever legally > allowed. ;) Yeah, I know I am way more conservative as a maintainer than you a

Re: menu's "default=saved" is need for hibernation on multi-os systems.

2008-01-24 Thread Marco Gerards
Franklin PIAT <[EMAIL PROTECTED]> writes: Hi, > On Thu, 2008-01-24 at 09:35 +0100, Marco Gerards wrote: >> Franklin PIAT <[EMAIL PROTECTED]> writes: >> > Grub2 doesn't seems to have a feature similar to grub1 "default=saved" >> > in menu.

Re: grub manpages...

2008-01-24 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote: >> Hello, >> >> I've started more manpages : >> http://wiki.debian.org/Grub/grub-install.manpage >> http://wiki.debian.org/Grub/grub-mkimage.manpage >> http://wiki.debian.org/Grub/grub-mkres

Re: grub disk-image builder.

2008-01-24 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Wed, Jan 23, 2008 at 10:33:24PM +0100, Franklin PIAT wrote: >> Hello, >> >> For my personal needs, i've written a script to build floppy or >> hard-disk images. >> >> It's very similar to mkgrub-rescue.sh (and slightly based on it), >> except the im

Re: grub_dl_unload_all()

2008-01-24 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 24, 2008 at 09:57:45AM +0100, Yoshinori K. Okuji wrote: >> > How important is it to unload all modules? What do you suggest? Do we fix >> > everything to unload all modules (is that even possible?)? Do we unload >> > all modules on i386-pc

Re: grub manpages...

2008-01-24 Thread Marco Gerards
"Franklin PIAT" <[EMAIL PROTECTED]> writes: > On Thu, January 24, 2008 10:05, Yoshinori K. Okuji wrote: >> On Wednesday 23 January 2008 23:27, Robert Millan wrote: >>> On Wed, Jan 23, 2008 at 10:50:50PM +0100, Franklin PIAT wrote: >>> > Hello, >>> > >>> > I've started more manpages : > [..] >>> >

Re: [PATCH] PNG image reader

2008-01-24 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 24, 2008 4:29 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> Bean <[EMAIL PROTECTED]> writes: >> >> > On Jan 23, 2008 6:36 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> >> > static grub_

Re: [PATCH] use at_keyboard.c on i386-ieee1275

2008-01-24 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 24, 2008 at 09:40:31AM +0100, Yoshinori K. Okuji wrote: >> >> All I need is ping from Robert. My preference is to publish a new version >> regularly, no matter whatever bugs remain (yeah, I am very aggressive in >> GRUB >> 2), but he stop

Re: Incomplete file listing with reiserfs partition

2008-01-24 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 24, 2008 2:30 AM, Antoine Cellerier <[EMAIL PROTECTED]> wrote: >> Hello, >> >> I've been trying to use grub2 with a reiserfs partition and noticed that >> it couldn't find all my files and folders. nyu and marco_g on IRC >> suggested that I send a small te

Re: [PATCH] memdisk plus lnxboot extension

2008-01-24 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Jan 25, 2008 at 01:04:34AM +0800, Bean wrote: >> On Jan 25, 2008 12:55 AM, Robert Millan <[EMAIL PROTECTED]> wrote: >> > On Thu, Jan 24, 2008 at 03:25:51PM +0100, Robert Millan wrote: >> > > >> > > You want to add a feature that only works when y

Re: UFS (FFS) support seems broken in grub2

2008-01-24 Thread Marco Gerards
walt <[EMAIL PROTECTED]> writes: > Marco Gerards wrote: >> walt<[EMAIL PROTECTED]> writes: >> > ... >>> I recompiled my NetBSD kernel with the MULTIBOOT option enabled, but >>> I still get a 'magic broken' error when doing 'multi

Re: /kern/file.c BUG

2008-01-24 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: >> > Previous behavior was working correctly. You have to handle >> > errorcodes >> > at some point and that means when error is

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Pavel Roskin <[EMAIL PROTECTED]> writes: > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > >> Previous behavior was working correctly. You have to handle >> errorcodes >> at some point and that means when error is handled it is zeroed (or >> GRUB_ERR_NONE). So code is in callee whe

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote: >> On Thursday 24 January 2008 19:34, Pavel Roskin wrote: >> > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: >> > > Previous behavior was working correctly. You have to han

Re: /kern/file.c BUG

2008-01-25 Thread Marco Gerards
Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: (replying to this mail, I didn't receive the first mail over the list...) > Robert Millan wrote: >> On Wed, Jan 23, 2008 at 11:00:57PM +, Oleg Strikov wrote: >>> Incorrect behavior of grub_file_open () function in e.g. loop context: >>> >>> char *

Re: Grub-devel Digest, Vol 47, Issue 99

2008-01-25 Thread Marco Gerards
"Oleg Strikov" <[EMAIL PROTECTED]> writes: >> >> Previous behavior was working correctly. You have to handle >> >> errorcodes >> >> at some point and that means when error is handled it is zeroed (or >> >> GRUB_ERR_NONE). So code is in callee where that loop was. >> >> >I suggest that we never set

Re: [PATCH] use at_keyboard.c on i386-ieee1275

2008-01-25 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Thursday 24 January 2008 13:39, Robert Millan wrote: >> So perhaps it's a good idea to release 1.96 with known regressions after >> all. > > I think that would be a nicer approach at this stage. Anyway, nobody expects > that GRUB 2 is rock-sol

Re: netboot/UNDI status

2008-01-25 Thread Marco Gerards
"Yoshinori K. Okuji" <[EMAIL PROTECTED]> writes: > On Thursday 24 January 2008 13:42, Robert Millan wrote: >> Well, if we can collaborate by sharing the same driver collection that's >> even better, of course. This was done for GRUB Legacy, right? > > Sure. I had a very short conversation with gp

Re: [PATCH] PNG image reader

2008-01-25 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Jan 24, 2008 8:14 PM, Marco Gerards <[EMAIL PROTECTED]> wrote: >> It would be nice, not required. I don't expect too much problems >> here... >> >> Perhaps a better approach would be possible to do a check a

Re: /kern/file.c BUG

2008-01-26 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Jan 25, 2008 at 09:50:14AM +0100, Marco Gerards wrote: >> Vesa Jääskeläinen <[EMAIL PROTECTED]> writes: >> >> (replying to this mail, I didn't receive the first mail over the list...) >> >> &g

Re: booting kernel of NetBSD (Re: UFS (FFS) support seems broken in grub2)

2008-01-28 Thread Marco Gerards
Robert Millan <[EMAIL PROTECTED]> writes: > On Sat, Jan 26, 2008 at 01:24:57PM -0800, walt wrote: >> >> Yes! I just discovered that I can multiboot the netbsd kernel off >> of a FAT32 fs or even an NTFS fs, but *not* off of a UFS fs :o/ >> >> Apparently "something bad" happens to the kernel in

  1   2   3   4   5   6   7   8   9   10   >