[PATCH] tests: Disable sercon in SeaBIOS

SeaBIOS 1.11.0 added support for VGA emulation over a serial port, which interferes with grub-shell. Turn it off. Signed-off-by: Colin Watson --- tests/util/grub-shell.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in index

[PATCH] tests: Fix qemu options for UHCI test

qemu 2.12 removed the -usbdevice option. Use a more modern spelling instead, in line with other USB-related tests. Signed-off-by: Colin Watson --- tests/uhci_test.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/uhci_test.in b/tests/uhci_test.in index 4af72fd8f

Re: [PATCH v2 1/2] build: Capitalise *freetype_* variables

Please do - I must have forgotten. Thanks. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Cope with / being on a ZFS root dataset

ixes: https://savannah.gnu.org/bugs/?52746 Tested-by: Fejes József Signed-off-by: Colin Watson --- util/grub.d/10_linux.in | 2 +- util/grub.d/20_linux_xen.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index 61e

GRUB Xen PVH chainloading

org/grub-team/grub/blob/master/debian/patches/grub-install-pvxen-paths.patch) needs to be extended to support the amended protocol. This is trivial given the above. Thanks, -- Colin Watson [cjwat...@debian.org] __

[PATCH 0/1] Upgrade Gnulib; switch to bootstrap tool

LE is specified, -1 is returned. +@@ -90,6 +98,10 @@ mbsnwidth (const char *string, size_t nbytes, int flags) p++; width++; break; -+ case 

[PATCH] Fix emu build and tests after pgp module renaming

module. Fix both of these. Signed-off-by: Colin Watson --- grub-core/commands/pgp.c | 4 ++-- tests/file_filter_test.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/commands/pgp.c b/grub-core/commands/pgp.c index 0487479af..d39846d8c 100644 --- a/grub-core

[PATCH] Fix syslinux_test in out-of-tree builds

tution requires some awkwardness in Makefile.am due to details of how config.status works. Signed-off-by: Colin Watson --- Makefile.am| 7 ++- tests/syslinux/ubuntu10.04_grub.cfg.in | 20 ++-- 2 files changed, 16 insertions(+), 11 deletions(-) diff -

Re: bash completions in GRUB

e amount of code that bash has to read). Finally, for proper upstreaming I think the target directory ought to be settable at ./configure time. https://salsa.debian.org/grub-team/grub/commit/48dbe1e38f23022211f347bd479de6036f622a3f -- Colin Watson

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

There's an "Error Handling" section in docs/grub-dev.texi. Does anything there help? -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 0/1] Fix partition offset for EBR partitions on FreeBSD

Here's a patch from James Clarke to fix a FreeBSD partition calculation bug, originally sent to https://bugs.debian.org/923253; I've only reformatted the commit message slightly. James Clarke (1): Fix partition offset for EBR partitions on FreeBSD grub-core/osdep/freebsd/getroot.c | 5 +++-- 1

Re: [PATCH 0/1] Fix partition offset for EBR partitions on FreeBSD

On Tue, Feb 26, 2019 at 03:12:06PM +, Colin Watson wrote: > Here's a patch from James Clarke to fix a FreeBSD partition calculation > bug, originally sent to https://bugs.debian.org/923253; I've only > reformatted the commit message slightly. I botched the commit message

[PATCH v2 0/1] osdep/freebsd: Fix partition calculation for EBR entries

Here's a patch from James Clarke to fix a FreeBSD partition calculation bug, originally sent to https://bugs.debian.org/923253; I've only reformatted the commit message slightly. On FreeBSD, grub uses the "start" rather than the "offset" config property to calculate the starting sector for partiti

[PATCH] util: Detect more I/O errors

Many of GRUB's utilities don't check anywhere near all the possible write errors. For example, if grub-install runs out of space when copying a file, it won't notice. There were missing checks for the return values of write, fflush, fsync, and close (or the equivalents on other OSes), all of whic

Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool

r. I hope this will encourage people who know about the other bits of external code that GRUB imports to add corresponding sections there. I'll send a v2. Thanks, -- Colin Watson [cjwat...@ubuntu.com] ___ Gr

[PATCH v2 0/1] Upgrade Gnulib; switch to bootstrap tool

I have a bug report that I think is best handled by importing and using a new module from Gnulib, so I tried to do that. Unfortunately GRUB's Gnulib import is in a confusing state that makes it difficult to do this. The last full update was in 2013, without documentation of the exact commit that

Re: [PATCH] Fix syslinux_test in out-of-tree builds

On Mon, Jan 14, 2019 at 02:15:14PM +0100, Daniel Kiper wrote: > On Wed, Jan 09, 2019 at 02:59:12PM +0000, Colin Watson wrote: > > +# Mimic simplify_filename from grub-core/lib/syslinux_parse.c, so that we > > OK, but I would like to see a comment before

[PATCH v2] Fix syslinux_test in out-of-tree builds

tution requires some awkwardness in Makefile.am due to details of how config.status works. Signed-off-by: Colin Watson --- Makefile.am| 7 ++- grub-core/lib/syslinux_parse.c | 3 +++ tests/syslinux/ubuntu10.04_grub.cfg.in | 20 ++-- 3 files ch

Re: [PATCH] util: Detect more I/O errors

On Wed, Feb 27, 2019 at 09:10:08AM +, Colin Watson wrote: > Many of GRUB's utilities don't check anywhere near all the possible > write errors. For example, if grub-install runs out of space when > copying a file, it won't notice. There were missing checks for the

Re: [PATCH] util: Detect more I/O errors

On Thu, Feb 28, 2019 at 04:32:44PM +, Elliott, Robert (Persistent Memory) wrote: > > -Original Message- > > From: Grub-devel On > > Behalf Of Colin Watson > ... > > -void > > +int > > grub_util_file_sync (FILE *f) > > { > > - fflu

Re: [PATCH v2 1/1] Upgrade Gnulib; switch to bootstrap tool

On Fri, Mar 01, 2019 at 01:07:26PM +0100, Daniel Kiper wrote: > But you forgot to update Autoconf and Automake required version in INSTALL > file. If it is not a problem for you I will update it before pushing > this patch. Ah yes, good catch. Yes, of course, please do. -- Col

Rules for committers? (was Re: [PATCH v2] Fix syslinux_test in out-of-tree builds)

On Fri, Mar 01, 2019 at 12:52:37PM +0100, Daniel Kiper wrote: > On Wed, Feb 27, 2019 at 10:26:30AM +0000, Colin Watson wrote: > > Signed-off-by: Colin Watson > > Reviewed-by: Daniel Kiper This reminds me: as somebody who has direct GRUB commit access but hasn't used it muc

[PATCH] Save/restore CWD more reliably on Unix

0. Signed-off-by: Colin Watson --- bootstrap.conf | 1 + grub-core/osdep/unix/getroot.c | 26 +- 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index 6781d25a7..988dda099 100644 --- a/bootstrap.conf +++ b/boot

[PATCH 1/2] Add %X to grub_vsnprintf_real and friends

This is needed for UEFI Boot* variables, which the standard says are named using upper-case hexadecimal. --- grub-core/kern/misc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c index 3b633d51f..73f8e0e9e 100644 --- a/gr

Re: [PATCH 0/2] Minimise writes to EFI variable storage

Oops, please ignore me failing to drive my email client correctly. Corrected subject line here ... -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman

[PATCH 0/2] *** SUBJECT HERE ***

try exists. This short patch series does so by using the efivar and efiboot libraries directly. Colin Watson (2): Add %X to grub_vsnprintf_real and friends Minimise writes to EFI variable storage INSTALL | 5 + Makefile.util.def | 20 ++ co

[PATCH 2/2] Minimise writes to EFI variable storage

ontents are the same as the old contents. In the common upgrade case where nothing needs to change, it no longer writes to NVRAM at all. It's also now slightly faster, since using libefivar is faster than forking efibootmgr. Fixes Debian bug #891434. Signed-off-by: Colin Watson --- INSTALL

Re: [PATCH 1/2] Add %X to grub_vsnprintf_real and friends

On Tue, Mar 12, 2019 at 01:19:09PM +0100, Daniel Kiper wrote: > On Mon, Mar 11, 2019 at 03:05:19PM +0000, Colin Watson wrote: > > This is needed for UEFI Boot* variables, which the standard says are > > named using upper-case hexadecimal. > > Missing SOB. I assume that I

Re: [PATCH 0/2] *** SUBJECT HERE ***

Yep - I'll deal with those soon and post a v2. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Flesh out posix_wrap/limits.h a little more

In addition to what was already there, Gnulib's needs SCHAR_MIN, SCHAR_MAX, SHRT_MIN, INT_MIN, LONG_MIN, and LONG_MAX. Fixes build on CentOS 7. Reported-by: "Chen, Farrah" Signed-off-by: Colin Watson --- grub-core/lib/posix_wrap/limits.h | 6 ++ include/grub/types.h

Re: i386 emu build is broken

v.texi explains what to do when you need to upgrade that. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v2 0/2] Minimise writes to EFI variable storage

try exists. This short patch series does so by using the efivar and efiboot libraries directly. v2: simplify grub_lltoa; use free_efi_variable in more error paths Colin Watson (2): Add %X to grub_vsnprintf_real and friends Minimise writes to EFI variable storage INSTALL

Re: [PATCH] kern/emu/misc.c: Don't include config-util.h when running as GRUB_BUILD

Ah, this explains some strangeness I was seeing. Thanks. Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo

Re: [PATCH] POTFILES: Don't include gnulib in grub.pot

(Missing Signed-off-by.) Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Rename grub_disk members

; [...] > /* Write SIZE sectors from BUF into the sector SECTOR of the disk DISK. */ > - grub_err_t (*write) (struct grub_disk *disk, grub_disk_addr_t sector, > + grub_err_t (*disk_write) (struct grub_disk *disk, grub_disk_addr_t sector, > grub_size_t size, const char *buf); And here. Otherwise LGTM, so: Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v2 2/2] Minimise writes to EFI variable storage

ontents are the same as the old contents. In the common upgrade case where nothing needs to change, it no longer writes to NVRAM at all. It's also now slightly faster, since using libefivar is faster than forking efibootmgr. Fixes Debian bug #891434. Signed-off-by: Colin Watson --- INSTALL

Re: [PATCH 2/2] Minimise writes to EFI variable storage

On Wed, Mar 13, 2019 at 01:07:20AM +, Steve McIntyre wrote: > On Mon, Mar 11, 2019 at 03:05:46PM +0000, Colin Watson wrote: > >+/* Boot option attributes. */ > >+#define LOAD_OPTION_ACTIVE 0x0001 > >+ > >+/* GUIDs. */ > >+#define BLKX_UNKNOWN_GUID \ &

[PATCH v2 1/2] Add %X to grub_vsnprintf_real and friends

This is needed for UEFI Boot* variables, which the standard says are named using upper-case hexadecimal. Signed-off-by: Colin Watson --- grub-core/kern/misc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c index 3b633d51f

Re: [PATCH v2 2/2] Minimise writes to EFI variable storage

On Fri, Mar 22, 2019 at 11:31:18PM +, Colin Watson wrote: > grub-install now reuses existing boot entries where possible, and avoids > writing to variables when the new contents are the same as the old > contents. In the common upgrade case where nothing needs to change, it > no l

[PATCH v3 0/2] Minimise writes to EFI variable storage

try exists. This short patch series does so by using the efivar and efiboot libraries directly. v2: simplify grub_lltoa; use free_efi_variable in more error paths v3: avoid -Wcast-align diagnostics on ARM Colin Watson (2): Add %X to grub_vsnprintf_real and friends Minimise writes to EF

[PATCH v3 2/2] Minimise writes to EFI variable storage

ontents are the same as the old contents. In the common upgrade case where nothing needs to change, it no longer writes to NVRAM at all. It's also now slightly faster, since using libefivar is faster than forking efibootmgr. Fixes Debian bug #891434. Signed-off-by: Colin Watson --- INSTALL

[PATCH v3 1/2] Add %X to grub_vsnprintf_real and friends

This is needed for UEFI Boot* variables, which the standard says are named using upper-case hexadecimal. Signed-off-by: Colin Watson --- grub-core/kern/misc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c index 3b633d51f

Re: Build fails with missing save-cwd.h header

to change your habits to run ./bootstrap instead of ./autogen.sh as of a few weeks ago. See: https://git.savannah.gnu.org/cgit/grub.git/commit/?id=35b909062e7b334eb4af372be3260d0f62d85375 -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot

intained copies of the bits of Gnulib that GRUB actually uses, as opposed to the clone of all of Gnulib that lives in the gnulib/ directory. It shouldn't end up in POTFILES; so I think Daniel's point is that you should exclude both gnulib/ and grub-core/lib/gnulib/ in your patch. --

Re: GRUB version numbering.

but I don't think it would be a good choice for us.) -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devname

with a NULL pointer. Makes sense to me, and the handling matches how the immediately-following possible grub_malloc failure is handled. Reviewed-by: Colin Watson -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-d

Re: GRUB fails to load kernel on linux-sparc64

of them but not all. > More generally will distributors be able get rid of the patches they apply? Same answer. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: GRUB fails to load kernel on linux-sparc64

compressed kernels on sparc64. I wonder whether we have > a local modification that makes this possible. I'm not aware of anything specific; I think if it works it'll be a matter of divergence between patch sets rather than an explicit patch to make it work, if you see what I

Re: [RFC 1/1] mkimage: revert "Align efi sections on 4k boundary"

figure out a better approach, making the value architecture-specific using #ifdef or similar would be more constructive. (However, hopefully somebody with more domain expertise than me can actually track down the problem properly.) -- Colin Watson [cjwat...@ubuntu

Re: grub.git fails to compiler after gnulib upgrade due to gettext

100644 --- a/configure.ac +++ b/configure.ac @@ -362,7 +362,7 @@ AC_CHECK_PROG(HAVE_CXX, $CXX, yes, no) AC_GNU_SOURCE AM_GNU_GETTEXT([external]) -AM_GNU_GETTEXT_VERSION([0.18.3]) +AM_GNU_GETTEXT_VERSION([0.17]) AC_SYS_LARGEFILE # Identify characteristics

Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG

}" That way, people who want details can set OS_PROBER_DISABLE_DEBUG= (i.e. empty) when running grub-mkconfig, or we could add a --debug option or something; but otherwise debug output will be suppressed, which seems like a better default for grub-mkconfig. -- Colin Watson

Re: grub-mkconfig - pick local defaults from /etc/default/grub.local

eds to be consistent with it for grub-install. However, just supporting a single extra file isn't as helpful as it could be. I've attached the Debian patch that supports /etc/default/grub.d/*.cfg. -- Colin Watson [cjwat...@debian.org] >From 413

Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG

On Tue, Jul 16, 2019 at 07:28:32AM +, Michael Chang wrote: > What about changing the os-prober default to disable the debug output ? I haven't thought about it in detail, but that seems reasonable enough. Could you file a bug report against os-prober in Debian? -- Coli

Re: Grub2.02 installed with Pythin 3, boots Xen Dom0 but not Xen DomU-s

On Sun, Jul 21, 2019 at 03:23:03PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Pygrub is not part of grub project. Indeed. I'd also recommend using GRUB's Xen platform instead of pygrub if you can: https://wiki.xen.org/wiki/Pv

[PATCH] grub-mkconfig: Fix typo in --help output

The short form of "--version" that grub-mkconfig accepts is "-V", not "-v". Fixes Debian bug #935504. Signed-off-by: Colin Watson --- util/grub-mkconfig.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub-mkconfig.in b/util/gr

[PATCH] Restore patches to po/Makefile.in.in

000..5a5d1ec00 --- /dev/null +++ b/po/gettext-patches/0001-Support-POTFILES-shell.patch @@ -0,0 +1,54 @@ +From d5bbd8f60aacb0f73ea5a0bde999152c467d0e78 Mon Sep 17 00:00:00 2001 +From: Colin Watson +Date: Sun, 1 Mar 2020 11:57:58 + +Subject: [PATCH 1/4] Support POTFILES-shell + +---

Re: [PATCHv2] grub-install: Add backup and restore

; remove the backup if everything was successful. If on_exit is not > available, the backup remains on disk for manual recovery. Reviewed-by: Colin Watson -- Colin Watson (he/him) [cjwat...@debian.org] ___ Grub-devel ma

Re: [SECURITY PATCH 001/117] verifiers: Move verifiers API to kernel image

registers it at kernel startup, depending on the platform. It wouldn't be especially pretty, but I think we could tolerate that for the sake of fixing this regression. Thanks, -- Colin Watson (he/him) [cjwat...@debian.org] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [SECURITY PATCH 114/117] kern/misc: Add function to check printf() format against expected format

h limited space between the MBR and the first partition; a plausible RAID setup used by some Debian users is currently 316 bytes over the limit, so reclaiming this space would be valuable. Reclaiming all of those 273 bytes would probably involve duplicating parse_printf_arg_fmt rathe

Re: [PATCH] i386-pc: build verifiers API as module

somewhere in the actual code, anyway, I don't mind where) would be useful so that people trying to work out what's going on don't have to hunt through commit logs to find out. If these minor comments are fixed: Reviewed-by: Colin Watson -- Colin Watson (he/him)

Re: [PATCH v5 2/2] Document new limitations on MBR gap support

f course be that they turn out to be unfixable, but the difficulty of repairing a system in this state means that we should have a very high bar for giving up. -- Colin Watson (he/him) [cjwat...@debian.org] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] buffer: Sync up out-of-range error message

age (biosdisk ext2 part_msdos) (27453 > 27452) - change: -1 DOWN: i386-pc core image (biosdisk ext2 part_msdos diskfilter mdraid09) (32367 > 32359) - change: -8 Signed-off-by: Colin Watson --- include/grub/buffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc

[PATCH] kern/misc: Move grub_printf_fmt_check to gfxmenu

ore/gfxmenu.mod (39816 < 40216) - change: 400 DOWN: i386-pc core image (biosdisk ext2 part_msdos) (27453 > 27351) - change: -102 DOWN: i386-pc core image (biosdisk ext2 part_msdos diskfilter mdraid09) (32367 > 32259) - change: -108 Signed-off-by: Colin Watson --- grub-core/gfxmenu/gui_s

[PATCH] kern/dl: Disable grub_dl_unload_unneeded

-23 DOWN: i386-pc core image (biosdisk ext2 part_msdos diskfilter mdraid09) (32367 > 32334) - change: -33 DOWN: i386-pc core image (biosdisk ext2 part_msdos lvm mdraid1x) (35595 > 35594) - change: -1 Signed-off-by: Colin Watson --- grub-core/kern/dl.c | 2 ++ grub-core/kern/mm.c | 2 +-

Re: [PATCH v2] i386-pc: build verifiers API as module

re pretty clear we do not support advanced configs > with small MBR gaps any longer. Yes. As I recently posted to the list, I do not think this should be used as an excuse not to fix problems where it is relatively straightforward to do so. -- Colin Watson (he/him)

Re: [PATCH v2] i386-pc: build verifiers API as module

On Mon, Mar 22, 2021 at 04:16:26PM +, Colin Watson wrote: > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > NAK for this patch and others "fixing" small MBR gaps. I am not going to > > deal with this kind of issues any longer because a few folks in th

Re: [PATCH v2] i386-pc: build verifiers API as module

On Mon, Mar 22, 2021 at 03:19:06PM -0500, Glenn Washburn wrote: > On Mon, 22 Mar 2021 16:16:26 + > Colin Watson wrote: > > On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote: > > > NAK for this patch and others "fixing" small MBR gaps. I am not > &

Re: [PATCH v2] i386-pc: build verifiers API as module

f regressions to be a distro problem, with a mere handful of months of notice in the form of a documentation change in an unreleased version before (no doubt unintentionally) landing patches that break some of the systems in question, and not expect at least some pushback about that. Finally, I

Re: [PATCH v2] i386-pc: build verifiers API as module

ly help to some extent, although I can't say how much. (That said: for various reasons my available time to contribute to GRUB has been pretty low for some years anyway, particularly since it stopped being something I did on work time, and Debian would probably be served better by a mo

[PATCH] minilzo: Update to minilzo-2.10

e documented in the GRUB Developers Manual worked; I just updated the version numbers to make it clear that it's been executed recently. Signed-off-by: Colin Watson --- docs/grub-dev.texi | 10 +- grub-core/lib/minilzo/lzoconf.h | 41 ++- grub-cor

Re: Where in GRUB2 source code is the handover/jump to kernel code on x86?

ants to boot. The final bit is: .byte 0xea VARIABLE(grub_relocator32_eip) .long 0 This is a JMP opcode followed by space into which the relocator fills in an instruction pointer. When that's put together, it forms the line of code you're looking for. -- Colin Watson

Re: Development practices?

ned some form >of 'implicit-Signed-off-by-when-I-check-in' document? As far as I know S-O-B has never been standard in GRUB. It's a practice that many people who are familiar with Linux kernel development follow, and so it ends up in our commit logs, but that doesn't

Re: Grub2 documentation of the GRUB_CMDLINE_*XEN* parameters -- unclear. What's _intended_?

s should clearly address which PARAMETERS map to the "options=" line, > and which to the kernel=" line in the Xen case. No doubt, but it is up to the openSUSE maintainers to make sure that their patches also include appropriate documentation changes. -- Colin Watson

[PATCH] arm64: build with -mcmodel=large

y to do any run-time tests. Colin Watson (1): arm64: build with -mcmodel=large configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.6.4 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] arm64: build with -mcmodel=large

This matches some other 64-bit architectures, and fixes a build failure with current GCC versions: when using the default (small) memory model, they generate relocations that grub-mkimage doesn't understand. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/confi

Re: [PATCH] arm64: build with -mcmodel=large

On Thu, Dec 24, 2015 at 04:14:20AM +, Colin Watson wrote: > This fixes a build failure with very current GCC versions, such as the one > in Ubuntu xenial. Leif (or anyone with suitable arm64 systems), would you > mind testing that this doesn't break things? I've te

Re: [PATCH] arm64: build with -mcmodel=large

on support is added?), but I'm mentioning it here in case any other distributors have the same problem. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] syslinux_test: Fix out-of-tree build handling

When doing out-of-tree builds, abs_top_srcdir may well contain ".." segments, and grub-syslinux2cfg canonicalises its --root argument. As a result, the expansion of @abs_top_srcdir@ may not match what grub-syslinux2cfg produces. It's somewhat difficult to portably canonicalize a path in shell, an

Re: [PATCH] syslinux_test: Fix out-of-tree build handling

vious patch is the simplest approach. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Xen and all_video.mod

ls that aren't built for Xen at the moment. What's the best answer here? Is there some reasonable way to weaken this test so that this module is allowed to be useless on this platform? Thanks, -- Colin Watson

Re: "Illegal Instruction" error in grub_script_comments

x27;t be cured by a compiler option. GRUB is mostly in C, but something running at the level of a boot loader does tend to need at least a little bit of assembly to get itself going. -- Colin Watson [cjwat...@ubuntu.com] __

Re: [PATCH] Add fwconfig command

modifying it whether they do so under the terms of version 3 or of some later version. Matthew is not required to pick one. Also: $ git grep 'at your option' | wc -l 1412 -- Colin Watson [cjwat...@ubuntu.com]

Re: [PATCH] Add fwconfig command

On Tue, Jan 24, 2017 at 11:40:57AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 24, 2017 at 04:36:03PM +0000, Colin Watson wrote: > > This language indicates that it's at the option of the person > > redistributing or modifying it whether they do so under the terms of >

Re: kernel build still pulls in host includes even with -nostdinc

. I don't think we want > to reimplement those Yeah, I'd say that that include directory is really part of the compiler rather than part of the host system as such. -- Colin Watson [cjwat...@ubuntu.com] __

[wea...@debian.org: Bug#858832: calls efibootmgr with invalid options]

re a guess at suitable replacement code that would work on devices other than biosdisk? Thanks, -- Colin Watson [cjwat...@debian.org] --- Begin Message --- Package: grub-efi-arm64 Version: 2.02~beta3-5 Severity: serious User: debian-ad...@lists.debian.org Use

Re: Possible regression in e2fsprogs-1.43.4 [RESOLVED]

0 stopped working with the upgrade to 1.43.4, > but GRUB 2.02 works fine. Yes - I think this is to be expected since support for the 64-bit feature was only added in 2.02. (See the NEWS file, or commit 073b57bb8e2d688f33198f97076d01cea4455d7f.) -- Colin Watson

[tuellm...@kit.edu: Bug#866603: grub-common: enabling metadata_csum_seed feature on ext4 renders system unbootable]

Hi, Could we possibly just ignore this feature for GRUB? For better or worse we don't implement metadata checksumming, and we're only doing read-only access, so I think it would be reasonably safe to ignore metadata_csum_seed since we wouldn't do anything with it anyway. Tha

Re: [tuellm...@kit.edu: Bug#866603: grub-common: enabling metadata_csum_seed feature on ext4 renders system unbootable]

On Fri, Jun 30, 2017 at 12:43:02PM +, Vladimir 'phcoder' Serbinenko wrote: > пт, 30 июн. 2017 г., 14:38 Colin Watson : > > Could we possibly just ignore this feature for GRUB? For better or > > worse we don't implement metadata checksumming, and we're on

Re: R: Re: CAN GRUB DO WRITING OPERATIONS ON ATTACHED DRIVES ?

hat's attached to a machine, although save_env might write to the device it believes holds /boot/grub/grubenv. The low-level disk handling code is in grub-core/disk/. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: R: Re: R: Re: CAN GRUB DO WRITING OPERATIONS ON ATTACHED DRIVES ?

confirm if this my conclusion is right ? Because is this > the crucial question i need to solve. I would never want to rule out the possibility of strange bugs, but that is certainly the design. -- Colin Watson [cjwat...@ubuntu.com] _

Re: R: Re: R: Re: R: Re: CAN BIOS/UEFI DO WRITING OPERATIONS ON ATTACHED DRIVES BY MEANS OF INT 13 H INTERRUPT ?

#x27;s running in protected mode, but it's possible that there are some edge cases where this isn't true. You'd need to find an actual kernel developer to be authoritative about this, though. -- Colin Watson [cjwat...@ubuntu.com] ___

Re: grub installer question

ought to first establish why you need to do this, as it should generally be unnecessary. -- Colin Watson [cjwat...@ubuntu.com] ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: ZFS boot environment patch

s="`zpool list -H -o bootfs ${rpool} || true`" > > Is zpool usually in /sbin or such? Perhaps a full path? Full paths are brittle when they refer to something installed by a different package. If you need to do that kind of thing then it's usually bette

Re: ZFS boot environment patch

On Thu, Sep 14, 2017 at 09:22:01PM +0200, Paul Lagerweij wrote: > On Wed, 13 Sep 2017 at 09:17:42PM +0100, Colin Watson wrote: > > > On Wed, Sep 13, 2017 at 11:02:48AM -0400, Konrad Rzeszutek Wilk wrote: > > > > @@ -62,9 +63,15 @@ case x"$GRUB_FS" in > > &

[PATCH] build: Use pkg-config to find Freetype

: Hugh McMaster Signed-off-by: Colin Watson --- INSTALL | 9 --- Makefile.am | 6 ++--- Makefile.util.def | 4 +-- configure.ac | 74 +++ 4 files changed, 41 insertions(+), 52 deletions(-) diff --git a/INSTALL b

Re: [PATCH] build: Use pkg-config to find Freetype

On Mon, Jan 29, 2018 at 06:35:11PM +0100, Daniel Kiper wrote: > On Thu, Jan 25, 2018 at 12:23:58PM +0000, Colin Watson wrote: > > @@ -1542,8 +1539,6 @@ else > > enable_grub_mkfont=no > > fi > > AC_SUBST([enable_grub_mkfont]) > > -AC_SUBST([freetype_cfla

[PATCH v2 2/2] build: Use pkg-config to find FreeType

substitute FREETYPE_CFLAGS and FREETYPE_LIBS, since PKG_CHECK_MODULES does that automatically. Fixes Debian bug #887721. Reported-by: Hugh McMaster Signed-off-by: Colin Watson --- INSTALL | 11 + configure.ac | 74 +--- 2 files

[PATCH v2 1/2] build: Capitalise *freetype_* variables

Using FREETYPE_CFLAGS and FREETYPE_LIBS is more in line with the naming scheme used by pkg-config macros. --- Makefile.am | 6 +++--- Makefile.util.def | 4 ++-- configure.ac | 24 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/Makefile.am b/

Re: [PATCH] build: Use pkg-config to find Freetype

On Tue, Jan 30, 2018 at 09:57:15PM +, Colin Watson wrote: > Thanks for your other comments; I'll follow up in a moment with > corrected patches. Has anyone had a chance to review these? I'd be happy to deal with actually committing them if they look OK.

[PATCH] libgcrypt: Import replacement CRC operations

). I've tested that "hashsum -h crc32" still produces correct output for a variety of files on both i386-pc and x86_64-emu targets. Signed-off-by: Colin Watson --- grub-core/lib/libgcrypt/cipher/bufhelp.h | 432 grub-core/lib/libgcrypt/cipher/crc.c | 817 +

  1   2   3   4   5   6   7   8   >