On Wed, Mar 13, 2019 at 01:07:20AM +0000, Steve McIntyre wrote: > On Mon, Mar 11, 2019 at 03:05:46PM +0000, Colin Watson wrote: > >+/* Boot option attributes. */ > >+#define LOAD_OPTION_ACTIVE 0x00000001 > >+ > >+/* GUIDs. */ > >+#define BLKX_UNKNOWN_GUID \ > >+ EFI_GUID (0x47c7b225, 0xc42a, 0x11d2, 0x8e57, 0x00, 0xa0, 0xc9, 0x69, \ > >+ 0x72, 0x3b) > > Ugh. I'm assuming the mahic numbers here are not exposed usefully by > efivar or efiboot?
Sadly not, as far as I can see. > So new_efi_variable() is using xmalloc() so it's safe if the > allocation fails. But what happens if efi_get_variable() fails - do > you need to free all the members by calling free_efi_variable() rather > than simply free() here? Quite right, and there was a similar bug in another place. I'll send a v2 fixing this and your comment about my grub_lltoa change. Thanks, -- Colin Watson [cjwat...@ubuntu.com] _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
