On Fri, Jun 19, 2009 at 01:53:18PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Fri, Jun 19, 2009 at 8:08 AM, Peter Cros wrote:
>
> > Hi again,
> >
> > Could the hfspbless patch be updated and hopefully committted to provide
> > the hfspbless module as standard in grub2.
> >
> Attached to th
On Fri, Jun 19, 2009 at 12:42:26PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Fri, Jun 19, 2009 at 12:37 PM, Robert Millan wrote:
>
> > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote:
> > > > > -Copy ca.mo to /usr/share/locale/ca/LC_MESSAGES/grub.mo
> > > >
> >
On Sat, Jun 20, 2009 at 12:08:44AM +0100, Carles Pina i Estany wrote:
>
> a) I afraid that having the .mo files in /usr/share/... makes Grub
> quite much tight to GNU/Linux. In my opinion, boot loaders should be as
> much as operating system agnostic as could be.
Sounds like a good point. I don
On Fri, Jun 19, 2009 at 04:32:35PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > - lose, and get the C locale messages
> > - try to set it up using the correct grub device that contains the
> > locales.
>
> What if partition is in btrfs?
Well, now I think using $prefix/locale is not that bad.
Committed, as this is small enough not to be copyright-significant.
Btw, Colin please use inline attachments in the future. It makes it
easier to manage.
On Wed, Jun 17, 2009 at 12:23:23PM +0100, Colin Watson wrote:
> This patch fixes
> https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/19020
On Fri, Jun 19, 2009 at 12:37:20PM -0400, Pavel Roskin wrote:
> Hello!
>
> In order to encourage developers to use proper indentation on the newly
> added code, I suggest that we accept the default style of GNU indent.
> That is, the space after "!" should not be needed. That's the only
> differe
Hi,
I've added a few function in the lua grub library to access files:
enum_device - enumerate devices
enum_file - enumerate files
file_open - open file
file_close - close file
file_seek - seek file
file_read - read n bytes
file_getline - read a line
file_getsize - get file size
file_getpos - get
On Fri, Jun 19, 2009 at 11:46:06AM -0400, Pavel Roskin wrote:
>
> Generally, please think how to reduce complexity, not how to add to it.
> Complex systems are harder to maintain.
In general, I completely agree with this.
However grub-emu has very special requirements that could make it desireab
> In order to encourage developers to use proper indentation on the
> newly added code, I suggest that we accept the default style of
> GNU indent. That is, the space after "!" should not be needed.
> That's the only difference I'm aware of.
What does GCS say about spaces after "!"
> Anyway, given that grub-emu is a debugging/development tool, I'm not sure
> it's that useful to export those flags to autoconf. We could just live
> with #ifdefs in the code IMHO. Distributors are going to ship whatever we
> choose as default for grub-emu anyway.
>
Actually the problem isn't gr
Committed
On Sat, Jun 13, 2009 at 12:23 PM, Vladimir 'phcoder' Serbinenko <
phco...@gmail.com> wrote:
> Hello
>
> On Fri, Jun 12, 2009 at 8:14 PM, Vladimir 'phcoder'
> Serbinenko wrote:
> > Hello. Unlike some other types of modules (mfsroot, splash, ..)
> > FreeBSD relies on ELF modules being par
Hello,
On Jun/21/2009, Robert Millan wrote:
> On Fri, Jun 19, 2009 at 12:42:26PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > On Fri, Jun 19, 2009 at 12:37 PM, Robert Millan wrote:
> >
> > > On Thu, Jun 18, 2009 at 09:56:07PM +0100, Carles Pina i Estany wrote:
> > > > > > -Copy ca.mo
Hi,
I ported GRUB to QEMU. It's mostly based on the coreboot port, with the
main difference being that we include code to transition from i8086 mode,
an i386 firmware entry point and produce raw code images instead of ELF.
The result is you can do e.g.
$ sudo grub-mkrawimage at_keyboard norm
On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote:
> > > It's not a problem. We need two locations anyway: one where make install
> > > copies them and the other one where ./grub-install copies them. Would it
> > > be
> > > possible to use /usr/share/grub/locale/$LANG.mo rather
On Sun, Jun 21, 2009 at 08:17:48PM +0200, Robert Millan wrote:
> grub_addr_t
> grub_arch_modules_addr (void)
> {
> - return ALIGN_UP((grub_addr_t) _end, GRUB_MOD_ALIGN);
> +// return ALIGN_UP((grub_addr_t) _end, GRUB_MOD_ALIGN);
> + return _end;
> }
Some comments on this one. It seems core
Move grub_stop to init.c to ease code sharing with i386-qemu.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
On Sun, 2009-06-21 at 20:17 +0200, Robert Millan wrote:
> Hi,
>
> I ported GRUB to QEMU. It's mostly based on the coreboot port, with the
> main difference being that we include code to transition from i8086 mode,
> an i386 firmware entry point and produce raw code images instead of ELF.
That's
On Sun, 2009-06-21 at 20:54 +0200, Robert Millan wrote:
> Move grub_stop to init.c to ease code sharing with i386-qemu.
That's not quite a movement. grub_cpu_idle() does nothing.
I think we need to have several implementations of grub_stop: hard halt
with interrupts disabled, exit from qemu, exi
On Sun, 2009-06-21 at 20:50 +0200, Robert Millan wrote:
> Does anyone know why do we align ELF targets? When I did the coreboot port,
> the ELF part was based on existing Ieee1275 code, so I guess I just mimicked
> it. Is there some issue with non-i386 CPUs or with some Ieee1275
> implementation
On Sun, 2009-06-21 at 20:42 +0200, Robert Millan wrote:
> On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote:
> > > > It's not a problem. We need two locations anyway: one where make install
> > > > copies them and the other one where ./grub-install copies them. Would
> > > > it
If you check my earlier patch, you'll see i386-qemu.rmk is just a stub
that includes i386-coreboot.rmk. This is to reduce code duplication
(untill we have a more flexible build system).
This patch renames kernel.elf to kernel.img in ELF platforms, so that
more variables / etc can be shared with
On Sun, Jun 21, 2009 at 03:05:56PM -0400, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 20:54 +0200, Robert Millan wrote:
> > Move grub_stop to init.c to ease code sharing with i386-qemu.
>
> That's not quite a movement. grub_cpu_idle() does nothing.
Well, the major problem with grub_cpu_idle() do
On Sun, Jun 21, 2009 at 03:00:42PM -0400, Pavel Roskin wrote:
> > The result is you can do e.g.
> >
> > $ sudo grub-mkrawimage at_keyboard normal etc -o /usr/share/qemu/grub
>
> Please consider if we can call it grub-mkimage unless grub-mkimage would
> make sense as a separate executable for th
On Sun, Jun 21, 2009 at 03:08:19PM -0400, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 20:50 +0200, Robert Millan wrote:
>
> > Does anyone know why do we align ELF targets? When I did the coreboot port,
> > the ELF part was based on existing Ieee1275 code, so I guess I just mimicked
> > it. Is th
When doing the i386-coreboot port I made this choice completely backwards.
I thought real_to_prot() was only useful on i386-pc, because we needed it
for returning from BIOS, and prot_to_real() was useful elsewhere, because
the Linux loader would use it.
Turns out we need real_to_prot() on i386-q
New patch, after a bunch of misc cleanup, turning hardcoded numbers into
macros, improving comments, etc.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to
On Sun, Jun 21, 2009 at 03:00:42PM -0400, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 20:17 +0200, Robert Millan wrote:
> > Hi,
> >
> > I ported GRUB to QEMU. It's mostly based on the coreboot port, with the
> > main difference being that we include code to transition from i8086 mode,
> > an i386
On Sun, Jun 21, 2009 at 10:34 PM, Robert Millan wrote:
> On Sun, Jun 21, 2009 at 03:00:42PM -0400, Pavel Roskin wrote:
> > On Sun, 2009-06-21 at 20:17 +0200, Robert Millan wrote:
> > > Hi,
> > >
> > > I ported GRUB to QEMU. It's mostly based on the coreboot port, with
> the
> > > main difference
Hola,
On Jun/21/2009, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 20:42 +0200, Robert Millan wrote:
> > On Sun, Jun 21, 2009 at 06:22:36PM +0100, Carles Pina i Estany wrote:
> > > > > It's not a problem. We need two locations anyway: one where make
> > > > > install
> > > > > copies them and the
On Sun, Jun 21, 2009 at 03:14:59PM -0400, Pavel Roskin wrote:
>
> Do we really need to localize the bootloader? I think localization of
> the tools should be sufficient.
>
> Even Linux kernel is not localized, and it's more likely to tell the
> user something important than the bootloader. Besi
On Sun, Jun 21, 2009 at 10:09:14PM +0100, Carles Pina i Estany wrote:
> >
> > Do we really need to localize the bootloader? I think localization of
> > the tools should be sufficient.
>
> By the moment I translated this string (as an example):
> +" Use the %C and %C keys to select which ent
On Sun, Jun 21, 2009 at 11:09 PM, Carles Pina i Estany wrote:
> Well, we could have another approach and this is also nice:
>
> _all_ strings that appears in a normal boot process (like the ones that
> I showed above) are part of the grub.cfg file. So, when grub.cfg file is
> generated we could ha
Hi,
On Jun/21/2009, Robert Millan wrote:
> Sounds like an interesting option. It's a pity you already spent the effort
> on implementing gettext in grub side, though :-(
Yes it's pity, but I will not force to use what I implemented if now we
think something better. So we can discuss that I wil
On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany wrote:
>
> Hi,
>
> On Jun/21/2009, Robert Millan wrote:
>
> > Sounds like an interesting option. It's a pity you already spent the
> effort
> > on implementing gettext in grub side, though :-(
>
> Yes it's pity, but I will not force to use wh
Hi,
On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote:
> On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany wrote:
>
> >
> > Hi,
> >
> > On Jun/21/2009, Robert Millan wrote:
> >
> > > Sounds like an interesting option. It's a pity you already spent the
> > effort
> > > on implementing get
On Sun, Jun 21, 2009 at 11:31:57PM +0100, Carles Pina i Estany wrote:
> On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote:
> > On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany
> > wrote:
> > Actually I think it would be a good move to provide translations of e.g.
> > error strings, output
In this line of code in real_to_prot():
DATA32 ADDR32 lgdt%cs:gdtdesc
GAS generates an absolute address for `gdtdesc' (not relative to segment),
and so for the code to work %cs must be zero. In current usage of
real_to_prot(), %cs is always zero because we jump to 0x0:0x82xx early
On Mon, Jun 22, 2009 at 12:47:15AM +0200, Robert Millan wrote:
> On Sun, Jun 21, 2009 at 11:31:57PM +0100, Carles Pina i Estany wrote:
> > On Jun/22/2009, Vladimir 'phcoder' Serbinenko wrote:
> > > On Sun, Jun 21, 2009 at 11:28 PM, Carles Pina i Estany
> > > wrote:
> > > Actually I think it would
On Sun, 2009-06-21 at 22:09 +0100, Carles Pina i Estany wrote:
> > Do we really need to localize the bootloader? I think localization of
> > the tools should be sufficient.
>
> By the moment I translated this string (as an example):
> +" Use the %C and %C keys to select which entry is highl
On Sun, 2009-06-21 at 19:33 +0800, Bean wrote:
> I've added a few function in the lua grub library to access files:
...
> I also enable the string library from lua.
The patch doesn't introduce any compiler warnings, and that's good.
It makes lua.mod bigger by about 10%, but it's very little comp
On Mon, 2009-06-22 at 00:53 +0200, Robert Millan wrote:
> In this line of code in real_to_prot():
>
> DATA32 ADDR32 lgdt%cs:gdtdesc
>
> GAS generates an absolute address for `gdtdesc' (not relative to segment),
> and so for the code to work %cs must be zero. In current usage of
> rea
On Sun, 2009-06-21 at 22:22 +0200, Robert Millan wrote:
> New patch, after a bunch of misc cleanup, turning hardcoded numbers into
> macros, improving comments, etc.
kernel_img_FORMAT is defined but never used.
GRUB_MEMORY_MACHINE_LINK_ADDR doesn't need to be conditional, it's the
same for corebo
On Sun, 2009-06-21 at 21:52 +0200, Robert Millan wrote:
> When doing the i386-coreboot port I made this choice completely backwards.
>
> I thought real_to_prot() was only useful on i386-pc, because we needed it
> for returning from BIOS, and prot_to_real() was useful elsewhere, because
> the Linux
On Sun, 2009-06-21 at 21:25 +0200, Robert Millan wrote:
> On Sun, Jun 21, 2009 at 03:05:56PM -0400, Pavel Roskin wrote:
> > On Sun, 2009-06-21 at 20:54 +0200, Robert Millan wrote:
> > > Move grub_stop to init.c to ease code sharing with i386-qemu.
> >
> > That's not quite a movement. grub_cpu_idl
On Sun, 2009-06-21 at 21:19 +0200, Robert Millan wrote:
> If you check my earlier patch, you'll see i386-qemu.rmk is just a stub
> that includes i386-coreboot.rmk. This is to reduce code duplication
> (untill we have a more flexible build system).
>
> This patch renames kernel.elf to kernel.img i
Hi,
On Mon, Jun 22, 2009 at 8:42 AM, Pavel Roskin wrote:
> On Sun, 2009-06-21 at 19:33 +0800, Bean wrote:
>
>> I've added a few function in the lua grub library to access files:
> ...
>> I also enable the string library from lua.
>
> The patch doesn't introduce any compiler warnings, and that's go
On Mon, 2009-06-22 at 11:38 +0800, Bean wrote:
> Actually, this is about to change. The file function here can be used
> in a script osdetect.lua to generate menu items at runtime, and I also
> plans to integrate lua with menu viewer.
OK, that sounds interesting!
--
Regards,
Pavel Roskin
47 matches
Mail list logo
