Hi, On Mon, Jun 22, 2009 at 8:42 AM, Pavel Roskin<pro...@gnu.org> wrote: > On Sun, 2009-06-21 at 19:33 +0800, Bean wrote: > >> I've added a few function in the lua grub library to access files: > ... >> I also enable the string library from lua. > > The patch doesn't introduce any compiler warnings, and that's good. > > It makes lua.mod bigger by about 10%, but it's very little compared to > the added functionality.
This is probably due to the enable of string library, the file access function itself should be quite small. > > Please don't add trailing whitespace. STGit detects it in two places. > > There are several cases of missing spaces before parentheses. > > We probably need NESTED_FUNC_ATTR in the dir definition in struct > grub_fs, as it takes two arguments. But is a separate issue. > > I'm feeling uneasy about having a parser in GRUB that is not used by > default, but it's not related to the quality of the patch. Actually, this is about to change. The file function here can be used in a script osdetect.lua to generate menu items at runtime, and I also plans to integrate lua with menu viewer. > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > -- Bean _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
