wiedld commented on code in PR #14821:
URL: https://github.com/apache/datafusion/pull/14821#discussion_r1975847459
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -2242,7 +2242,7 @@ async fn
test_window_partial_constant_and_set_monotonicity() -> Result<()>
dependabot[bot] commented on PR #13557:
URL: https://github.com/apache/datafusion/pull/13557#issuecomment-2693102626
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version
zhuqi-lucas closed issue #14867: Add H2O.ai Database-like Ops benchmark to
dfbench (join support)
URL: https://github.com/apache/datafusion/issues/14867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zhuqi-lucas commented on issue #14909:
URL: https://github.com/apache/datafusion/issues/14909#issuecomment-2693267549
Submitted the PR for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wForget commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2693303635
Thank you for finding this issue, which was introduced in my previous PR
#1379
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
wForget commented on code in PR #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462#discussion_r1976892621
##
spark/src/main/scala/org/apache/spark/Plugins.scala:
##
@@ -62,13 +62,9 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
kosiew opened a new pull request, #14970:
URL: https://github.com/apache/datafusion/pull/14970
## Which issue does this PR close?
Closes #14969.
## Rationale for this change
The `to_char` function was incorrectly returning `NULL` for valid `DATE`
values due to im
kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976899548
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -678,31 +669,4 @@ mod tests {
"Execution error: Format for `to_char` must be non-null Utf8,
rec
kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976901204
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -212,14 +212,6 @@ fn _to_char_scalar(
let is_scalar_expression = matches!(&expression, ColumnarValue::Sc
kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976899548
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -678,31 +669,4 @@ mod tests {
"Execution error: Format for `to_char` must be non-null Utf8,
rec
wForget commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2693325144
> Thank you for finding this issue, which was introduced in my previous PR
#1379
My initial proposal was:
+ When unified memroy manager is disabled, we should use
`get
kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976901484
##
datafusion/functions/src/datetime/to_char.rs:
##
@@ -260,13 +258,6 @@ fn _to_char_array(args: &[ColumnarValue]) ->
Result {
let data_type = arrays[0].data_
qazxcdswe123 opened a new issue, #14966:
URL: https://github.com/apache/datafusion/issues/14966
### Is your feature request related to a problem or challenge?
I'm interested in GSoC [Ergonomic SQL
Features](https://github.com/apache/datafusion/issues/14514) and found `INSERT
OR IGNOR
andygrove commented on PR #71:
URL: https://github.com/apache/datafusion-ray/pull/71#issuecomment-2692805137
> Thank you @andygrove !
>
> A few suggestions:
>
> * Can we call `Greedy`, `Streaming`? I think its more communicative
about how it functions and conveys its majo
robtandy commented on PR #71:
URL: https://github.com/apache/datafusion-ray/pull/71#issuecomment-2692804849
For the code snippet, i forgot to include
`ray.init(runtime_env=df_ray_runtime_env)`
We should have, I think,
```python
import ray
from datafusion_ray import DFRayCont
andygrove commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692806811
Thanks @LukMRVC. Could you fix the code formatting issue?
There are instructions in
https://datafusion.apache.org/comet/contributor-guide/development.html#submitting-a-p
robtandy commented on PR #71:
URL: https://github.com/apache/datafusion-ray/pull/71#issuecomment-2692803224
Thank you @andygrove !
A few suggestions:
- Can we call `Greedy`, `Streaming`? I think its more communicative about
how it functions and conveys its major feature in the n
geoffreyclaude commented on code in PR #14547:
URL: https://github.com/apache/datafusion/pull/14547#discussion_r1976361324
##
datafusion/common-runtime/src/join_set.rs:
##
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
erenavsarogullari commented on code in PR #14470:
URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713884
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -1433,6 +1433,79 @@ NULL 23
NULL 43
5 NULL
+
+## array_max
+# array_max scalar function #1 (wi
alamb merged PR #14941:
URL: https://github.com/apache/datafusion/pull/14941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14951:
URL: https://github.com/apache/datafusion/pull/14951#issuecomment-2692720801
Thank you -- I will look at this shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb closed issue #14957: index out of bounds: the len is 2 but the index is 2
in some data sources
URL: https://github.com/apache/datafusion/issues/14957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb opened a new pull request, #14963:
URL: https://github.com/apache/datafusion/pull/14963
Draft until https://github.com/apache/datafusion/pull/14956 is merged
## Which issue does this PR close?
- Follow on to https://github.com/apache/datafusion/pull/14956
- Rela
alamb commented on code in PR #14959:
URL: https://github.com/apache/datafusion/pull/14959#discussion_r1976615616
##
datafusion/catalog-listing/src/helpers.rs:
##
@@ -103,6 +103,8 @@ pub fn expr_applicable_for_cols(col_names: &[&str], expr:
&Expr) -> bool {
// - AGGREG
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2692700043
Hi @alamb, please trigger the CI for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
comphead merged PR #14942:
URL: https://github.com/apache/datafusion/pull/14942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #14963:
URL: https://github.com/apache/datafusion/pull/14963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
codecov-commenter commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692920843
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1462?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
CrystalZhou0529 opened a new pull request, #1040:
URL: https://github.com/apache/datafusion-python/pull/1040
# Which issue does this PR close?
Closes #806
# Rationale for this change
# What changes are included in this PR?
# Are there any user-faci
erenavsarogullari commented on code in PR #14470:
URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713792
##
datafusion/functions-nested/src/max.rs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
comphead opened a new pull request, #14967:
URL: https://github.com/apache/datafusion/pull/14967
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested
xxchan opened a new issue, #14962:
URL: https://github.com/apache/datafusion/issues/14962
Hi, I see we've checked in `Cargo.lock` recently #14135, and I think it's
good!
But I'm not sure whether this was discussed: what about not updating
`Cargo.toml` (for minor/patch versions), but
shruti2522 opened a new pull request, #14961:
URL: https://github.com/apache/datafusion/pull/14961
## Which issue does this PR close?
- Closes #14886
## Rationale for this change
code clean for new datafusion-cli printing logic
## What changes are included
alamb commented on PR #14956:
URL: https://github.com/apache/datafusion/pull/14956#issuecomment-2692725460
I made a small follow on:
- https://github.com/apache/datafusion/pull/14963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
alamb merged PR #14956:
URL: https://github.com/apache/datafusion/pull/14956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb opened a new pull request, #14964:
URL: https://github.com/apache/datafusion/pull/14964
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issues/14123
- Backports https://github.com/apache/datafusion/pull/14956
## Rationale fo
wiedld commented on PR #14923:
URL: https://github.com/apache/datafusion/pull/14923#issuecomment-2691290458
Closing. This was about my learning, and demonstrating for a convo on
another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove opened a new pull request, #71:
URL: https://github.com/apache/datafusion-ray/pull/71
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
xxchan commented on issue #14939:
URL: https://github.com/apache/datafusion/issues/14939#issuecomment-2692703894
Should we simply avoid putting these config methods in the trait, but just
as each implementation's method? 🤔
--
This is an automated message from the Apache Git Service.
To r
alamb commented on issue #14850:
URL: https://github.com/apache/datafusion/issues/14850#issuecomment-2692708985
DataFusion: Bugs/UX/Performance
- [ ] https://github.com/apache/datafusion/pull/14207
- [ ] https://github.com/apache/datafusion/pull/14818
- [ ] https://github.com/apache/
LukMRVC commented on PR #1462:
URL:
https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2692845799
Yes, it should be fixed by now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb merged PR #14965:
URL: https://github.com/apache/datafusion/pull/14965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb opened a new pull request, #14965:
URL: https://github.com/apache/datafusion/pull/14965
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issues/14123
- Backports https://github.com/apache/datafusion/pull/14941
## Rationale for this c
alamb opened a new issue, #14947:
URL: https://github.com/apache/datafusion/issues/14947
### Describe the bug
Explain plans look good in DataFusion 45:
```sql
DataFusion CLI v45.0.0
> create table foo(x int, y int) as values (1,2), (3,4);
0 row(s) fetched.
Elapsed 0.007
blaginin commented on PR #14940:
URL: https://github.com/apache/datafusion/pull/14940#issuecomment-2691156704
> CI is failing on main:
strange it didn't fail in PR CI 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
robtandy commented on issue #69:
URL: https://github.com/apache/datafusion-ray/issues/69#issuecomment-2692866652
> Yes, but I think the materialized results would still be streamed via
Arrow Flight. The only difference is that the source of the stream is
materialized results rather than liv
tobyhede closed issue #1612: could not compile `sqlparser`
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AmosAidoo commented on issue #14945:
URL: https://github.com/apache/datafusion/issues/14945#issuecomment-2691748996
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #14925:
URL: https://github.com/apache/datafusion/pull/14925#issuecomment-2691310652
Let's merge this one in to avoid accumulating conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on issue #14947:
URL: https://github.com/apache/datafusion/issues/14947#issuecomment-2691604189
I made a revert PR:
- https://github.com/apache/datafusion/pull/14948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jayzhan211 opened a new pull request, #14927:
URL: https://github.com/apache/datafusion/pull/14927
## Which issue does this PR close?
- Closes #14894.
## Rationale for this change
## What changes are included in this PR?
## Are these cha
LukMRVC commented on issue #1460:
URL:
https://github.com/apache/datafusion-comet/issues/1460#issuecomment-2692648040
Added a PR. There were some semantic issues in if clauses. Conf value
`COMET_COLUMNAR_SHUFFLE_UNIFIED_MEMORY_ALLOCATOR_IN_TEST` would cause a
tautology in an if condition
LukMRVC opened a new pull request, #1462:
URL: https://github.com/apache/datafusion-comet/pull/1462
## Which issue does this PR close?
Closes #1460 .
## Rationale for this change
Even when using unified memory, Comet would override
`spark.executor.memoryO
timsaucer commented on PR #14775:
URL: https://github.com/apache/datafusion/pull/14775#issuecomment-2692686473
@m09526 Thank you for the review! I've been out of country all last week, so
I will try to get back to this soon now that I'm back.
--
This is an automated message from the Apach
github-actions[bot] closed pull request #13557: Update hashbrown requirement
from 0.14.5 to 0.15.2
URL: https://github.com/apache/datafusion/pull/13557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cetra3 opened a new pull request, #14968:
URL: https://github.com/apache/datafusion/pull/14968
## Which issue does this PR close?
No Issue, just another production error we're seeing
## Rationale for this change
This seems like a pretty straight forward change to support
alamb commented on PR #14959:
URL: https://github.com/apache/datafusion/pull/14959#issuecomment-2692711027
I plan to make a PR to backport this change to `branch-46` so we can make a
release candidate shortly
--
This is an automated message from the Apache Git Service.
To respond to the m
erenavsarogullari commented on PR #14417:
URL: https://github.com/apache/datafusion/pull/14417#issuecomment-2692942704
I have also applied incoming feedbacks from `array_max` PR:
https://github.com/apache/datafusion/pull/14470 to here as well. Just FYI.
--
This is an automated message fro
CrystalZhou0529 commented on issue #806:
URL:
https://github.com/apache/datafusion-python/issues/806#issuecomment-2692948124
Hi @timsaucer , I have just attempted to implement the decorators. Would you
mind reviewing it and providing some comments for me? Since it involves an API
change, I
robtandy opened a new issue, #72:
URL: https://github.com/apache/datafusion-ray/issues/72
Right now, the `DFRayContext` accepts options that govern its runtime
behavior like
```python
ctx = DFRayContext(
batch_size=batch_size,
partitions_per_worker=partitions_per_w
CrystalZhou0529 commented on issue #1032:
URL:
https://github.com/apache/datafusion-python/issues/1032#issuecomment-2692951696
Hi @timsaucer , I am interested in contributing to Datafusion in GSoC this
year as well!
I am following the discussions on Discord regarding UDF, and I would
shruti2522 commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693447156
Hi @alamb , @zhuqi-lucas, I see that the most of the functions in the
datafusion cli print format have been reverted, do we still need these changes?
--
This is an automated mes
linhr commented on code in PR #14959:
URL: https://github.com/apache/datafusion/pull/14959#discussion_r1976951043
##
datafusion/catalog-listing/src/helpers.rs:
##
@@ -103,6 +103,8 @@ pub fn expr_applicable_for_cols(col_names: &[&str], expr:
&Expr) -> bool {
// - AGGREG
linhr commented on code in PR #14959:
URL: https://github.com/apache/datafusion/pull/14959#discussion_r1976956031
##
datafusion/catalog-listing/src/helpers.rs:
##
@@ -103,6 +103,8 @@ pub fn expr_applicable_for_cols(col_names: &[&str], expr:
&Expr) -> bool {
// - AGGREG
zhuqi-lucas commented on PR #14961:
URL: https://github.com/apache/datafusion/pull/14961#issuecomment-2693488674
Thank you @shruti2522 for the work, we still need this feature, we revert it
due to urgent release cycle for the new feature testing and bug fixes, actually
we will add back the
zhuqi-lucas commented on code in PR #14922:
URL: https://github.com/apache/datafusion/pull/14922#discussion_r1976514971
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -456,13 +456,16 @@ explain insert into table_without_values select c1 from
aggregate_test_
zhuqi-lucas commented on code in PR #14922:
URL: https://github.com/apache/datafusion/pull/14922#discussion_r1977010696
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -456,13 +456,16 @@ explain insert into table_without_values select c1 from
aggregate_test_
alamb commented on issue #7765:
URL: https://github.com/apache/datafusion/issues/7765#issuecomment-2692710667
Here is a PR that marks Expr::Wildcard deprecated (thanks @linhr 🙏 )
- https://github.com/apache/datafusion/pull/14959
--
This is an automated message from the Apache Git Servic
alamb commented on issue #14123:
URL: https://github.com/apache/datafusion/issues/14123#issuecomment-2692731904
Ok I think we are very close to being able to make a release candidate for 46
- I merged https://github.com/apache/datafusion/pull/14956
- And backported it https://github
alamb merged PR #14964:
URL: https://github.com/apache/datafusion/pull/14964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #14960:
URL: https://github.com/apache/datafusion/pull/14960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
andygrove merged PR #71:
URL: https://github.com/apache/datafusion-ray/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
andygrove merged PR #70:
URL: https://github.com/apache/datafusion-ray/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
erenavsarogullari commented on code in PR #14470:
URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713567
##
datafusion/functions-nested/src/max.rs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
74 matches
Mail list logo
