wForget commented on PR #1462: URL: https://github.com/apache/datafusion-comet/pull/1462#issuecomment-2693325144
> Thank you for finding this issue, which was introduced in my previous PR #1379 My initial proposal was: + When unified memroy manager is disabled, we should use `getCometMemoryOverheadInMiB` override spark executor memory overhead. + When unified memroy manager is enabled but shuffle unified memroy manager is disabled, we should use `getCometShuffleMemorySizeInMiB` override spark executor memory overhead. + When unified memroy manager and shuffle unified memroy manager are enabled, we don't need to override spark executor memory overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
