kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976901484
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -260,13 +258,6 @@ fn _to_char_array(args: &[ColumnarValue]) ->
Result<ColumnarValue> {
let data_type = arrays[0].data_type();
for idx in 0..arrays[0].len() {
- // fix https://github.com/apache/datafusion/issues/14884
- // If the date/time value is null, push None.
- if arrays[0].is_null(idx) {
- results.push(None);
- continue;
- }
-
Review Comment:
undo #14908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
