kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976899548
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -678,31 +669,4 @@ mod tests {
"Execution error: Format for `to_char` must be non-null Utf8,
received Timestamp(Nanosecond, None)"
);
}
-
- #[test]
- fn test_to_char_input_none_array() {
- let date_array = Arc::new(Date32Array::from(vec![Some(18506), None]))
as ArrayRef;
- let format_array =
- StringArray::from(vec!["%Y-%m-%d".to_string(),
"%Y-%m-%d".to_string()]);
- let args = datafusion_expr::ScalarFunctionArgs {
- args: vec![
- ColumnarValue::Array(date_array),
- ColumnarValue::Array(Arc::new(format_array) as ArrayRef),
- ],
- number_rows: 2,
- return_type: &DataType::Utf8,
- };
- let result = ToCharFunc::new()
- .invoke_with_args(args)
- .expect("Expected no error");
- if let ColumnarValue::Array(result) = result {
- let result =
result.as_any().downcast_ref::<StringArray>().unwrap();
- assert_eq!(result.len(), 2);
- // The first element is valid, second is null.
- assert!(!result.is_null(0));
- assert!(result.is_null(1));
- } else {
- panic!("Expected an array value");
- }
- }
Review Comment:
Remove test which was added in #14908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
