kosiew commented on code in PR #14970:
URL: https://github.com/apache/datafusion/pull/14970#discussion_r1976901204
##########
datafusion/functions/src/datetime/to_char.rs:
##########
@@ -212,14 +212,6 @@ fn _to_char_scalar(
let is_scalar_expression = matches!(&expression, ColumnarValue::Scalar(_));
let array = expression.into_array(1)?;
- // fix https://github.com/apache/datafusion/issues/14884
- // If the input date/time is null, return a null Utf8 result.
- if array.is_null(0) {
- return Ok(match is_scalar_expression {
- true => ColumnarValue::Scalar(ScalarValue::Utf8(None)),
- false => ColumnarValue::Array(new_null_array(&Utf8, array.len())),
- });
- }
Review Comment:
Undo #14908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
