wiedld commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936790068
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
Garamda commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1929539094
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -77,36 +77,38 @@ SELECT approx_distinct(c9) count_c9,
approx_distinct(cast(c9 as varchar)) count_
#
wiedld commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936767438
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
shehabgamin commented on issue #5600:
URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2626525138
> > I will say that we have encountered numerous problems relying on
downstream DataFusion-based crates,...The issue isn't with the crates
themselves but arises when it's time
remysaissy commented on PR #1687:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1687#issuecomment-2626465386
Yes, I’ll do it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
senyosimpson commented on issue #14281:
URL: https://github.com/apache/datafusion/issues/14281#issuecomment-2626439477
> Since `0x02` is not supported in arrow-rs
What's interesting here is that function seems to be a helper function.
`0x02` is handled here when reading a field for ex
alamb commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1936187986
##
datafusion/sqllogictest/test_files/expr.slt:
##
@@ -571,8 +601,10 @@ select repeat('-1.2', arrow_cast(3, 'Int32'));
-1.2-1.2-1.2
-query error DataFusion
jonathanc-n commented on issue #14376:
URL: https://github.com/apache/datafusion/issues/14376#issuecomment-2625428761
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
alamb commented on PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2625430773
@jayzhan211 and @shehabgamin what is the status of this PR? It looks to me
like there are some unresolved comments
It looks like there are some unresolved comments like
https:
alamb commented on issue #14376:
URL: https://github.com/apache/datafusion/issues/14376#issuecomment-2625439850
FYI @jonathanc-n it is not clear to me what should happen with
https://github.com/apache/datafusion/pull/14268 (if it will be merged or not)
--
This is an automated message fro
andygrove closed pull request #1355: ignore: Test impact of proposed
decimal/float type coercion changes upstream
URL: https://github.com/apache/datafusion-comet/pull/1355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb opened a new issue, #14376:
URL: https://github.com/apache/datafusion/issues/14376
### Is your feature request related to a problem or challenge?
Prior to https://github.com/apache/datafusion/pull/14268, the following
query would error:
```sql
select repeat('-1.2', 3.2
kazuyukitanimura opened a new pull request, #1356:
URL: https://github.com/apache/datafusion-comet/pull/1356
## Which issue does this PR close?
Closes #.
## Rationale for this change
The doc says ArrayRemove is experimental
https://github.com/apache/datafusion-comet/blob
alamb commented on PR #14331:
URL: https://github.com/apache/datafusion/pull/14331#issuecomment-2625442484
I looked more at what happened with this PR:
- https://github.com/alamb/datafusion/pull/28
> I am going to wait to see what happens on success and then I will
purposely introd
alamb opened a new pull request, #14377:
URL: https://github.com/apache/datafusion/pull/14377
## Which issue does this PR close?
- closes of https://github.com/apache/datafusion/issues/13359
- closes https://github.com/apache/datafusion/pull/13366
- closes https://github.com/apac
alamb closed issue #12752: String sqllogictest error when running the test with
`complete`
URL: https://github.com/apache/datafusion/issues/12752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb closed pull request #13606: Test for string / numeric coercion
URL: https://github.com/apache/datafusion/pull/13606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
alamb commented on issue #12752:
URL: https://github.com/apache/datafusion/issues/12752#issuecomment-2625515646
@logan-keede fixed this upstream last week:
https://github.com/risinglightdb/sqllogictest-rs/pull/249
--
This is an automated message from the Apache Git Service.
To respond to
alamb commented on PR #13606:
URL: https://github.com/apache/datafusion/pull/13606#issuecomment-2625516761
- Superceded by https://github.com/apache/datafusion/pull/14377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Omega359 commented on PR #14377:
URL: https://github.com/apache/datafusion/pull/14377#issuecomment-2625565209
Looking good, thx for putting this together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on issue #13360:
URL: https://github.com/apache/datafusion/issues/13360#issuecomment-2625588251
It turns out the only user of `get_wider_type` as noted by @jayzhan211 and
@Omega359 in
https://github.com/apache/datafusion/pull/13370#discussion_r1843956046 and in
fact `get_
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936295124
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
alamb merged PR #1685:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
alamb commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2625816267
I marked this PR as an API change and updated the title to reflect it. I
suggest we wait until we cut the release to merge
- #14008
I hope to make a RC in the next few days
kazuyukitanimura commented on PR #1356:
URL:
https://github.com/apache/datafusion-comet/pull/1356#issuecomment-2625822827
Thank you @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on PR #1691:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625826803
> I tried, but there are non-trivial dependencies on the ast:: and dynamic
dispatch to the dialect trait. I think it's reasonable to share the ast:: types
instead of abstra
felipecrv commented on PR #1691:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625815117
> > This crate can become a very lightweight dependency to datafusion (and
other projects) that have their own SQL parser but need to use
datafusion-sqlparser-rs AST ty
kazuyukitanimura merged PR #1356:
URL: https://github.com/apache/datafusion-comet/pull/1356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
alamb commented on PR #1691:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625799920
> This crate can become a very lightweight dependency to datafusion (and
other projects) that have their own SQL parser but need to use
datafusion-sqlparser-rs AST types to
felipecrv commented on PR #1691:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625844582
> > I tried, but there are non-trivial dependencies on the ast:: and dynamic
dispatch to the dialect trait. I think it's reasonable to share the ast:: types
instead of
jayzhan211 commented on PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2626205413
> > > @jayzhan211 and @shehabgamin what is the status of this PR? It looks
to me like there are some unresolved comments
> > > It looks like there are some unresolved comments
alamb commented on code in PR #14378:
URL: https://github.com/apache/datafusion/pull/14378#discussion_r1936297339
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -869,54 +867,6 @@ fn get_wider_decimal_type(
}
}
-/// Returns the wider type among arguments `lh
alamb commented on code in PR #14378:
URL: https://github.com/apache/datafusion/pull/14378#discussion_r1936297339
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -869,54 +867,6 @@ fn get_wider_decimal_type(
}
}
-/// Returns the wider type among arguments `lh
alamb opened a new pull request, #14378:
URL: https://github.com/apache/datafusion/pull/14378
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/13360
## Rationale for this change
As part of completing https://github.com/apache/dat
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936297998
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new
findepi commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936298445
##
datafusion/sqllogictest/test_files/union.slt:
##
@@ -836,3 +836,18 @@ physical_plan
# Clean up after the test
statement ok
drop table aggregate_test_100;
+
+
alamb commented on PR #13366:
URL: https://github.com/apache/datafusion/pull/13366#issuecomment-2625517576
I have added some additional tests to this code and made a new PR here
- https://github.com/apache/datafusion/pull/14377
--
This is an automated message from the Apache Git
kazuyukitanimura commented on PR #1356:
URL:
https://github.com/apache/datafusion-comet/pull/1356#issuecomment-2625755924
Thank you @andygrove, changed this PR for updating doc only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb commented on issue #14342:
URL: https://github.com/apache/datafusion/issues/14342#issuecomment-2625759843
> So, what do you think about an idea to extract metrics to the some place
like TaskContext and associate them with physical plan nodes some way?
I think this will be challe
alamb merged PR #1693:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
chenkovsky commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625954231
> So you're worried that if a Parquet file has this special metadata on a
field we will wrongly interpret it as a system column? Or are you saying that's
a good thing / the goal?
chenkovsky commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625942249
> I don't think (2) or (3) are real concerns. Things manipulating metadata
should already be careful about not clobbering existing metadata and I really,
really don't think the pe
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625952339
So you're worried that if a Parquet file has this special metadata on a
field we will wrongly interpret it as a system column? Or are you saying that's
a good thing / the goal?
--
jkosh44 commented on code in PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#discussion_r1936605304
##
datafusion/physical-expr/src/scalar_function.rs:
##
@@ -186,6 +187,15 @@ impl PhysicalExpr for ScalarFunctionExpr {
.map(|e| e.evaluate(batch))
codecov-commenter commented on PR #1359:
URL:
https://github.com/apache/datafusion-comet/pull/1359#issuecomment-2626183618
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
kazuyukitanimura commented on issue #5600:
URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2626192955
Echoing @andygrove 's point. Also if we move the spark-expr to DataFusion
core, release management might get harder. E.g. we may want to fix spark-expr
bugs quickly, but
alamb commented on code in PR #14379:
URL: https://github.com/apache/datafusion/pull/14379#discussion_r1936332144
##
datafusion/sql/src/expr/mod.rs:
##
@@ -819,10 +820,6 @@ impl SqlToRel<'_, S> {
return not_impl_err!("ANY in LIKE expression");
}
le
alamb commented on issue #13361:
URL: https://github.com/apache/datafusion/issues/13361#issuecomment-2625656602
I see now that @jonathanc-n proposes some additions in
- https://github.com/apache/datafusion/pull/13370#discussion_r1936327292
However I am not sure how important those
Omega359 opened a new issue, #13361:
URL: https://github.com/apache/datafusion/issues/13361
### Describe the bug
The coercion rules defined in binary_to_string_coercion do not account for
utf8view
### To Reproduce
_No response_
### Expected behavior
binary
alamb commented on code in PR #13370:
URL: https://github.com/apache/datafusion/pull/13370#discussion_r1936327292
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1172,16 +1174,22 @@ fn binary_to_string_coercion(
match (lhs_type, rhs_type) {
(Binary, U
codecov-commenter commented on PR #1321:
URL:
https://github.com/apache/datafusion-comet/pull/1321#issuecomment-2625927936
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1321?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
wiedld commented on code in PR #14329:
URL: https://github.com/apache/datafusion/pull/14329#discussion_r1936635870
##
datafusion/expr/src/logical_plan/extension.rs:
##
@@ -54,6 +57,22 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync {
/// Return the output sche
wiedld commented on code in PR #14329:
URL: https://github.com/apache/datafusion/pull/14329#discussion_r1936635870
##
datafusion/expr/src/logical_plan/extension.rs:
##
@@ -54,6 +57,22 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync {
/// Return the output sche
kazuyukitanimura commented on PR #1357:
URL:
https://github.com/apache/datafusion-comet/pull/1357#issuecomment-2626242018
Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kazuyukitanimura merged PR #1357:
URL: https://github.com/apache/datafusion-comet/pull/1357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
jayzhan211 commented on code in PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#discussion_r1936645403
##
datafusion/physical-expr/src/scalar_function.rs:
##
@@ -186,6 +187,15 @@ impl PhysicalExpr for ScalarFunctionExpr {
.map(|e| e.evaluate(batch))
ozankabak commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1936681167
##
datafusion/sqllogictest/test_files/window.slt:
##
@@ -5452,3 +5452,89 @@ order by c1, c2, rank1, rank2;
statement ok
drop table t1;
+
+
+# Set-Monotonic W
ozankabak merged PR #14271:
URL: https://github.com/apache/datafusion/pull/14271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
iffyio commented on PR #1693:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1693#issuecomment-2626368069
Thanks @alamb!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb commented on code in PR #14356:
URL: https://github.com/apache/datafusion/pull/14356#discussion_r1936301257
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -2645,6 +2643,106 @@ pub struct Union {
pub schema: DFSchemaRef,
}
+impl Union {
+/// Constructs new U
alamb commented on issue #14154:
URL: https://github.com/apache/datafusion/issues/14154#issuecomment-2626099386
I tried to make a datafusion only reproducer but it turns out I can't create
LargeLists of structs via SQL 🤔 I'll have to think about how to do so a bit
more tomorrow...
--
Thi
parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936547960
##
native/core/src/parquet/parquet_support.rs:
##
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(cr
comphead commented on issue #14238:
URL: https://github.com/apache/datafusion/issues/14238#issuecomment-2626102317
Thanks @korowa for running the benchmarks. 🚀
Speaking to `Coalescer` It is probably worth to think if we want to have a
unified approach, like calling the coalescer on t
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936551696
##
native/core/src/execution/planner.rs:
##
@@ -1220,7 +1217,7 @@ impl PhysicalPlanner {
// TODO: I think we can remove partition_count in th
shehabgamin commented on issue #5600:
URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2626095699
> [@shehabgamin](https://github.com/shehabgamin) if we did that, would you
be willing to help implement / upstream some of your implementations and tests?
Yes!
@a
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936553571
##
native/core/src/parquet/parquet_support.rs:
##
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate)
Rachelint commented on PR #13681:
URL: https://github.com/apache/datafusion/pull/13681#issuecomment-2626112366
> Will plan to merge this one tomorrow if there is not anyone else who would
like time to review
Thanks all for reviewing!
--
This is an automated message from the Apache
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936553571
##
native/core/src/parquet/parquet_support.rs:
##
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate)
Rachelint merged PR #13681:
URL: https://github.com/apache/datafusion/pull/13681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
Rachelint closed issue #13550: Improve performance of `median` function
URL: https://github.com/apache/datafusion/issues/13550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
codecov-commenter commented on PR #1357:
URL:
https://github.com/apache/datafusion-comet/pull/1357#issuecomment-2626116353
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1357?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
findepi commented on code in PR #14349:
URL: https://github.com/apache/datafusion/pull/14349#discussion_r1936291719
##
datafusion/sqllogictest/test_files/case.slt:
##
@@ -289,12 +289,22 @@ query B
select case when a=1 then false end from foo;
false
-false
-false
-false
-
findepi closed issue #14343: Invalid query result when searched CASE has
nullable condition and boolean result
URL: https://github.com/apache/datafusion/issues/14343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
findepi merged PR #14349:
URL: https://github.com/apache/datafusion/pull/14349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafu
alamb commented on issue #14296:
URL: https://github.com/apache/datafusion/issues/14296#issuecomment-2625773366
> In particular, the coercion rules should be applied by the analyzer,
during the logical plan construction.
I agree with this goal 100%
--
This is an automated message f
alamb commented on issue #5600:
URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2625779458
> I love the idea of collaborating on Spark compatible `UDF`s.
>
> As of writing, `243/402` Spark functions doc-tests pass on Sail. We
haven't focused on performance yet and i
comphead opened a new pull request, #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359
## Which issue does this PR close?
Closes #1337.
## Rationale for this change
## What changes are included in this PR?
## How are these chan
alamb commented on PR #1691:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2626048512
> But then sqlparser would depend on datafusion and not just the other way
around.
I meant literally copy/pasting (or some variant thereof) of the relevant
s
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936518217
##
native/core/Cargo.toml:
##
@@ -77,6 +77,7 @@ datafusion-comet-proto = { workspace = true }
object_store = { workspace = true }
url = { workspace = true }
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936518708
##
native/core/src/execution/planner.rs:
##
@@ -1220,7 +1217,7 @@ impl PhysicalPlanner {
// TODO: I think we can remove partition_count in th
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-262595
See also https://github.com/apache/datafusion/issues/12736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625961004
> > So you're worried that if a Parquet file has this special metadata on a
field we will wrongly interpret it as a system column? Or are you saying that's
a good thing / the goal?
jkosh44 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2625975316
There's still the open question of how window and aggregate functions should
treat `NullBehavior::Propagate`. Table functions don't use the `Signature`
struct, so we can ignore them
andygrove commented on issue #5600:
URL: https://github.com/apache/datafusion/issues/5600#issuecomment-2626014384
I almost started a conversation about this but held back. Moving this crate
upstream has a lot of value, and I support doing so.
However, assuming that most DataFusion con
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2626122404
One thing I didn't understand from you PR @chenkovsky: you got it to work
only modifying TableScan? I had trouble understanding when I was grokking your
PR. If you have a better way
github-actions[bot] closed pull request #1535: Add support for data type
specific methods
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on PR #13617:
URL: https://github.com/apache/datafusion/pull/13617#issuecomment-2626123488
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2626145613
For now I pushed
https://github.com/apache/datafusion/pull/14362/commits/c2b58ee1632b7090188f4f7d5af6c78fbf40462e
which has a test that I think covers all of the cases discussed.
mvzink opened a new issue, #1694:
URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1694
In addition to `SESSION` and `LOCAL` qualifiers, MySQL allows `GLOBAL` for
modifying system variables:
```
mysql> SET GLOBAL max_connections = 1000;
Query OK, 0 rows affected (0.
kazuyukitanimura opened a new pull request, #1357:
URL: https://github.com/apache/datafusion-comet/pull/1357
## Which issue does this PR close?
Closes #.
## Rationale for this change
fuzz comet dependency version was hardcoded
## What changes are included in this P
chenkovsky commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625969618
> > > So you're worried that if a Parquet file has this special metadata on
a field we will wrongly interpret it as a system column? Or are you saying
that's a good thing / the go
kazuyukitanimura commented on PR #1358:
URL:
https://github.com/apache/datafusion-comet/pull/1358#issuecomment-2626041757
cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
kazuyukitanimura opened a new pull request, #1358:
URL: https://github.com/apache/datafusion-comet/pull/1358
Leftover from #1349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
kazuyukitanimura commented on PR #1357:
URL:
https://github.com/apache/datafusion-comet/pull/1357#issuecomment-2626041966
cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
adriangb commented on PR #14362:
URL: https://github.com/apache/datafusion/pull/14362#issuecomment-2625987325
I see. That makes sense for something like row_id: once you write it to a
new file it may not be valid anymore. But for other metadata you might want to
round trip it as a system co
kazuyukitanimura commented on PR #1358:
URL:
https://github.com/apache/datafusion-comet/pull/1358#issuecomment-2626045460
Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jayzhan211 commented on PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#issuecomment-2626045546
> @jayzhan211 and @shehabgamin what is the status of this PR? It looks to
me like there are some unresolved comments
>
> It looks like there are some unresolved comments l
jayzhan211 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2626019855
Implement it as the method in the trait and call it inside 'invoke' methods
requires more changes. However, I think it makes more sense now given null
handling should be the logic
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936519276
##
native/core/src/parquet/parquet_support.rs:
##
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate)
kazuyukitanimura merged PR #1358:
URL: https://github.com/apache/datafusion-comet/pull/1358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
1 - 100 of 244 matches
Mail list logo
