comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936553571
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate) fn register_object_store(
+ session_context: Arc<SessionContext>,
+) -> Result<(), ExecutionError> {
+ let object_store = object_store::local::LocalFileSystem::new();
Review Comment:
It depends on the feature enabled for the Comet. LocalFileSystem is by
default if no specific features selected.
the annotation on this method is
```
#[cfg(not(feature = "hdfs"))]
```
This allows to plugin other features like S3, etc
This particular method is responsible for no remote feature selected e.g.
for local filesystem.
If a feature selected the conditional compilation will register an object
store related to the feature, like HDFS or S3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
