alamb opened a new pull request, #14378: URL: https://github.com/apache/datafusion/pull/14378
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/13360 ## Rationale for this change As part of completing https://github.com/apache/datafusion/issues/13504 it is important to supoprt `Utf8View` in `array_concat`, It turns out the only user of `get_wider_type` as noted by @jayzhan211 and @Omega359 in https://github.com/apache/datafusion/pull/13370#discussion_r1843956046 and in fact `get_wider_type` is not necessary ## What changes are included in this PR? 1. Add tests showing behavior of `array_concat` with different string types (see first commit) 2. Remove unnecessary `get_wider_type` ## Are these changes tested? Yes, new tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? Error messages change slightly <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
