felipecrv commented on PR #1691: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625815117
> > This crate can become a very lightweight dependency to datafusion (and other projects) that have their own SQL parser but need to use datafusion-sqlparser-rs AST types to interact with the rest of datafusion (as a modular library and not as a full-featured SQL engine). > > BTW another way to approach this issue would be to remove the dependency of sqlparser from DataFusion (e.g. make the parsing an optional module) I tried, but there are non-trivial dependencies on the `ast::` and dynamic dispatch to the dialect trait. I think it's reasonable to share the `ast::` types instead of abstracting them, hence my idea of disabling the parsing from the crate and leave the rest available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
