parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936547960
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate) fn register_object_store(
+ session_context: Arc<SessionContext>,
+) -> Result<(), ExecutionError> {
+ let object_store = object_store::local::LocalFileSystem::new();
Review Comment:
It doesn't have to be only a local file system.
##########
native/core/src/execution/planner.rs:
##########
@@ -1220,7 +1217,7 @@ impl PhysicalPlanner {
// TODO: I think we can remove partition_count in the future,
but leave for testing.
assert_eq!(file_groups.len(), partition_count);
- let object_store_url = ObjectStoreUrl::local_filesystem();
+ let object_store_url =
ObjectStoreUrl::parse("hdfs://namenode:9000").unwrap();
Review Comment:
The url should be available as part of the file path passed in. (see line
1178 above)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
