lichuang commented on PR #14180:
URL: https://github.com/apache/datafusion/pull/14180#issuecomment-2613832659
> > @jonahgao in [#10234
(comment)](https://github.com/apache/datafusion/pull/10234#issuecomment-2087760241)
comment:
> > > I think that we should handle ORDER BY similarly to HA
adriangb commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2613936275
I think this is great Andrew. For what it's worth if this were packaged up
in some installable way (even if it had to be from git, etc.) I'm sure we'd be
super happy to can our cust
alamb commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2613937768
> We could handle such nulls handling in `ScalarFunctionExpr::evaluate`
Most SQL functions are "pure" in the sense that if any of their inputs are
null they produce output
jayzhan211 commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613937019
> u64+i64 combination
I mean the comparison_op(u64,i64), coalesce(u64,i64) and union(u64,i64) that
use `binary_numeric_coercion` and casted to decimal128. mathematics operat
alamb commented on issue #14247:
URL: https://github.com/apache/datafusion/issues/14247#issuecomment-2613936434
> But once such logic is written somewhere, there is no reason for it not to
be part of datafusion project, for the benefit of all consumers. I think such
logic should belong to d
jayzhan211 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2613940212
Maybe we need yet another trait implementation
```rust
trait ScalarUDFImpl {
fn handle_nulls(&self, args: ScalarFunctionArgs) ->
Result> {
// most of the cas
shehabgamin commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1929529897
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -2133,4 +2133,77 @@ mod test {
assert_analyzed_plan_eq(Arc::new(TypeCoercion::new()), pla
xudong963 commented on PR #14267:
URL: https://github.com/apache/datafusion/pull/14267#issuecomment-2613941841
> Looks good to me -- thanks @xudong963
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
pepijnve commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929519836
##
datafusion/functions/src/core/named_struct.rs:
##
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
}
-fn invoke_batch(
Garamda commented on code in PR #13511:
URL: https://github.com/apache/datafusion/pull/13511#discussion_r1929539094
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -77,36 +77,38 @@ SELECT approx_distinct(c9) count_c9,
approx_distinct(cast(c9 as varchar)) count_
#
ozankabak commented on PR #14273:
URL: https://github.com/apache/datafusion/pull/14273#issuecomment-2613842458
This change makes sense to me. However, I *fully* agree with @alamb on
avoiding being trigger happy on partial changes to coercion behavior. Let's
follow the 4-step process laid ou
2010YOUY01 commented on code in PR #14271:
URL: https://github.com/apache/datafusion/pull/14271#discussion_r1929505898
##
datafusion/expr/src/udaf.rs:
##
@@ -635,6 +655,14 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
fn documentation(&self) -> Option<&Documentation>
jayzhan211 commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613874994
For the scalar case, like `SELECT a > -1`, consider any `SELECT a > b` where
b is constant. I think we could optimize it since we know the value. If the
scalar is negative, it can
alamb commented on issue #14287:
URL: https://github.com/apache/datafusion/issues/14287#issuecomment-2613926246
BTW my suggestion for a first step would be to get some example query / test
case that shows where the current algorithm doesn't work very well. Then we can
evaluate potential sol
alamb commented on issue #14287:
URL: https://github.com/apache/datafusion/issues/14287#issuecomment-2613926046
Thanks @westonpace for filing this -- I agree there is likely some
improvements in this area that would be beneficial
I believe @crepererum spent quite a bit of time on th
alamb commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613928742
> Another question I would like to know is whether the u64+i64 combination
is common in DataFusion? And whether we can avoid this at all. I guess u64 that
is larger than i64::max is un
alamb commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613928105
BTW I filed a ticket to track resolving this thread (so that it does't get
lost before we release 45.0.0):
- https://github.com/apache/datafusion/issues/14291
--
This is an automa
alamb opened a new issue, #14291:
URL: https://github.com/apache/datafusion/issues/14291
### Describe the bug
There is concern changes in this PR will cause regression (as it may
convert some numbers to Decimal128 rather than more efficient Integer)
- https://github.com/apache/dat
alamb opened a new pull request, #14292:
URL: https://github.com/apache/datafusion/pull/14292
Draft PR to test the performance implications of #14223.
## Which issue does this PR close?
- Related to https://github.com/apache/datafusion/issues/14291
## Rationale fo
Rachelint commented on PR #13681:
URL: https://github.com/apache/datafusion/pull/13681#issuecomment-2613929079
I think this pr is ready now
Q6 in h2o:
- `result in main`
```
Q6: SELECT id4, id5, MEDIAN(v3) AS median_v3, STDDEV(v3) AS sd_v3 FROM x
GROUP BY id4, id5;
Que
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541738
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929540823
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
Omega359 commented on PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#issuecomment-2613964912
Thanks for your contribution! I've left some comments for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
waynexia closed issue #14124: [Regression] Panic when handling Decimal128
overflow
URL: https://github.com/apache/datafusion/issues/14124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
waynexia commented on PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#issuecomment-2613965595
Thank you @comphead and @alamb for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541028
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
waynexia merged PR #14126:
URL: https://github.com/apache/datafusion/pull/14126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Omega359 commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929541426
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
alamb commented on PR #14270:
URL: https://github.com/apache/datafusion/pull/14270#issuecomment-2613966867
> I think adding tests for comparison operations will probably expose the
possible issue with the linked PR. (Or give us a peace of mind)
It is a good idea -- I added tests showi
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2613967071
Looking forward to the ongoing refactors!
>Also, can you make sure there is no bias in the measurement? If you build
in reverse order and run cargo clean between each ste
alamb commented on code in PR #14270:
URL: https://github.com/apache/datafusion/pull/14270#discussion_r1929542389
##
datafusion/sqllogictest/test_files/operator.slt:
##
@@ -110,5 +226,139 @@ from numeric_types;
Int8 Int16 Int32 Int64 UInt8 UInt16 UInt32 UInt64 Float32 Flo
alamb commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613968183
I ran benchmarks with / without this change and did not see any noticable
performance difference. See details here
- https://github.com/apache/datafusion/pull/14292
I also cre
alamb commented on issue #14291:
URL: https://github.com/apache/datafusion/issues/14291#issuecomment-2613968303
I ran benchmarks with / without this change and did not see any noticable
performance difference. See details here
- https://github.com/apache/datafusion/pull/14292
I als
alamb commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2613969732
> I think this is great Andrew. For what it's worth if this were packaged up
in some installable way (even if it had to be from git, etc.) I'm sure we'd be
super happy to can our custo
xudong963 commented on issue #14150:
URL: https://github.com/apache/datafusion/issues/14150#issuecomment-2613843375
there is a fix #14207, looking forward to your feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
pepijnve commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929519836
##
datafusion/functions/src/core/named_struct.rs:
##
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
}
-fn invoke_batch(
docteurklein commented on issue #1475:
URL:
https://github.com/apache/datafusion-sqlparser-rs/issues/1475#issuecomment-2613924635
here is an example to change ASC to DESC in some order by:
```rust
struct VisitOrderBy {
reorder: Vec,
}
impl VisitorMut for VisitOrde
alamb commented on issue #14179:
URL: https://github.com/apache/datafusion/issues/14179#issuecomment-2613925385
If anyone else is interested in helping build times, @waynexia is starting
to organize a project:
- https://github.com/apache/datafusion/issues/14256
--
This is an automated
alamb commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2613925243
100% making build time better would be really appreciated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
logan-keede commented on issue #13723:
URL: https://github.com/apache/datafusion/issues/13723#issuecomment-2613841926
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
lichuang commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929516369
##
datafusion/functions/src/core/named_struct.rs:
##
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
}
-fn invoke_batch(
lichuang commented on code in PR #14276:
URL: https://github.com/apache/datafusion/pull/14276#discussion_r1929516369
##
datafusion/functions/src/core/named_struct.rs:
##
@@ -203,12 +137,19 @@ impl ScalarUDFImpl for NamedStructFunc {
}
-fn invoke_batch(
senyosimpson commented on issue #14281:
URL: https://github.com/apache/datafusion/issues/14281#issuecomment-2613908545
Confirmed that the following works now.
```rust
let mut parquet_options = TableParquetOptions::new();
parquet_options
.set("enable_page_index", "false")
alamb merged PR #14267:
URL: https://github.com/apache/datafusion/pull/14267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #14188:
URL: https://github.com/apache/datafusion/pull/14188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
berkaysynnada commented on PR #14235:
URL: https://github.com/apache/datafusion/pull/14235#issuecomment-2614058166
I am merging this once the CI passes one more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596970
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596852
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
berkaysynnada opened a new pull request, #14298:
URL: https://github.com/apache/datafusion/pull/14298
## Which issue does this PR close?
Closes #14243.
## Rationale for this change
## What changes are included in this PR?
## Are these change
viirya commented on PR #1335:
URL:
https://github.com/apache/datafusion-comet/pull/1335#issuecomment-2614071748
Thanks @kazuyukitanimura
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
viirya merged PR #1335:
URL: https://github.com/apache/datafusion-comet/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929597131
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
SKY-ALIN commented on code in PR #14282:
URL: https://github.com/apache/datafusion/pull/14282#discussion_r1929596877
##
datafusion/functions/src/regex/regexpextract.rs:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
berkaysynnada merged PR #14235:
URL: https://github.com/apache/datafusion/pull/14235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
timsaucer commented on code in PR #13937:
URL: https://github.com/apache/datafusion/pull/13937#discussion_r1929608071
##
datafusion/ffitest/src/async_provider.rs:
##
@@ -0,0 +1,272 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
codecov-commenter commented on PR #1339:
URL:
https://github.com/apache/datafusion-comet/pull/1339#issuecomment-2614134541
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1339?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
gokselk commented on issue #14209:
URL: https://github.com/apache/datafusion/issues/14209#issuecomment-2614003903
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
waynexia commented on issue #14256:
URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2614019259
I located the biggest jump happens on
https://github.com/apache/datafusion/pull/11681/, commit 3438b355. But I can't
tell the reason. I go through it and it's just a normal log
berkaysynnada commented on code in PR #14235:
URL: https://github.com/apache/datafusion/pull/14235#discussion_r1929564102
##
datafusion/sqllogictest/test_files/explain.slt:
##
@@ -43,10 +43,11 @@ logical_plan
02)--Filter: aggregate_test_100.c2 > Int8(10)
03)TableScan: aggr
andygrove commented on PR #14283:
URL: https://github.com/apache/datafusion/pull/14283#issuecomment-2614024359
> How do you handle types mismatch issue? Does Comet has another type
handling logic to find the correct types for datafusion physical plan?
We map Spark types to Arrow types
adriangb opened a new pull request, #14295:
URL: https://github.com/apache/datafusion/pull/14295
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
buraksenn commented on code in PR #14235:
URL: https://github.com/apache/datafusion/pull/14235#discussion_r1929572633
##
datafusion/sqllogictest/test_files/explain.slt:
##
@@ -43,10 +43,11 @@ logical_plan
02)--Filter: aggregate_test_100.c2 > Int8(10)
03)TableScan: aggregat
timsaucer commented on issue #14197:
URL: https://github.com/apache/datafusion/issues/14197#issuecomment-2614025064
Great, once I have `datafusion-python` updated, I'll put up this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
adriangb commented on PR #14295:
URL: https://github.com/apache/datafusion/pull/14295#issuecomment-2614026191
I want to point out that this works because of how the Recordbatch is
generated:
https://github.com/apache/datafusion/blob/20544bcccd83e0de36e2944ad2b99615ad3bb41d/datafusion/physic
jayzhan211 commented on PR #14283:
URL: https://github.com/apache/datafusion/pull/14283#issuecomment-2614154584
The function `coerce_types` is used exclusively within function handling.
For case expressions, `coerce_types` is not utilized. Instead, the function
`get_coerce_type_for_case_exp
jayzhan211 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2614158196
> So instead of SELECT array_slice(1.5, NULL, NULL) returning an error for
an unsupported type in the first argument, it will return NULL
This is because the signature for `
jayzhan211 commented on code in PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#discussion_r1929640010
##
datafusion/physical-expr/src/scalar_function.rs:
##
@@ -186,6 +186,56 @@ impl PhysicalExpr for ScalarFunctionExpr {
.map(|e| e.evaluate(batch))
berkaysynnada commented on PR #14207:
URL: https://github.com/apache/datafusion/pull/14207#issuecomment-2613992380
This week I couldn't spare time to review this fix, sorry @xudong963. That
will be one of my priorities in the next week.
--
This is an automated message from the Apache Git
alamb closed issue #14172: Deprecate
`datafusion.execution.parquet.max_statistics_size` config option
URL: https://github.com/apache/datafusion/issues/14172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on PR #14188:
URL: https://github.com/apache/datafusion/pull/14188#issuecomment-2613994473
Thanks again @logan-keede
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb merged PR #1682:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
jonahgao commented on PR #14223:
URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2614016503
`UInt64 > -1` is less common than `UInt64 > 1`. In my opinion, ensuring that
comparisons between unsigned and signed columns are always available is more
important.
--
This is a
berkaysynnada commented on issue #14287:
URL: https://github.com/apache/datafusion/issues/14287#issuecomment-2614018742
We have designed a poll-based repartition mechanism that polls its input
whenever any of the output partitions are polled. This approach deviates from
the round-robin patt
himadripal commented on PR #14284:
URL: https://github.com/apache/datafusion/pull/14284#issuecomment-2614028861
#13492 fix for this is in arrow-rs and this is a test to confirm the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
alamb opened a new issue, #14296:
URL: https://github.com/apache/datafusion/issues/14296
### Is your feature request related to a problem or challenge?
Coercion is (TODO find definition)
At the moment DataFusion has one set of built in coercion rules. However,
with a single set
buraksenn commented on code in PR #14279:
URL: https://github.com/apache/datafusion/pull/14279#discussion_r1929594804
##
datafusion/physical-expr/src/analysis.rs:
##
@@ -344,6 +366,41 @@ mod tests {
}
}
+#[test]
+fn test_analyze_empty_set_boundary_exprs()
buraksenn commented on code in PR #14279:
URL: https://github.com/apache/datafusion/pull/14279#discussion_r1929594954
##
datafusion/physical-expr/src/analysis.rs:
##
@@ -179,7 +179,17 @@ pub fn analyze(
expr.as_any()
.downcast_ref::()
buraksenn commented on code in PR #14279:
URL: https://github.com/apache/datafusion/pull/14279#discussion_r1929595006
##
datafusion/physical-expr/src/analysis.rs:
##
@@ -235,16 +256,25 @@ fn shrink_boundaries(
fn calculate_selectivity(
target_boundaries: &[ExprBoundaries],
jonahgao commented on PR #14180:
URL: https://github.com/apache/datafusion/pull/14180#issuecomment-2613997693
> @jonahgao `select_to_plan` only works with SQL API, but sometimes people
use `DataFrame` API directly, where `test_distinct_sort_by_unprojected` is this
case, so only check in `se
jkosh44 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2614042678
I made a couple of changes to this PR in the second commit. Previously, I
was getting an optimizer error under certain scenarios, for example,
```
> select array_slice([1,2,3],
getChan commented on issue #14097:
URL: https://github.com/apache/datafusion/issues/14097#issuecomment-2614046188
I'm waiting for the arrow-avro PR below as it might include changes to the
public API.
https://github.com/apache/arrow-rs/pull/6965
I will resume related work once this PR
ion-elgreco commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2614047765
@alamb ah good point, I missed that! Definitely good to add, will have a
better look at where these payload streams are collected
--
This is an automated message from the Apach
timsaucer closed issue #792: Document how to use rust UDF extensions of
datafusion-python
URL: https://github.com/apache/datafusion-python/issues/792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
adriangb opened a new pull request, #14297:
URL: https://github.com/apache/datafusion/pull/14297
Currently pruning predicates may return `NULL` to indicate "this container
should be included", thus using `NULL` as a *truthy* value. That is quite
confusing, as explained in the various commen
adriangb commented on code in PR #14297:
URL: https://github.com/apache/datafusion/pull/14297#discussion_r1929591473
##
datafusion/physical-optimizer/src/pruning.rs:
##
@@ -819,16 +813,24 @@ impl RequiredColumns {
/// statistics column, while keeping track that a reference
timsaucer commented on code in PR #13937:
URL: https://github.com/apache/datafusion/pull/13937#discussion_r1929605183
##
datafusion/ffi/src/lib.rs:
##
@@ -26,5 +26,14 @@ pub mod session_config;
pub mod table_provider;
pub mod table_source;
+/// Returns the major version of t
timsaucer commented on code in PR #13937:
URL: https://github.com/apache/datafusion/pull/13937#discussion_r1929608323
##
datafusion/ffitest/src/async_provider.rs:
##
@@ -0,0 +1,272 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
logan-keede commented on PR #14301:
URL: https://github.com/apache/datafusion/pull/14301#issuecomment-2614108205
cc @Rachelint @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rluvaton opened a new pull request, #14302:
URL: https://github.com/apache/datafusion/pull/14302
## Which issue does this PR close?
N/A
## Rationale for this change
So we can see the improvement in #14299
## What changes are included in this PR?
added benchm
logan-keede opened a new pull request, #14301:
URL: https://github.com/apache/datafusion/pull/14301
## Which issue does this PR close?
Closes #13723
## Rationale for this change
Better Readability and Navigation.
## What changes are included in this PR
ctsk commented on PR #14234:
URL: https://github.com/apache/datafusion/pull/14234#issuecomment-2614112816
I plan to test this again with a larger TPCH scale factor, and compare
collectLeft (parallel hashing) vs collectLeft (main branch) vs repartition joins
- On SF=1, collectLeft alrea
jkosh44 commented on PR #14289:
URL: https://github.com/apache/datafusion/pull/14289#issuecomment-2614165389
> This is because the signature for extract doesn't handle type checking
correctly, it uses variadic_any, not because of the introduced new trait method
Oh, great then I don't
dharanad commented on PR #1227:
URL:
https://github.com/apache/datafusion-comet/pull/1227#issuecomment-2614220161
@andygrove Sure i will break them into multiple PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Rachelint commented on issue #14246:
URL: https://github.com/apache/datafusion/issues/14246#issuecomment-2614196240
#13681 is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zhuqi-lucas commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1929652858
##
datafusion/sqllogictest/test_files/joins.slt:
##
@@ -4247,8 +4247,10 @@ logical_plan
physical_plan
01)CoalesceBatchesExec: target_batch_size=3, fetch=2
0
zhuqi-lucas commented on code in PR #14245:
URL: https://github.com/apache/datafusion/pull/14245#discussion_r1929652858
##
datafusion/sqllogictest/test_files/joins.slt:
##
@@ -4247,8 +4247,10 @@ logical_plan
physical_plan
01)CoalesceBatchesExec: target_batch_size=3, fetch=2
0
jayzhan211 commented on issue #14296:
URL: https://github.com/apache/datafusion/issues/14296#issuecomment-2614252405
We have type coercion in logical plan now, consider the case where we want
to separate logical types and physical types, should we add another type
coercion layer in physical
adriangb opened a new pull request, #14294:
URL: https://github.com/apache/datafusion/pull/14294
Closes #13836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
adriangb closed pull request #14294: use a single row_count column during
predicate pruning instead of one per column
URL: https://github.com/apache/datafusion/pull/14294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
alamb commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2614037782
> Based on the previous discussions, and draft PRs, I ended up with this
Object store wrapper to spawn the io tasks in a different handle:
https://github.com/delta-io/delta-rs/blob/mai
1 - 100 of 138 matches
Mail list logo
