adriangb commented on PR #14295: URL: https://github.com/apache/datafusion/pull/14295#issuecomment-2614026191
I want to point out that this works because of how the Recordbatch is generated: https://github.com/apache/datafusion/blob/20544bcccd83e0de36e2944ad2b99615ad3bb41d/datafusion/physical-optimizer/src/pruning.rs#L937-L965 Since it's generated based on the columns tracked by `RequiredColumns` we can just rename it internally with no consequences. This _should_ also save some work in creating the array, make scanning the record batch faster, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
