alamb commented on issue #14291: URL: https://github.com/apache/datafusion/issues/14291#issuecomment-2613968303
I ran benchmarks with / without this change and did not see any noticable performance difference. See details here - https://github.com/apache/datafusion/pull/14292 I also created a PR with some tests that show the practical impact of this PR on comparisons (I think it is minimal). See - https://github.com/apache/datafusion/pull/14270 So in other words I would be inclined to close this ticket without further changes given what I currently know -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
