rluvaton commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2796420969
@ashdnazg thank you for your contribution, hope to see you contribute again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035113005
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::fut
alamb merged PR #15653:
URL: https://github.com/apache/datafusion/pull/15653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2794928529
all the tests are green so let's go go go!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ashdnazg commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2794880787
Rebased and added docs per @alamb 's suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2036167289
##
datafusion/common-runtime/src/common.rs:
##
@@ -77,17 +82,32 @@ impl SpawnedTask {
}
}
+impl Future for SpawnedTask {
+type Output = Result;
+
+fn
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035113554
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::fut
geoffreyclaude commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2794553315
> This looks really nice to me -- thank you @ashdnazg 🙏
>
> Let's wait a while before merging to give @geoffreyclaude and others a
chance to review it again if they wa
geoffreyclaude commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2037465610
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
eshed-flarion commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2037103221
##
datafusion/common-runtime/src/common.rs:
##
@@ -77,17 +82,32 @@ impl SpawnedTask {
}
}
+impl Future for SpawnedTask {
+type Output = Result;
+
ashdnazg commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2037104099
##
datafusion/common-runtime/src/common.rs:
##
@@ -77,17 +82,32 @@ impl SpawnedTask {
}
}
+impl Future for SpawnedTask {
+type Output = Result;
+
+
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2037038176
##
datafusion/common-runtime/src/common.rs:
##
@@ -77,17 +82,32 @@ impl SpawnedTask {
}
}
+impl Future for SpawnedTask {
+type Output = Result;
+
+fn
ashdnazg commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2036184085
##
datafusion/common-runtime/src/common.rs:
##
@@ -77,17 +82,32 @@ impl SpawnedTask {
}
}
+impl Future for SpawnedTask {
+type Output = Result;
+
+
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035644581
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::fut
eshed-flarion commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2036057402
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
ashdnazg commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2790857599
Tests should be more reliable now :facepalm:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ashdnazg commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2036059191
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::
eshed-flarion commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2036057402
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
geoffreyclaude commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035646883
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
geoffreyclaude commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035706218
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
gabotechs commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035619112
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std:
gabotechs commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035619112
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std:
ashdnazg commented on PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2789659869
@alamb I added two tests for the two scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035089985
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::fut
ashdnazg commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035097565
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::
ashdnazg commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035094757
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::
eshed-flarion commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035093884
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
eshed-flarion commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035093884
##
datafusion/common-runtime/src/common.rs:
##
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use
28 matches
Mail list logo
