alamb commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035089985
##########
datafusion/common-runtime/src/common.rs:
##########
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::future::Future;
+use std::{
+ future::Future,
+ pin::Pin,
+ task::{Context, Poll},
+};
-use crate::JoinSet;
-use tokio::task::JoinError;
+use tokio::task::{JoinError, JoinHandle};
/// Helper that provides a simple API to spawn a single task and join it.
/// Provides guarantees of aborting on `Drop` to keep it cancel-safe.
+/// Note that if the task was spawned with `spawn_blocking`, it will only be
Review Comment:
This seems like a bad idea -- the whole reason to use JoinSet is to ensure
that any outstanding tasks are cancelled on drop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
