geoffreyclaude commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035706218
##########
datafusion/common-runtime/src/common.rs:
##########
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::future::Future;
+use std::{
+ future::Future,
+ pin::Pin,
+ task::{Context, Poll},
+};
-use crate::JoinSet;
-use tokio::task::JoinError;
+use tokio::task::{JoinError, JoinHandle};
Review Comment:
@ashdnazg I'll try to add unit tests for the instrumentation feature
tomorrow which you could use to validate your change doesn't introduce any
regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
