geoffreyclaude commented on PR #15653: URL: https://github.com/apache/datafusion/pull/15653#issuecomment-2794553315
> This looks really nice to me -- thank you @ashdnazg 🙏 > > Let's wait a while before merging to give @geoffreyclaude and others a chance to review it again if they want. > > I went through this one carefully and I think it is 👨🍳 👌 very nice. Thanks! Looks good to me, especially if the new tests pass. @ashdnazg could you please just rebase on top of main so the CI picks up my merged tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
